Re: [PATCH v2 5/8] PM / devfreq: Fix the checkpatch warnings

[MyungJoo Ham <myungjoo.ham@samsung.com>]

On Wed, Dec 28, 2016 at 8:56 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch just fixes the checkpatch warnings.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/devfreq/devfreq.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 47206a21bb90..8e5938c9c7d6 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -538,15 +538,14 @@ struct devfreq *devfreq_add_device(struct device *dev,
>         devfreq = find_device_devfreq(dev);
>         mutex_unlock(&devfreq_list_lock);
>         if (!IS_ERR(devfreq)) {
> -               dev_err(dev, "%s: Unable to create devfreq for the device. It already has one.\n", __func__);
> +               dev_err(dev, "%s: Unable to create devfreq for the device.\n",
> +                       __func__);

Actually, you do not need to try to keep it under 80col for printing strings.

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

>                 err = -EINVAL;
>                 goto err_out;
>         }
>
>         devfreq = kzalloc(sizeof(struct devfreq), GFP_KERNEL);
>         if (!devfreq) {
> -               dev_err(dev, "%s: Unable to create devfreq for the device\n",
> -                       __func__);
>                 err = -ENOMEM;
>                 goto err_out;
>         }


-- 
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics