From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <20150218143345.GC3651@saruman.tx.rr.com> References: <1424151697-2084-1-git-send-email-Sneeker.Yeh@tw.fujitsu.com> <1424151697-2084-2-git-send-email-Sneeker.Yeh@tw.fujitsu.com> <54E451B1.8020401@intel.com> <20150218143345.GC3651@saruman.tx.rr.com> Date: Wed, 18 Feb 2015 22:39:53 +0800 Message-ID: Subject: Re: [PATCH v4 1/5] xhci: add a quirk for device disconnection errata for Synopsis Designware USB3 core From: Sneeker Yeh Content-Type: multipart/alternative; boundary=001a11c0987cdc3239050f5dcaa2 To: Felipe Balbi Cc: Kumar Gala , linux-usb@vger.kernel.org, Rob Herring , Sneeker Yeh , Andy Green , Ian Campbell , linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Pawel Moll , Mark Rutland , Mathias Nyman , Greg Kroah-Hartman , Huang Rui , Jassi Brar , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Grant Likely List-ID: --001a11c0987cdc3239050f5dcaa2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, 2015/2/18 =E4=B8=8B=E5=8D=8810:34 =E6=96=BC "Felipe Balbi" = =E5=AF=AB=E9=81=93=EF=BC=9A > > On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote: > > Hi > > > > This looks correct, but if you are still going to make a new series fixing > > Felipe's comments then the following tiny nitpicks could be fixed as well. > > > > Otherwise > > > > Acked-by: Mathias Nyman > > > > Felipe, Do you want to take this series through your tree? > > I can, no issues :-) > > > On 17.02.2015 07:41, Sneeker Yeh wrote: > > > > > > +static void xhci_try_to_clear_csc(struct usb_hcd *hcd, int dev_port_num) > > > > Either add a function description explaining something like "Late > > clearing of connect status. > > Some quirky hardware will suspend the controller when CSC bit is > > cleared and leave URBs unhandled" > > > > Or change the function name to something like > > xhci_late_csc_clear_quirk() or xhci_deferred_csc_clear_quirk() > > I have a feeling xhci_late_csc_clear_quirk() is a better name, much more > descriptive than xhci_try_to_clear_csc() :-) Hmm, I'll use this one, ^^ Thanks for comment it. Much appreciate, Sneeker > > -- > balbi --001a11c0987cdc3239050f5dcaa2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi,
2015/2/18 =E4=B8=8B=E5=8D=8810:34 =E6=96=BC "Felipe Balbi" <balbi@ti.com> =E5=AF=AB=E9=81=93=EF=BC= =9A
>
> On Wed, Feb 18, 2015 at 10:47:45AM +0200, Mathias Nyman wrote:
> > Hi
> >
> > This looks correct, but if you are still going to make a new seri= es fixing
> > Felipe's comments then the following tiny nitpicks could be f= ixed as well.
> >
> > Otherwise
> >
> > Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> >
> > Felipe, Do you want to take this series through your tree?
>
> I can, no issues :-)
>
> > On 17.02.2015 07:41, Sneeker Yeh wrote:
> > >
> > > +static void xhci_try_to_clear_csc(struct usb_hcd *hcd, int = dev_port_num)
> >
> > Either add a function description explaining something like "= ;Late
> > clearing of connect status.
> > Some quirky hardware will suspend the controller when CSC bit is<= br> > > cleared and leave URBs unhandled"
> >
> > Or change the function name to something like
> > xhci_late_csc_clear_quirk() or xhci_deferred_csc_clear_quirk() >
> I have a feeling xhci_late_csc_clear_quirk() is a better name, much mo= re
> descriptive than xhci_try_to_clear_csc() :-)

Hmm, I'll use this one, ^^
Thanks for comment it.

Much appreciate,
Sneeker

>
> --
> balbi

--001a11c0987cdc3239050f5dcaa2--