From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00DE2C48BD1 for ; Fri, 11 Jun 2021 06:57:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6824610F8 for ; Fri, 11 Jun 2021 06:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6824610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrb6E-0003fT-Fz for qemu-devel@archiver.kernel.org; Fri, 11 Jun 2021 02:57:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrb5Z-0002zd-VP for qemu-devel@nongnu.org; Fri, 11 Jun 2021 02:56:22 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:37561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrb5X-0003yx-EB for qemu-devel@nongnu.org; Fri, 11 Jun 2021 02:56:21 -0400 Received: by mail-yb1-xb31.google.com with SMTP id b13so2917781ybk.4 for ; Thu, 10 Jun 2021 23:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L8GTs786ZWvgc8M9oaKPmp0arKHtW4boj5rYf5WSwn8=; b=KidulLF2gJL9Yh8w1X0ppLYARDSLSPKXl9QfN57hS8lm0Kln4+yjfvLubPx62t5rJe S6N9n8Ee/qbWw8xAOMs1+LXb4GltSTqoV0Y7+OQBJ6UgOJrYBAq5Uh2EeBjhUb6H/5k/ w/D0VGiQundrsa3T/IV87tVxQlaAilBZBbstmIzVHehknceyJpy5Z7P5Pu/HRYmYuqE9 nav+4nsT26UtFsEvPwEEnfXkPXWUO5Yr3RJI9xwATZQrCB59LWpIspUx5+BCrrG4QRl0 4Z99ccLw/YPn6abo+53jUiIF9LTxZU49ux6O9jU1J+buMgBZQoi43mw3HrqXGsg4J6il VSCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L8GTs786ZWvgc8M9oaKPmp0arKHtW4boj5rYf5WSwn8=; b=b8uM8XIZF8DZxIjqueB15viMz89sIqcl7KhxBcIV8hnsbIXY0W/940n1e+haXbe0cY 9FVGnm50mkMg/xY8T7PkhyeAXVeLe/LFdNIgwx7k7a/A/iUZ4aAflf4s0Kk5yBTBv/w6 X/hWwbVCySecsfG7wM4hivAjnc7tuOEziWHLB50N/wv0N5wSdFT01lmOaMvMpg5F2W5q /pd86mccfoWsTHjcZoUHEoXCT/Y1HIM6Sz/4iH/7Fxvn7TzL702x2ynuT8atmrrEG33D Et7b+XGfnoNxnESDw77zH4+wI7sO5vsP4XVRFllqOnjXuHySlfDObaTvcicPo3deUIgs w+jQ== X-Gm-Message-State: AOAM5307a6qMVRHY2S1zpDvpa42GLQD7wCp4Ts+XbystmoHQpsV8DmCm CfG3bP0dPT7laDN+K4SBa47+leHIRYWCDm2HcV7NevKbEgQcLBi0 X-Google-Smtp-Source: ABdhPJxavKCTXTp8+PO3VjjFMHi2ioyGbcoHC9rzyscxIZyuzLpfKPzLJQ1upO3Yz1sasWV4OTknKhBaL1ffKvNgbeY= X-Received: by 2002:a25:b74d:: with SMTP id e13mr3768153ybm.372.1623394578100; Thu, 10 Jun 2021 23:56:18 -0700 (PDT) MIME-Version: 1.0 References: <20210405131420.598273-1-basil@daynix.com> In-Reply-To: <20210405131420.598273-1-basil@daynix.com> From: Konstantin Kostiuk Date: Fri, 11 Jun 2021 09:56:05 +0300 Message-ID: Subject: Re: [PATCH 1/3] qga-win: Increase VSS freeze timeout to 60 secs instead of 10 To: Developers Content-Type: multipart/alternative; boundary="0000000000002883b505c47801f4" Received-SPF: none client-ip=2607:f8b0:4864:20::b31; envelope-from=konstantin@daynix.com; helo=mail-yb1-xb31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yan Vugenfirer , Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002883b505c47801f4 Content-Type: text/plain; charset="UTF-8" ping On Mon, Apr 5, 2021 at 4:14 PM Basil Salman wrote: > Currently Requester freeze times out after 10 seconds, while > the default timeout for Writer Freeze is 60 seconds. according to > VSS Documentation [1]. > [1]: > https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-backup-under-vss > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1909073 > > Signed-off-by: Basil Salman > Signed-off-by: Basil Salman > --- > qga/vss-win32/requester.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp > index 5378c55d23..940a2c8f55 100644 > --- a/qga/vss-win32/requester.cpp > +++ b/qga/vss-win32/requester.cpp > @@ -18,7 +18,7 @@ > #include > > /* Max wait time for frozen event (VSS can only hold writes for 10 > seconds) */ > -#define VSS_TIMEOUT_FREEZE_MSEC 10000 > +#define VSS_TIMEOUT_FREEZE_MSEC 60000 > > /* Call QueryStatus every 10 ms while waiting for frozen event */ > #define VSS_TIMEOUT_EVENT_MSEC 10 > -- > 2.17.2 > > --0000000000002883b505c47801f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
ping

On Mon, Apr 5, 2021 at 4:14 PM Basil Salman &= lt;basil@daynix.com> wrote:
<= /div>
Currently Requester = freeze times out after 10 seconds, while
the default timeout for Writer Freeze is 60 seconds. according to
VSS Documentation [1].
[1]: htt= ps://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-ba= ckup-under-vss

Buglink: https://bugzilla.redhat.com/show_bug.c= gi?id=3D1909073

Signed-off-by: Basil Salman <bsalman@daynix.com>
Signed-off-by: Basil Salman <basil@daynix.com>
---
=C2=A0qga/vss-win32/requester.cpp | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 5378c55d23..940a2c8f55 100644
--- a/qga/vss-win32/requester.cpp
+++ b/qga/vss-win32/requester.cpp
@@ -18,7 +18,7 @@
=C2=A0#include <inc/win2003/vsbackup.h>

=C2=A0/* Max wait time for frozen event (VSS can only hold writes for 10 se= conds) */
-#define VSS_TIMEOUT_FREEZE_MSEC 10000
+#define VSS_TIMEOUT_FREEZE_MSEC 60000

=C2=A0/* Call QueryStatus every 10 ms while waiting for frozen event */
=C2=A0#define VSS_TIMEOUT_EVENT_MSEC 10
--
2.17.2

--0000000000002883b505c47801f4--