Fixed and taken for submission,

Cheers,
Alex

On Tue, Feb 17, 2015 at 5:59 PM, Barros Pena, Belen <belen.barros.pena@intel.com> wrote:
This is working pretty well. The only issue is that the 'download build
log' icon is missing from the project builds page.

There is a bigger problem, though. Downloading the cooker log works, but
all other artifacts (rootfs file, task logs and other artifacts) are
throwing an error. This is the one you get when you try to download a
rootfs file

Environment:


Request Method: GET
Request URL:
http://127.0.0.1:8000/toastergui/build/1/artifact/imagefile/id/1

Django Version: 1.6
Python Version: 2.7.6
Installed Applications:
('django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.messages',
'django.contrib.sessions',
'django.contrib.admin',
'django.contrib.staticfiles',
'django.contrib.humanize',
'orm',
'toastermain',
'south',
'bldviewer',
'toastergui',
'bldcontrol')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware')


Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
in get_response
  114.                     response = wrapped_callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in build_artifact
  3055.             return _get_be_artifact(request, build_id,
artifact_type, artifact_type)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in _get_be_artifact
  3063.         file_name = _file_name_for_artifact(b, artifact_type,
artifact_id)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in _file_name_for_artifact
  2984.             file_name =
Target_Image_File.objects.get(target__build = b, pk =
artifact_id).file_name
File "/usr/local/lib/python2.7/dist-packages/django/db/models/manager.py"
in get
  151.         return self.get_queryset().get(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py" in
get
  298.         clone = self.filter(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py"
in filter
  590.         return self._filter_or_exclude(False, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/query.py"
in _filter_or_exclude
  608.             clone.query.add_q(Q(*args, **kwargs))
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py"
in add_q
  1198.         clause = self._add_q(where_part, used_aliases)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py"
in _add_q
  1232.                     current_negated=current_negated)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/query.py"
in build_filter
  1125.         clause.add(constraint, AND)
File "/usr/local/lib/python2.7/dist-packages/django/utils/tree.py" in add
  104.         data = self._prepare_data(data)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/where.py"
in _prepare_data
  79.             value = obj.prepare(lookup_type, value)
File "/usr/local/lib/python2.7/dist-packages/django/db/models/sql/where.py"
in prepare
  352.             return self.field.get_prep_lookup(lookup_type, value)
File
"/usr/local/lib/python2.7/dist-packages/django/db/models/fields/__init__.py
"
in get_prep_lookup
  369.             return self.get_prep_value(value)
File
"/usr/local/lib/python2.7/dist-packages/django/db/models/fields/__init__.py
"
in get_prep_value
  613.         return int(value)

Exception Type: ValueError at /toastergui/build/1/artifact/imagefile/id/1
Exception Value: invalid literal for int() with base 10: 'imagefile'





On 16/02/2015 18:28, "Damian, Alexandru" <alexandru.damian@intel.com>
wrote:

>Hello,
>
>I have a patch that brings in proper cooker log saving, and downloading,
>after a build.
>
>Can you please review this, see if it works ok ?
>
>
>Cheers,
>Alex
>
>
>--
>Alex Damian
>Yocto Project
>
>SSG / OTC
>
>
>




--
Alex Damian
Yocto Project
SSG / OTC