From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4A62C43381 for ; Mon, 11 Mar 2019 11:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6E012084F for ; Mon, 11 Mar 2019 11:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="GS9FAhbN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727324AbfCKLk5 (ORCPT ); Mon, 11 Mar 2019 07:40:57 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:39679 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727189AbfCKLk4 (ORCPT ); Mon, 11 Mar 2019 07:40:56 -0400 Received: by mail-lj1-f195.google.com with SMTP id g80so3719361ljg.6 for ; Mon, 11 Mar 2019 04:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XGeJu/yu28g981aZh9oEIyoO4PFUefFkvw/uajggBOc=; b=GS9FAhbNTX/8qMo8nHBu/ttexA19N/g6p56NBzYZxXSkQj3YnRxQt/wmwLjoPd3GIX HV53MiK5YhP+ZJOudnCYZtKg7r/wL026rlOV9qqTpSqW81t1PsyewmrFiqCnMht2O2tF HsD1NBlZaG2f1h3DADSBqv+cvmlYr7KXWTmvrL8aucQehIsgwb+LAVRSlPOUQTwg89N1 zgu7s5Ecp5Td7kBYl4UJT99ibIzYPG5k33NJuZEs6zZnR6exGC3zq+qWl5ROF44alzj0 MsnNeGSJjbqvS3wd8ShsaJ98vf9IJARaRXTWMqAhtL6Ap58ThzGquNxz2b/0oVe4vp2s Eg4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGeJu/yu28g981aZh9oEIyoO4PFUefFkvw/uajggBOc=; b=dTWR/vBWXWRjTenbZaTKmwFhXE6aEi1W3TBKdK0Xb1Xv2+PSSFaEcF+p8PBAoVZoX5 TJ60xd/B551FCsQ+folyJDBzc1XsOuVk6nMMsDS/nFi4U+5CSCyZvrFEznbVp2Mr5TGS 2suzzWqjBEnqaqPIZx02qoC+8pqFDF/ZIL2S1h315GzqcGTftlECGW2vc/2N7WojL3US DhBY0hNvKpHjH9SN3L1WRsgAKarYQAHb4bSzOtYW3yMqVYVkjFPz7fCbomwwkxIxS2WO iqmINC2KyzdogpF8h5HmJKvec8efAt47GkeBpbSJ8dKbiumVOXpvpwhu6iqnwjohoF2W 73rA== X-Gm-Message-State: APjAAAUBoS4caYaR/5GfK3FmgSH4PnxJCiHBCBpbvw+jffkcdv0lIA33 k96T6NngcUByqD1rBN9V1ch56vprwhRlnvB2lDMhCA== X-Google-Smtp-Source: APXvYqzqKkXivrFt8lFMFearykPYQ2344Dz1MEZFxmM6UyCkScX0jEkaEvwcCv33Eexb8RjxwaKb/sY2Q8cYaZnE+5A= X-Received: by 2002:a2e:9843:: with SMTP id e3mr14492844ljj.57.1552304454297; Mon, 11 Mar 2019 04:40:54 -0700 (PDT) MIME-Version: 1.0 References: <1551437599-29509-1-git-send-email-yash.shah@sifive.com> <1551437599-29509-3-git-send-email-yash.shah@sifive.com> <20190307152745.kaiv6q4ygf2apmuv@pengutronix.de> <20190308115726.smgooacsr37fmxwg@pengutronix.de> In-Reply-To: <20190308115726.smgooacsr37fmxwg@pengutronix.de> From: Yash Shah Date: Mon, 11 Mar 2019 17:10:17 +0530 Message-ID: Subject: Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Palmer Dabbelt , linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, Thierry Reding , robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sachin Ghadi , Paul Walmsley , kernel@pengutronix.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 8, 2019 at 5:27 PM Uwe Kleine-K=C3=B6nig wrote: > > Hello, > > On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > > On Thu, Mar 7, 2019 at 8:57 PM Uwe Kleine-K=C3=B6nig > > wrote: > > > > +static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_devi= ce *dev, > > > > + struct pwm_state *state) > > > > +{ > > > > + struct pwm_sifive_ddata *pwm =3D pwm_sifive_chip_to_ddata(chi= p); > > > > + unsigned int duty_cycle, x; > > > > + u32 frac; > > > > + struct pwm_state cur_state; > > > > + bool enabled; > > > > + int ret =3D 0; > > > > + unsigned long num; > > > > + > > > > + if (state->polarity !=3D PWM_POLARITY_INVERSED) > > > > + return -EINVAL; > > > > + > > > > + mutex_lock(&pwm->lock); > > > > + pwm_get_state(dev, &cur_state); > > > > + enabled =3D cur_state.enabled; > > > > + > > > > + if (state->period !=3D cur_state.period) { > > > > > > Did you test this with more than one consumer? For sure the following > > > should work: > > > > > > pwm1 =3D pwm_get(.. the first ..); > > > pwm_apply_state(pwm1, { .enabled =3D true, .period =3D 100000= 00, .... }); > > > > > > pwm2 =3D pwm_get(.. the second ..); > > > pwm_apply_state(pwm2, { .enabled =3D true, .period =3D 100000= 00, .... }); > > > > > > but for the second pwm_apply_state() run state->period is likely not > > > exactly 10000000. > > > > Yes, I have tested multiple consumers using sysfs interface. It is work= ing. > > Can you provide details about your testing here? What is the parent clk > rate? Which settings did you test? Can you confirm my claim that the > above sequence would fail or point out my error in reasoning? > I have tested on HiFive Unleashed board using sysfs interface. Parent clk rate is around 512 Mhz. I have tested scenarios as you mentioned above with various period and duty_cycle values. After considering your below suggestion, | To get the result independent of the prior configuration you better use | the real targeted period length as input instead of the last configured | approximation I will introduce approx_period feild, which will be used as the targeted period length. Also, in pwm_sifive_get_state, I will make below change - state->period =3D pwm->real_period; + state->period =3D pwm->approx_period. So with this change in place, I believe the cur_state.period for the second pwm_apply_state() above (pwm2) will be exactly 10000000 > > > > + x =3D 1U << PWM_SIFIVE_CMPWIDTH; > > > > + num =3D (u64)duty_cycle * x + x / 2; > > > > + frac =3D div_u64(num, state->period); > > > > > > I don't understand the "+ x / 2" part. Should this better be > > > "+ state->period / 2"? Something like > > > > This eqn is as per your comments against v5 of this patch series. > > frac =3D (duty_cycle * (1 << PWM_SIFIVE_CMPWIDTH) + (1 << > > PWM_SIFIVE_CMPWIDTH) / 2) / period; > > OK, then not only the code is wrong, but also my suggestion was. :-) > > > > #define div_u64_round(a, b) ({typeof(b) __b =3D b; div_u64(a + __b / = 2, __b)}) > > > > > > would make this less error prone. > > This still stands. It makes it easier to get the code right and makes it > easier to understand. Sure, will implement this. > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | > Industrial Linux Solutions | http://www.pengutronix.de/ = | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A854C43381 for ; Mon, 11 Mar 2019 11:41:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEA0B20657 for ; Mon, 11 Mar 2019 11:41:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ghcaxUeD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="GS9FAhbN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEA0B20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IQJ33dJk0NH3GQY/u37dE8KEsFPSwwcemBpgGVEuXPk=; b=ghcaxUeD7hqNrj 71FXt66A+YmbbnvbxDkx4nkDXKxStVqAv1AqWsuVbe/YJr1XrOep5mu67JBOBn+T6MZzckl1T5qfn bFgAQ2DVMKfVn5iD1BoViPSjwQ569ZIMxJ0tB0nCOKRdpJfNOpeqjaN4yRqO96CJ7iXZLqATDIMLd w6Sig1tSie+g0rixhOAFcRKANCceZ7nCGAeUDmvFdZio6aXBloEP4gsGwo05iBGHEP5BD8kU2PcAa VmGbfiAfEoUjdj/uxzjKDgWKTJJE7DbhYzCwfl/LvsPYY2IPQYvLEh2zN9FhiXMLDuWERSN+LQVby IhUEOGobZka+6kgKHjpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3JIi-0003zC-O7; Mon, 11 Mar 2019 11:41:00 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3JIe-0003yQ-V6 for linux-riscv@lists.infradead.org; Mon, 11 Mar 2019 11:40:59 +0000 Received: by mail-lj1-x242.google.com with SMTP id p3so67098ljg.5 for ; Mon, 11 Mar 2019 04:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XGeJu/yu28g981aZh9oEIyoO4PFUefFkvw/uajggBOc=; b=GS9FAhbNTX/8qMo8nHBu/ttexA19N/g6p56NBzYZxXSkQj3YnRxQt/wmwLjoPd3GIX HV53MiK5YhP+ZJOudnCYZtKg7r/wL026rlOV9qqTpSqW81t1PsyewmrFiqCnMht2O2tF HsD1NBlZaG2f1h3DADSBqv+cvmlYr7KXWTmvrL8aucQehIsgwb+LAVRSlPOUQTwg89N1 zgu7s5Ecp5Td7kBYl4UJT99ibIzYPG5k33NJuZEs6zZnR6exGC3zq+qWl5ROF44alzj0 MsnNeGSJjbqvS3wd8ShsaJ98vf9IJARaRXTWMqAhtL6Ap58ThzGquNxz2b/0oVe4vp2s Eg4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XGeJu/yu28g981aZh9oEIyoO4PFUefFkvw/uajggBOc=; b=HzzVeNEZtVx1PF8dtSX7CU2ra3oOqq4Z76BnoshKLu4kv8OXCk29CZdbEi5lNm/0oN iEbPPwrcLH7dk1fUUqdKP74V1abiYdsi2UJW0fGeRL6l/UsQkSzuKWNzOE5rfBRNoU0A 8Wu+qPylzhzinxb8FVDSAd3EeuY+Pfv8ZRy1Q3wskCd/bokwk7ExsbKs+pMZhUKeTT+X ADWoURQXU/Iilzxd4eUYFqcaoFlv+BJPlLLpZty9Xxw1mNJruI/YtQfgKXz/bU9X4DHk sVb57lrUbRBVOllUzHRtxboSJE0EaQM07tAa9resLKVwKwLVZhSkdIXvhEG3mb4D9XpL rPYw== X-Gm-Message-State: APjAAAWvznqSdSbLjmUnGA5qlTi/WlZV6eG2izSyhULUQbjJIiJMLEHM 13dsyS+iYcts83E9HkdcLvD83iZQo5pE0ib2cocUrA== X-Google-Smtp-Source: APXvYqzqKkXivrFt8lFMFearykPYQ2344Dz1MEZFxmM6UyCkScX0jEkaEvwcCv33Eexb8RjxwaKb/sY2Q8cYaZnE+5A= X-Received: by 2002:a2e:9843:: with SMTP id e3mr14492844ljj.57.1552304454297; Mon, 11 Mar 2019 04:40:54 -0700 (PDT) MIME-Version: 1.0 References: <1551437599-29509-1-git-send-email-yash.shah@sifive.com> <1551437599-29509-3-git-send-email-yash.shah@sifive.com> <20190307152745.kaiv6q4ygf2apmuv@pengutronix.de> <20190308115726.smgooacsr37fmxwg@pengutronix.de> In-Reply-To: <20190308115726.smgooacsr37fmxwg@pengutronix.de> From: Yash Shah Date: Mon, 11 Mar 2019 17:10:17 +0530 Message-ID: Subject: Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_044057_033686_C1919684 X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Palmer Dabbelt , linux-kernel@vger.kernel.org, robh+dt@kernel.org, Sachin Ghadi , Thierry Reding , kernel@pengutronix.de, Paul Walmsley , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgOCwgMjAxOSBhdCA1OjI3IFBNIFV3ZSBLbGVpbmUtS8O2bmlnCjx1LmtsZWlu ZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+Cj4gSGVsbG8sCj4KPiBPbiBGcmksIE1h ciAwOCwgMjAxOSBhdCAwNDo1OTozNlBNICswNTMwLCBZYXNoIFNoYWggd3JvdGU6Cj4gPiBPbiBU aHUsIE1hciA3LCAyMDE5IGF0IDg6NTcgUE0gVXdlIEtsZWluZS1Lw7ZuaWcKPiA+IDx1LmtsZWlu ZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+IHdyb3RlOgo+ID4gPiA+ICtzdGF0aWMgaW50IHB3bV9z aWZpdmVfYXBwbHkoc3RydWN0IHB3bV9jaGlwICpjaGlwLCBzdHJ1Y3QgcHdtX2RldmljZSAqZGV2 LAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHB3bV9zdGF0ZSAqc3Rh dGUpCj4gPiA+ID4gK3sKPiA+ID4gPiArICAgICBzdHJ1Y3QgcHdtX3NpZml2ZV9kZGF0YSAqcHdt ID0gcHdtX3NpZml2ZV9jaGlwX3RvX2RkYXRhKGNoaXApOwo+ID4gPiA+ICsgICAgIHVuc2lnbmVk IGludCBkdXR5X2N5Y2xlLCB4Owo+ID4gPiA+ICsgICAgIHUzMiBmcmFjOwo+ID4gPiA+ICsgICAg IHN0cnVjdCBwd21fc3RhdGUgY3VyX3N0YXRlOwo+ID4gPiA+ICsgICAgIGJvb2wgZW5hYmxlZDsK PiA+ID4gPiArICAgICBpbnQgcmV0ID0gMDsKPiA+ID4gPiArICAgICB1bnNpZ25lZCBsb25nIG51 bTsKPiA+ID4gPiArCj4gPiA+ID4gKyAgICAgaWYgKHN0YXRlLT5wb2xhcml0eSAhPSBQV01fUE9M QVJJVFlfSU5WRVJTRUQpCj4gPiA+ID4gKyAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ ID4gPiArCj4gPiA+ID4gKyAgICAgbXV0ZXhfbG9jaygmcHdtLT5sb2NrKTsKPiA+ID4gPiArICAg ICBwd21fZ2V0X3N0YXRlKGRldiwgJmN1cl9zdGF0ZSk7Cj4gPiA+ID4gKyAgICAgZW5hYmxlZCA9 IGN1cl9zdGF0ZS5lbmFibGVkOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICBpZiAoc3RhdGUtPnBl cmlvZCAhPSBjdXJfc3RhdGUucGVyaW9kKSB7Cj4gPiA+Cj4gPiA+IERpZCB5b3UgdGVzdCB0aGlz IHdpdGggbW9yZSB0aGFuIG9uZSBjb25zdW1lcj8gRm9yIHN1cmUgdGhlIGZvbGxvd2luZwo+ID4g PiBzaG91bGQgd29yazoKPiA+ID4KPiA+ID4gICAgICAgICBwd20xID0gcHdtX2dldCguLiB0aGUg Zmlyc3QgLi4pOwo+ID4gPiAgICAgICAgIHB3bV9hcHBseV9zdGF0ZShwd20xLCB7IC5lbmFibGVk ID0gdHJ1ZSwgLnBlcmlvZCA9IDEwMDAwMDAwLCAuLi4uIH0pOwo+ID4gPgo+ID4gPiAgICAgICAg IHB3bTIgPSBwd21fZ2V0KC4uIHRoZSBzZWNvbmQgLi4pOwo+ID4gPiAgICAgICAgIHB3bV9hcHBs eV9zdGF0ZShwd20yLCB7IC5lbmFibGVkID0gdHJ1ZSwgLnBlcmlvZCA9IDEwMDAwMDAwLCAuLi4u IH0pOwo+ID4gPgo+ID4gPiBidXQgZm9yIHRoZSBzZWNvbmQgcHdtX2FwcGx5X3N0YXRlKCkgcnVu IHN0YXRlLT5wZXJpb2QgaXMgbGlrZWx5IG5vdAo+ID4gPiBleGFjdGx5IDEwMDAwMDAwLgo+ID4K PiA+IFllcywgSSBoYXZlIHRlc3RlZCBtdWx0aXBsZSBjb25zdW1lcnMgdXNpbmcgc3lzZnMgaW50 ZXJmYWNlLiBJdCBpcyB3b3JraW5nLgo+Cj4gQ2FuIHlvdSBwcm92aWRlIGRldGFpbHMgYWJvdXQg eW91ciB0ZXN0aW5nIGhlcmU/IFdoYXQgaXMgdGhlIHBhcmVudCBjbGsKPiByYXRlPyBXaGljaCBz ZXR0aW5ncyBkaWQgeW91IHRlc3Q/IENhbiB5b3UgY29uZmlybSBteSBjbGFpbSB0aGF0IHRoZQo+ IGFib3ZlIHNlcXVlbmNlIHdvdWxkIGZhaWwgb3IgcG9pbnQgb3V0IG15IGVycm9yIGluIHJlYXNv bmluZz8KPgoKSSBoYXZlIHRlc3RlZCBvbiBIaUZpdmUgVW5sZWFzaGVkIGJvYXJkIHVzaW5nIHN5 c2ZzIGludGVyZmFjZS4KUGFyZW50IGNsayByYXRlIGlzIGFyb3VuZCA1MTIgTWh6LgpJIGhhdmUg dGVzdGVkIHNjZW5hcmlvcyBhcyB5b3UgbWVudGlvbmVkIGFib3ZlIHdpdGggdmFyaW91cyBwZXJp b2QgYW5kCmR1dHlfY3ljbGUgdmFsdWVzLgoKQWZ0ZXIgY29uc2lkZXJpbmcgeW91ciBiZWxvdyBz dWdnZXN0aW9uLAogfCBUbyBnZXQgdGhlIHJlc3VsdCBpbmRlcGVuZGVudCBvZiB0aGUgcHJpb3Ig Y29uZmlndXJhdGlvbiB5b3UgYmV0dGVyIHVzZQogfCB0aGUgcmVhbCB0YXJnZXRlZCBwZXJpb2Qg bGVuZ3RoIGFzIGlucHV0IGluc3RlYWQgb2YgdGhlIGxhc3QgY29uZmlndXJlZAogfCBhcHByb3hp bWF0aW9uCkkgd2lsbCBpbnRyb2R1Y2UgYXBwcm94X3BlcmlvZCBmZWlsZCwgd2hpY2ggd2lsbCBi ZSB1c2VkIGFzIHRoZQp0YXJnZXRlZCBwZXJpb2QgbGVuZ3RoLgpBbHNvLCBpbiBwd21fc2lmaXZl X2dldF9zdGF0ZSwgSSB3aWxsIG1ha2UgYmVsb3cgY2hhbmdlCi0gc3RhdGUtPnBlcmlvZCA9IHB3 bS0+cmVhbF9wZXJpb2Q7Cisgc3RhdGUtPnBlcmlvZCA9IHB3bS0+YXBwcm94X3BlcmlvZC4KU28g d2l0aCB0aGlzIGNoYW5nZSBpbiBwbGFjZSwgSSBiZWxpZXZlIHRoZSBjdXJfc3RhdGUucGVyaW9k IGZvciB0aGUKc2Vjb25kIHB3bV9hcHBseV9zdGF0ZSgpIGFib3ZlIChwd20yKSB3aWxsIGJlIGV4 YWN0bHkgMTAwMDAwMDAKCj4gPiA+ID4gKyAgICAgeCA9IDFVIDw8IFBXTV9TSUZJVkVfQ01QV0lE VEg7Cj4gPiA+ID4gKyAgICAgbnVtID0gKHU2NClkdXR5X2N5Y2xlICogeCArIHggLyAyOwo+ID4g PiA+ICsgICAgIGZyYWMgPSBkaXZfdTY0KG51bSwgc3RhdGUtPnBlcmlvZCk7Cj4gPiA+Cj4gPiA+ IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgIisgeCAvIDIiIHBhcnQuIFNob3VsZCB0aGlzIGJldHRl ciBiZQo+ID4gPiAiKyBzdGF0ZS0+cGVyaW9kIC8gMiI/IFNvbWV0aGluZyBsaWtlCj4gPgo+ID4g VGhpcyBlcW4gaXMgYXMgcGVyIHlvdXIgY29tbWVudHMgYWdhaW5zdCB2NSBvZiB0aGlzIHBhdGNo IHNlcmllcy4KPiA+ICBmcmFjID0gKGR1dHlfY3ljbGUgKiAoMSA8PCBQV01fU0lGSVZFX0NNUFdJ RFRIKSArICgxIDw8Cj4gPiBQV01fU0lGSVZFX0NNUFdJRFRIKSAvIDIpIC8gcGVyaW9kOwo+Cj4g T0ssIHRoZW4gbm90IG9ubHkgdGhlIGNvZGUgaXMgd3JvbmcsIGJ1dCBhbHNvIG15IHN1Z2dlc3Rp b24gd2FzLiA6LSkKPgo+ID4gPiAjZGVmaW5lIGRpdl91NjRfcm91bmQoYSwgYikgKHt0eXBlb2Yo YikgX19iID0gYjsgZGl2X3U2NChhICsgX19iIC8gMiwgX19iKX0pCj4gPiA+Cj4gPiA+IHdvdWxk IG1ha2UgdGhpcyBsZXNzIGVycm9yIHByb25lLgo+Cj4gVGhpcyBzdGlsbCBzdGFuZHMuIEl0IG1h a2VzIGl0IGVhc2llciB0byBnZXQgdGhlIGNvZGUgcmlnaHQgYW5kIG1ha2VzIGl0Cj4gZWFzaWVy IHRvIHVuZGVyc3RhbmQuCgpTdXJlLCB3aWxsIGltcGxlbWVudCB0aGlzLgoKPgo+IEJlc3QgcmVn YXJkcwo+IFV3ZQo+Cj4gLS0KPiBQZW5ndXRyb25peCBlLksuICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCBVd2UgS2xlaW5lLUvDtm5pZyAgICAgICAgICAgIHwKPiBJbmR1c3RyaWFsIExpbnV4 IFNvbHV0aW9ucyAgICAgICAgICAgICAgICAgfCBodHRwOi8vd3d3LnBlbmd1dHJvbml4LmRlLyAg fAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt cmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=