From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AF6C43381 for ; Sun, 24 Feb 2019 09:23:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 89D102054F for ; Sun, 24 Feb 2019 09:23:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TYpSxL/t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728175AbfBXJXy (ORCPT ); Sun, 24 Feb 2019 04:23:54 -0500 Received: from mail-yb1-f195.google.com ([209.85.219.195]:38256 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727852AbfBXJXy (ORCPT ); Sun, 24 Feb 2019 04:23:54 -0500 Received: by mail-yb1-f195.google.com with SMTP id f196so2604265yba.5 for ; Sun, 24 Feb 2019 01:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isGhhA72EMm81Zq7KoSo3gqnYi6QGWdO9Zn/eLuaj3s=; b=TYpSxL/tMwXlrPiQjrCIcHzAJQhtjpCyoxUltNpZ9ijA89M0WS5iBVOVLQBPhzwmN2 jONxY89GKKSwtr8iUFAXQOwqGRbJijM1QOTgQlmyARczQxqUgTNVCBAvaTNpJ5hrODqm DhNvd7XC0GUszl0Go8RCMOs6PXoutbqGE0hVQylZcAUIKVC4DGzSeUlJkdNEZayCOJlU u8yfdTsReLhmpvxTNIp0xYNC1kICqMG/ldbQrLgdoHchOf/zdoB52N0CLlFWtp39JLL2 Q9k+v+93AD5wzbwPkh2TGi/WVOG2ePYqEwVyUlJnX9cYuu3n6y8TpTBfXK9lscQpaX3b bI4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isGhhA72EMm81Zq7KoSo3gqnYi6QGWdO9Zn/eLuaj3s=; b=CBarvQe+bPmPbFGmMa3wcC5TcyF8p4H8ok77Oyka1yhExSc0Hqp+Fkyyww2Bi1Jike dXCE8FCevUfTwc4boMNt3pbGTUuS7V0oerVmGc6Mz/JMphPMu/3mE9tAWga0xRuDhuIh r6hq1G4JEviXk4s0Kz2rUIa/nrAjP4OSay1GVZrN6zxNvVf3yw2MGEWHMEGJOTjbHn3c fNGGHAQt7kZFVG7yWCyiUQYKamKSVAHUKtRaBNR5kbie5bTE41Z20jL7g5BXvWSP6vmz mN5TStmeurWzLHFo+SZpvW5Xbamd/hfdcj7pHpVSmRSiU/4v7MGL692SX40Xj2UVaGBe GqWA== X-Gm-Message-State: AHQUAuZkYFIYyj0yuXGEhENprqefSZ3RvcZDZI+xAEJSpU2vwQA9aUqv Sc8A879++6n9hy7msFftSPbCIPtc75MrlnwkERc= X-Google-Smtp-Source: AHgI3Ib0PGI/71N4jLOMWdvN4jk3TC9Fybaw98beEd6yuJpN8ckkGjABiQfOqiFBLLdbLj0fZj4lkgRTRM7sxrM7mJA= X-Received: by 2002:a25:c0cc:: with SMTP id c195mr9681307ybf.166.1551000233559; Sun, 24 Feb 2019 01:23:53 -0800 (PST) MIME-Version: 1.0 References: <1550715283-23579-1-git-send-email-xiangxia.m.yue@gmail.com> <1550715283-23579-2-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: From: Or Gerlitz Date: Sun, 24 Feb 2019 11:23:42 +0200 Message-ID: Subject: Re: [PATCH net-next 2/5] net/mlx5e: Make the log friendly when decapsulation offload not supported To: Tonghao Zhang Cc: Saeed Mahameed , Linux Netdev List Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 23, 2019 at 9:58 AM Tonghao Zhang wrote: > On Fri, Feb 22, 2019 at 5:07 PM Or Gerlitz wrote: > > On Fri, Feb 22, 2019 at 9:49 AM Tonghao Zhang wrote: > > > On Fri, Feb 22, 2019 at 12:32 AM Or Gerlitz wrote: > > > > On Thu, Feb 21, 2019 at 3:42 PM wrote: > > > > > > > > > > From: Tonghao Zhang > > > > > > > > > > If we try to offload decapsulation actions to VFs hw, we get the log [1]. > > > > > > > > but the switching was on the tunnel type (if (tunnel_type == [...]) - > > > Yes, but we try to offload tc flow to VF device. For example > > > the p2p1_0 is VF, but not rep >> so this should go to the nic and not esw tc offload code path in en_tc.c > nic and esw will call parse_cls_flower() to parse the flower flows, > and more information is shown as below. ok, got you. We err on the match parsing stage, this is relatively new.. up to 5.0 we were erring only on the action parsing stage. The patch seems fine, it would be good to modify mlx5e_netdev_kind() to return "unkown" and not the empty string ("") when the netdev doesn't have a kind assigned (can do this in this patch).