From: Or Gerlitz <gerlitz.or@gmail.com>
To: Huy Nguyen <huyn@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next 1/6] net/mlx5e: Support DCBX CEE API
Date: Tue, 30 Aug 2016 23:33:06 +0300 [thread overview]
Message-ID: <CAJ3xEMhKWh1_X9-SWdQHEGSUH0Z1EejCMLTXgyFizZ+-hU7Y8g@mail.gmail.com> (raw)
In-Reply-To: <1472556595-9286-2-git-send-email-saeedm@mellanox.com>
On Tue, Aug 30, 2016 at 2:29 PM, Saeed Mahameed <saeedm@mellanox.com> wrote:
> From: Huy Nguyen <huyn@mellanox.com>
>
> Add DCBX CEE API interface for CX4. Configurations are stored in a
> temporary structure and are applied to the card's firmware when the
> CEE's setall callback function is called.
>
> Note:
> priority group in CEE is equivalent to traffic class in ConnectX-4
> hardware spec.
>
> bw allocation per priority in CEE is not supported because CX4
> only supports bw allocation per traffic class.
>
> user priority in CEE does not have an equivalent term in CX4.
> Therefore, user priority to priority mapping in CEE is not supported.
basically our drivers suits (mlx4/5) are not written to a certain HW,
but rather to multiple (past, present and future) brands using dev
caps advertized by the firmware towards the driver.
I see here lots of CX4 explicit mentioning... so (1) try to avoid it
or make the description more general (2) do you base your code on dev
caps or hard coded assumptions?
> Test: see DCBX_LinuxDriverCX4 document section 6.4
what's the relevancy for the upstream commit change log?
> Signed-off-by: Huy Nguyen <huyn@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
next prev parent reply other threads:[~2016-08-30 20:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 11:29 [PATCH net-next 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 1/6] net/mlx5e: Support DCBX CEE API Saeed Mahameed
2016-08-30 20:33 ` Or Gerlitz [this message]
2016-08-30 11:29 ` [PATCH net-next 2/6] net/mlx5e: Read ETS settings directly from firmware Saeed Mahameed
2016-08-30 20:34 ` Or Gerlitz
2016-08-30 11:29 ` [PATCH net-next 3/6] net/mlx5: Add DCBX firmware commands support Saeed Mahameed
2016-08-31 11:24 ` zhuyj
2016-08-31 14:49 ` Huy Nguyen
2016-08-31 16:08 ` Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 4/6] net/mlx5e: ConnectX-4 firmware support for DCBX Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 5/6] net/mlx5e: Add DCBX control interface Saeed Mahameed
2016-08-30 11:29 ` [PATCH net-next 6/6] net/mlx5: Add handling for port module event Saeed Mahameed
2016-08-30 20:24 ` Or Gerlitz
2016-08-31 11:05 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ3xEMhKWh1_X9-SWdQHEGSUH0Z1EejCMLTXgyFizZ+-hU7Y8g@mail.gmail.com \
--to=gerlitz.or@gmail.com \
--cc=davem@davemloft.net \
--cc=huyn@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.