From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling Date: Wed, 21 Jan 2015 22:49:18 +0200 Message-ID: References: <54BE7F66.4070404@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roland Dreier Cc: Erez Shitrit , Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Amir Vadai , Eyal Perry , Erez Shitrit List-Id: linux-rdma@vger.kernel.org On Wed, Jan 21, 2015 at 10:37 PM, Roland Dreier wrote: > On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz wrote: >>> Because Doug's changes fixed some bad, easy-to-reproduce issues. On >>> the other hand we don't want to introduce new regressions to fix the >>> old issues. >> >> See above, we did introduced regressions. > > Yes, I know, that's my whole point. > > We need to fix the current 3.19-rc code, and the two choices are to > keep the fixes we added during 3.19 or revert back to 3.18. > Doug's opinion is that your proposed fix is broken, and we don't have > an alternate fix. Before we go back to 3.18, there's the option I was asking Doug to comment on, namely is it really impossible to revert the offending patch? if this is the case, I'd like to get Erez few more days to discuss his proposed patch + changes to it from code review. > So I suggest we revert the whole series from 3.19 and get this right for 3.20. Roland, I'm very happy to see that you're finally up to non -rc1 activity. This didn't happen for 3.18 and maybe also for 3.17 and you know what, it's terribly impossible to run a kernel sub-system like that. Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html