From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 3/3] IB/sa: route SA pathrecord query through netlink Date: Tue, 19 May 2015 21:30:03 +0300 Message-ID: References: <1431975616-23529-1-git-send-email-kaike.wan@intel.com> <1431975616-23529-4-git-send-email-kaike.wan@intel.com> <555AC36D.5050904@mellanox.com> <3F128C9216C9B84BB6ED23EF16290AFB0CAB243E@CRSMSX101.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <3F128C9216C9B84BB6ED23EF16290AFB0CAB243E-8k97q/ur5Z2krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Wan, Kaike" Cc: Or Gerlitz , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Fleck, John" , "Weiny, Ira" List-Id: linux-rdma@vger.kernel.org On Tue, May 19, 2015 at 3:24 PM, Wan, Kaike wrote: >> On 5/18/2015 10:00 PM, kaike.wan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: >> > --- a/drivers/infiniband/core/sa_query.c >> > +++ b/drivers/infiniband/core/sa_query.c >> > @@ -45,12 +45,22 @@ >> what's actually the role of the module param? why it belongs here? is that >> really unavoidable to have it? > It's nice to provide the capability for the user to adjust the netlink timeout based his/her fabric setup. NO, adding module params should be really your last resort when everything else wouldn't work, definitely not the case here, remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html