From: Or Gerlitz <gerlitz.or@gmail.com>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: Max Gurtovoy <maxg@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
target-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN
Date: Mon, 22 Feb 2016 16:55:03 +0200 [thread overview]
Message-ID: <CAJ3xEMiGhnsZMdPkqCo25cjdOE8pqZ3A=TfiEvMHsU8Sj3PM8Q@mail.gmail.com> (raw)
In-Reply-To: <1456148958-27973-2-git-send-email-hch@lst.de>
On Mon, Feb 22, 2016 at 3:49 PM, Christoph Hellwig <hch@lst.de> wrote:
> @@ -36,9 +36,7 @@
> -#define ISER_RECV_DATA_SEG_LEN 8192
Sagi,
Can you please explain WW (When & Why) we changed this from 128 bytes
to 8192 bytes?!! do we use 8000++ bytes for every RX descriptor or
this is nowadays only for the login phase? what's the trick?
Or.
> @@ -92,7 +90,7 @@ enum iser_conn_state {
> struct iser_rx_desc {
> struct iser_ctrl iser_header;
> struct iscsi_hdr iscsi_header;
> - char data[ISER_RECV_DATA_SEG_LEN];
> + char data[ISCSI_DEF_MAX_RECV_SEG_LEN];
> u64 dma_addr;
> struct ib_sge rx_sg;
> char pad[ISER_RX_PAD_SIZE];
> --
next prev parent reply other threads:[~2016-02-22 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 13:49 isert: convert to the new CQ API and a few random cleanups V2 Christoph Hellwig
2016-02-22 13:49 ` [PATCH 2/5] IB/isert: Split and properly type the login buffer Christoph Hellwig
[not found] ` <1456148958-27973-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-23 11:08 ` Sagi Grimberg
2016-02-25 15:19 ` Max Gurtovoy
[not found] ` <1456148958-27973-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-22 13:49 ` [PATCH 1/5] IB/isert: Remove ISER_RECV_DATA_SEG_LEN Christoph Hellwig
2016-02-22 14:55 ` Or Gerlitz [this message]
[not found] ` <CAJ3xEMiGhnsZMdPkqCo25cjdOE8pqZ3A=TfiEvMHsU8Sj3PM8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-02-22 14:57 ` Or Gerlitz
2016-02-22 15:05 ` Christoph Hellwig
[not found] ` <20160222150558.GA29553-jcswGhMUV9g@public.gmane.org>
2016-02-22 15:41 ` Sagi Grimberg
[not found] ` <1456148958-27973-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-23 11:03 ` Sagi Grimberg
[not found] ` <56CC3C95.7090301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-25 14:37 ` Max Gurtovoy
2016-02-22 13:49 ` [PATCH 3/5] IB/isert: Convert to new CQ API Christoph Hellwig
2016-02-23 11:15 ` Sagi Grimberg
[not found] ` <56CC3F39.1030002-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-23 13:31 ` Christoph Hellwig
[not found] ` <1456148958-27973-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-02-24 16:01 ` Sagi Grimberg
2016-02-24 18:43 ` Christoph Hellwig
2016-02-25 16:41 ` Max Gurtovoy
2016-02-22 13:49 ` [PATCH 5/5] IB/isert: Kill the ->isert_cmd back pointer in struct iser_tx_desc Christoph Hellwig
2016-02-23 11:23 ` Sagi Grimberg
2016-02-23 11:29 ` isert: convert to the new CQ API and a few random cleanups V2 Sagi Grimberg
2016-02-22 13:49 ` [PATCH 4/5] IB/isert: Kill struct isert_rdma_wr Christoph Hellwig
2016-02-23 11:17 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ3xEMiGhnsZMdPkqCo25cjdOE8pqZ3A=TfiEvMHsU8Sj3PM8Q@mail.gmail.com' \
--to=gerlitz.or@gmail.com \
--cc=hch@lst.de \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.