From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH v3 25/25] IB/mlx4: Workaround for mlx4_alloc_priv_pages() array allocator Date: Tue, 21 Jun 2016 08:52:45 +0300 Message-ID: References: <20160620155751.10809.22262.stgit@manet.1015granger.net> <20160620161200.10809.45762.stgit@manet.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160620161200.10809.45762.stgit-FYjufvaPoItvLzlybtyyYzGyq/o6K9yX@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chuck Lever , Yishai Hadas Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Leon Romanovsky , Sagi Grimberg List-Id: linux-rdma@vger.kernel.org On Mon, Jun 20, 2016 at 7:12 PM, Chuck Lever wrote: > Ensure the MR's PBL array never occupies the last 8 bytes of a page. > This eliminates random "Local Protection Error" flushes when SLUB > debugging is enabled. > > Fixes: 1b2cd0fc673c ('IB/mlx4: Support the new memory registration API') Can't the driver advertize smaller quantity for what's occupies later those last eight bytes (255 or 511 of attr XX instead of 256 or 512)? > Suggested-by: Christoph Hellwig > Signed-off-by: Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com ([209.85.214.182]:35675 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754104AbcFUFw7 (ORCPT ); Tue, 21 Jun 2016 01:52:59 -0400 MIME-Version: 1.0 In-Reply-To: <20160620161200.10809.45762.stgit@manet.1015granger.net> References: <20160620155751.10809.22262.stgit@manet.1015granger.net> <20160620161200.10809.45762.stgit@manet.1015granger.net> From: Or Gerlitz Date: Tue, 21 Jun 2016 08:52:45 +0300 Message-ID: Subject: Re: [PATCH v3 25/25] IB/mlx4: Workaround for mlx4_alloc_priv_pages() array allocator To: Chuck Lever , Yishai Hadas Cc: "linux-rdma@vger.kernel.org" , "linux-nfs@vger.kernel.org" , Leon Romanovsky , Sagi Grimberg Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Jun 20, 2016 at 7:12 PM, Chuck Lever wrote: > Ensure the MR's PBL array never occupies the last 8 bytes of a page. > This eliminates random "Local Protection Error" flushes when SLUB > debugging is enabled. > > Fixes: 1b2cd0fc673c ('IB/mlx4: Support the new memory registration API') Can't the driver advertize smaller quantity for what's occupies later those last eight bytes (255 or 511 of attr XX instead of 256 or 512)? > Suggested-by: Christoph Hellwig > Signed-off-by: Chuck Lever