From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers Date: Thu, 12 Nov 2015 08:04:01 +0200 Message-ID: References: <1447220077-8325-1-git-send-email-ira.weiny@intel.com> <20151111062535.GG4023@leon.nu> <20151111133907.GA21044@phlsvsds.ph.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20151111133907.GA21044-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: Leon Romanovsky , Greg Kroah-Hartman , devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Weiny, Ira" , Mike Marciniszyn List-Id: linux-rdma@vger.kernel.org On Wed, Nov 11, 2015 at 3:39 PM, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: >> On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote: >>> From: Dennis Dalessandro >>> +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, >>> - pr_alert("Snooping/Capture of Send DMA Packets Is Not >>> Supported!\n"); >>> + pr_alert("Snooping/Capture of Send DMA Packets Is Not Supported!\n"); Dennis, can we have less camelcase sort of speak in this upstream driver? this is linux here not windowZ. > Well yes, and no. They serve two different purposes. One for users of the > snoop feature the other for developers. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html