From mboxrd@z Thu Jan  1 00:00:00 1970
From: Or Gerlitz <gerlitz.or@gmail.com>
Subject: Re: [net 3/6] net/mlx5: FPGA, return -EINVAL if size is zero
Date: Wed, 8 Nov 2017 23:13:05 +0900
Message-ID: <CAJ3xEMikKDeUDdXPn9gjKB_iL8itSyz_Q5U6Y+UrKZ6E6SCHrw@mail.gmail.com>
References: <20171108072142.30870-1-saeedm@mellanox.com> <20171108072142.30870-4-saeedm@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Saeed Mahameed <saeedm@mellanox.com>,
        Linux Netdev List <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>
To: Yevgeny Kliteynik <kliteyn@mellanox.com>,
        Kamal Heib <kamalh@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ot0-f171.google.com ([74.125.82.171]:44718 "EHLO
        mail-ot0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752528AbdKHONH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 8 Nov 2017 09:13:07 -0500
Received: by mail-ot0-f171.google.com with SMTP id j24so1849806otb.1
        for <netdev@vger.kernel.org>; Wed, 08 Nov 2017 06:13:07 -0800 (PST)
In-Reply-To: <20171108072142.30870-4-saeedm@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, Nov 8, 2017 at 4:21 PM, Saeed Mahameed <saeedm@mellanox.com> wrote:
> From: Kamal Heib <kamalh@mellanox.com>
>
> In the current code, if a size of zero is passed to
> mlx5_fpga_mem_{read|write}_i2c() functions the "err"

Don't we need to fix the call site where zero size is provided and not
in called function?

Isn't sending down a zero size a sign for a bug which we are not fixing?

> return value will not initialized.
>
> Fixes: a9956d35d199 ('net/mlx5: FPGA, Add SBU infrastructure')
> Signed-off-by: Kamal Heib <kamalh@mellanox.com>
> Reviewed-by: Yevgeny Kliteynik <kliteyn@mellanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>