All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <gerlitz.or@gmail.com>
To: Jakub Kicinski <kubakici@wp.pl>
Cc: Michael Chan <michael.chan@broadcom.com>,
	David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Sathya Perla <sathya.perla@broadcom.com>,
	Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name
Date: Wed, 26 Jul 2017 12:13:35 +0300	[thread overview]
Message-ID: <CAJ3xEMj4OznaiaxT6sSuS9aUxoTDJmJbKKa=WyX_=Xhd8RVs2A@mail.gmail.com> (raw)
In-Reply-To: <20170724214521.75bf5857@cakuba.netronome.com>

On Tue, Jul 25, 2017 at 7:45 AM, Jakub Kicinski <kubakici@wp.pl> wrote:

> This is even worse.  We already have two naming conventions in the
> kernel, mlx5 uses "%d" for legacy reasons.  nfp uses pf%dvf%d for vfs,

To make it clear, in mlx5 this is used only for the offloads/switchdev mode
and not for legacy mode, in the latter mode, a  VF probed to VM doesn't
have host side representation so there's no where to use that.

Or.

> which is better for two reasons: (a) it works with multi-PF devices;
> (b) naming something representor from switchdev perspective is
> pointless, you're not calling the external port netdev a physical port
> representor, even though it has the exact same relation to the port as
> with VFs (i.e. egressing traffic on the netdev will cause the switch
> to send to the given port).

  parent reply	other threads:[~2017-07-26  9:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 16:34 [PATCH net-next 00/10] bnxt_en: Updates for net-next Michael Chan
2017-07-24 16:34 ` [PATCH net-next 01/10] bnxt_en: Update firmware interface spec to 1.8.0 Michael Chan
2017-07-24 16:34 ` [PATCH net-next 02/10] bnxt_en: Retrieve the hardware bridge mode from the firmware Michael Chan
2017-07-24 16:34 ` [PATCH net-next 03/10] bnxt_en: Implement ndo_bridge_{get|set}link methods Michael Chan
2017-07-24 16:34 ` [PATCH net-next 04/10] bnxt_en: Add bnxt_get_num_stats() to centrally get the number of ethtool stats Michael Chan
2017-07-24 16:34 ` [PATCH net-next 05/10] bnxt_en: Allow the user to set ethtool stats-block-usecs to 0 Michael Chan
2017-07-24 16:34 ` [PATCH net-next 06/10] bnxt_en: Report firmware DCBX agent Michael Chan
2017-07-24 16:34 ` [PATCH net-next 07/10] bnxt_en: Set ETS min_bw parameter for older firmware Michael Chan
2017-07-24 16:34 ` [PATCH net-next 08/10] bnxt_en: add support to enable VF-representors Michael Chan
2017-07-25  2:28   ` kbuild test robot
2017-07-24 16:34 ` [PATCH net-next 09/10] bnxt_en: add vf-rep RX/TX and netdev implementation Michael Chan
2017-07-24 16:34 ` [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name Michael Chan
2017-07-25  2:44   ` kbuild test robot
2017-07-25  4:06     ` Jakub Kicinski
2017-07-25  4:21       ` David Miller
2017-07-25  4:45   ` Jakub Kicinski
2017-07-25  5:13     ` [RFC] switchdev: clarify ndo_get_phys_port_name() formats Jakub Kicinski
2017-07-25 15:22       ` Andy Gospodarek
2017-07-25 22:26         ` Jakub Kicinski
2017-07-26  1:48           ` Andy Gospodarek
2017-07-26  2:34             ` Jakub Kicinski
2017-07-26 17:54               ` Andy Gospodarek
2017-07-26  5:48       ` Jiri Pirko
2017-07-26  8:13         ` Jakub Kicinski
2017-07-26  9:23           ` Or Gerlitz
2017-07-26 20:11             ` Jakub Kicinski
2017-07-27 10:30               ` Or Gerlitz
2017-07-28  2:31                 ` [RFC] switchdev: generate phys_port_name in the core Jakub Kicinski
2017-07-28  2:37                   ` Jakub Kicinski
2017-07-28  5:35                   ` Jiri Pirko
2017-07-28  5:58                     ` Jiri Pirko
2017-07-28  7:28                       ` Jakub Kicinski
2017-07-28  7:27                     ` Jakub Kicinski
2017-07-28 14:13                   ` Andrew Lunn
2017-07-25  9:55     ` [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name Sathya Perla
2017-07-25 22:27       ` Jakub Kicinski
2017-07-26  9:13     ` Or Gerlitz [this message]
2017-07-25  0:32 ` [PATCH net-next 00/10] bnxt_en: Updates for net-next David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ3xEMj4OznaiaxT6sSuS9aUxoTDJmJbKKa=WyX_=Xhd8RVs2A@mail.gmail.com' \
    --to=gerlitz.or@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=kubakici@wp.pl \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.