All of lore.kernel.org
 help / color / mirror / Atom feed
From: Or Gerlitz <gerlitz.or@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 0/7] net: foo-over-udp (fou)
Date: Mon, 15 Sep 2014 21:08:13 +0300	[thread overview]
Message-ID: <CAJ3xEMjC5PQENzCXS9SNVm6zUVn7pydxf1MLQ57Br1sGjD1ngQ@mail.gmail.com> (raw)
In-Reply-To: <1410750483-3236-1-git-send-email-therbert@google.com>

On Mon, Sep 15, 2014 at 6:07 AM, Tom Herbert <therbert@google.com> wrote:
[...]
> * Notes
>   - This patch set does not implement GSO for FOU. The UDP encapsulation
>     code assumes TEB, so that will need to be reimplemented.

Can you please clarify this point little further? Specifically, today
few NICs are
advertizing NETIF_F_GSO_UDP_TUNNEL when they are practically GSO
capable only w.r.t to VXLAN. What happens when such NIC expose this
cap and a large guest frame goes through GRE over UDP or alike tunneling?

>   - I really don't expect/want devices to have special support for any
>     of this. Generic checksum offload mechanisms (NETIF_HW_CSUM
>     and use of CHECKSUM_COMPLETE) should be sufficient. RSS and flow
>     steering is provided by commonly implemented UDP hashing. GRO/GSO
>     seem fairly comparable with LRO/TSO already.

Again, today NICs are advertizing checksum offloads capability in
enc_hw_features but aren't capable to compute (say) the TCP checksum
of the inner
packet regardless of which actual tunneling is used (e.g VXLAN vs
GRE), a bit inconsistent?

  parent reply	other threads:[~2014-09-15 18:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  3:07 [PATCH v2 net-next 0/7] net: foo-over-udp (fou) Tom Herbert
2014-09-15  3:07 ` [PATCH v2 net-next 1/7] net: Export inet_offloads and inet6_offloads Tom Herbert
2014-09-15 13:33   ` Or Gerlitz
2014-09-15 15:13     ` Tom Herbert
2014-09-15 17:15       ` Or Gerlitz
2014-09-15 17:32         ` Tom Herbert
2014-09-15 18:21   ` David Miller
2014-09-15  3:07 ` [PATCH v2 net-next 2/7] fou: Support for foo-over-udp RX path Tom Herbert
2014-09-15  3:07 ` [PATCH v2 net-next 3/7] fou: Add GRO support Tom Herbert
2014-09-15 15:00   ` Or Gerlitz
2014-09-15 15:10     ` Tom Herbert
2014-09-15 17:03       ` Or Gerlitz
2014-09-15 17:21         ` Tom Herbert
2014-09-15 18:22   ` David Miller
2014-09-15  3:08 ` [PATCH v2 net-next 4/7] net: Changes to ip_tunnel to support foo-over-udp encapsulation Tom Herbert
2014-09-15  3:08 ` [PATCH v2 net-next 5/7] sit: TX path for sit/UDP " Tom Herbert
2014-09-15  3:08 ` [PATCH v2 net-next 6/7] ipip: TX path for IPIP/UDP " Tom Herbert
2014-09-15  3:08 ` [PATCH v2 net-next 7/7] gre: TX path for GRE/UDP " Tom Herbert
2014-09-15 18:08 ` Or Gerlitz [this message]
2014-09-15 19:15   ` [PATCH v2 net-next 0/7] net: foo-over-udp (fou) Tom Herbert
2014-09-15 22:44     ` Jesse Gross
2014-09-15 22:59       ` Tom Herbert
2014-09-16  0:15         ` Jesse Gross
2014-09-16 12:44       ` Or Gerlitz
2014-09-16 18:34         ` Tom Herbert
2014-09-16 19:14           ` Or Gerlitz
2014-09-16 20:31             ` Tom Herbert
2014-09-16 13:35     ` Or Gerlitz
2014-09-16 15:00       ` Tom Herbert
2014-09-16 20:04         ` Or Gerlitz
2014-09-16 20:16           ` David Miller
2014-09-17 15:22             ` Or Gerlitz
2014-09-16 20:35           ` Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ3xEMjC5PQENzCXS9SNVm6zUVn7pydxf1MLQ57Br1sGjD1ngQ@mail.gmail.com \
    --to=gerlitz.or@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.