From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio Date: Sun, 21 May 2017 00:15:02 +0300 Message-ID: References: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: intel-wired-lan , Alexander Duyck , kiran.patil@intel.com, "Samudrala, Sridhar" , Mitch Williams , Neerav Parikh , Jeff Kirsher , Linux Netdev List To: Amritha Nambiar Return-path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:33379 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753856AbdETVPE (ORCPT ); Sat, 20 May 2017 17:15:04 -0400 Received: by mail-oi0-f50.google.com with SMTP id w10so126268072oif.0 for ; Sat, 20 May 2017 14:15:03 -0700 (PDT) In-Reply-To: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar wrote: > The following series introduces a new harware offload mode in tc/mqprio Wait, we have already a HW QoS model introduced by John F and Co couple of years ago, right? Please elaborate in few sentence if you are extending it/replacing it, why we want to do that and what are the implications on existing applications UAPI wise. Below you just say in the new mode Qos is configured with knobs XYZ -- this is way not enough > where the TCs, the queue configurations and bandwidth rate limits > are offloaded to the hardware. > The i40e driver enables the new mqprio hardware offload mechanism factori= ng the TCs, queue configuration and bandwidth rates by creating HW channel = VSIs. > > In this mode, the priority to traffic class mapping and the user specifie= d queue ranges are used to configure the traffic class when the 'hw' option= is set to 2. This is achieved by creating HW channels(VSI). A new channel = is created for each of the traffic class configuration offloaded via mqprio= framework except for the first TC (TC0) which is for the main VSI. TC0 for= the main VSI is also reconfigured as per user provided queue parameters. F= inally, bandwidth rate limits are set on these traffic classes through the = mqprio offload framework by sending these rates in addition to the number o= f TCs and the queue configurations. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Date: Sun, 21 May 2017 00:15:02 +0300 Subject: [Intel-wired-lan] [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio In-Reply-To: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> References: <149524122523.11022.4541073724650541658.stgit@anamdev.jf.intel.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar wrote: > The following series introduces a new harware offload mode in tc/mqprio Wait, we have already a HW QoS model introduced by John F and Co couple of years ago, right? Please elaborate in few sentence if you are extending it/replacing it, why we want to do that and what are the implications on existing applications UAPI wise. Below you just say in the new mode Qos is configured with knobs XYZ -- this is way not enough > where the TCs, the queue configurations and bandwidth rate limits > are offloaded to the hardware. > The i40e driver enables the new mqprio hardware offload mechanism factoring the TCs, queue configuration and bandwidth rates by creating HW channel VSIs. > > In this mode, the priority to traffic class mapping and the user specified queue ranges are used to configure the traffic class when the 'hw' option is set to 2. This is achieved by creating HW channels(VSI). A new channel is created for each of the traffic class configuration offloaded via mqprio framework except for the first TC (TC0) which is for the main VSI. TC0 for the main VSI is also reconfigured as per user provided queue parameters. Finally, bandwidth rate limits are set on these traffic classes through the mqprio offload framework by sending these rates in addition to the number of TCs and the queue configurations.