From mboxrd@z Thu Jan 1 00:00:00 1970 From: Or Gerlitz Subject: Re: [PATCH rdma-next 14/15] IB/mlx5: Don't advertise RAW QP support in dual port mode Date: Wed, 3 Jan 2018 22:47:14 +0200 Message-ID: References: <20171224125741.25464-1-leon@kernel.org> <20171224125741.25464-15-leon@kernel.org> <20171225071613.GW2942@mtr-leonro.local> <6f114e3c-2e16-f7ce-2e60-d06113afc9b8@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <6f114e3c-2e16-f7ce-2e60-d06113afc9b8-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Jurgens Cc: Leon Romanovsky , Or Gerlitz , Doug Ledford , Jason Gunthorpe , RDMA mailing list , Parav Pandit List-Id: linux-rdma@vger.kernel.org On Wed, Jan 3, 2018 at 10:43 PM, Daniel Jurgens wrot= e: > On 1/3/2018 2:39 PM, Or Gerlitz wrote: >> On Wed, Jan 3, 2018 at 10:35 PM, Daniel Jurgens w= rote: >>> On 12/25/2017 3:17 AM, Or Gerlitz wrote: >>>> On Mon, Dec 25, 2017 at 9:16 AM, Leon Romanovsky = wrote: >>>>> On Mon, Dec 25, 2017 at 12:16:15AM +0200, Or Gerlitz wrote: >>>>>> On Sun, Dec 24, 2017 at 2:57 PM, Leon Romanovsky w= rote: >>>>>>> From: Daniel Jurgens >>>>>>> >>>>>>> When operating in dual port RoCE mode RAW QPs are not supposed >>>>>>> to work on the slave port. >>>>>> why? >>>>> HW create flow table restriction. >>>> cryptic to me, either put a proper explanation on the V2 change log >>>> for this patch >>>> so we can review it then or explain it here if you want a review on V1 >>> We don't report RAW QP support on a per port basis. It's per device. >>> The user doesn't know which port is the master/slave, so we shouldn't >>> support RAW QP at all in this mode. I'll update the commit message to s= tate that. >> in mlx4 we do have IB device with two ports and RAW QP is supported, >> what is different there? > > mlx4 has a completely different HW architecture. It's 2 ports on 1 PCI f= unction. This feature doesn't do that for mlx5, there are still 2 PCI func= tions. It uses steering rules to route RDMA traffic arriving at the 2nd po= rt to resources in the domain of the 1st port. RDMA traffic is easy to iden= tify and steer accordingly, generic traffic over a Raw QP is not. ok, so this is basically uneasy but not undoable. Aren't we creating possible regressions for people that used RAW QP on mlx5 devices? these are open-systems and the code is out there for people to use it. Now the systems that move to the new mode has inferior functionality. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html