All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Santos <unixmania@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/eudev: add openrc init support
Date: Mon, 24 Feb 2020 23:54:16 -0300	[thread overview]
Message-ID: <CAJ4jsaf6gCoLbc3U6=Haf0_uiGSXFfhx1nni7tzsARM1cvuv8w@mail.gmail.com> (raw)
In-Reply-To: <20200224223809.0d780063@windsurf>

On Mon, Feb 24, 2020 at 6:38 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Mon, 24 Feb 2020 17:52:55 -0300
> unixmania at gmail.com wrote:
>
> > From: Carlos Santos <unixmania@gmail.com>
> >
> > Use the Gentoo scripts for openrc.
> >
> > Signed-off-by: Carlos Santos <unixmania@gmail.com>
>
> Thanks! Glad to see you're picking up some of the OpenRC effort.
>
> > +ifeq ($(BR2_INIT_OPENRC),y)
> > +EUDEV_OPENRC_INIT_VERSION = 33
> > +EUDEV_OPENRC_INIT = udev-gentoo-scripts-$(EUDEV_OPENRC_INIT_VERSION).tar.bz2
> > +EUDEV_EXTRA_DOWNLOADS = https://gitweb.gentoo.org/proj/udev-gentoo-scripts.git/snapshot/$(EUDEV_OPENRC_INIT)
> > +define EUDEV_OPENRC_INIT_EXTRACT
> > +     $(call suitable-extractor,$(notdir $(EUDEV_OPENRC_INIT))) \
> > +             $(EUDEV_DL_DIR)/$(notdir $(EUDEV_OPENRC_INIT)) | \
> > +             $(TAR) -C $(@D) $(TAR_OPTIONS) -
> > +endef
> > +EUDEV_POST_EXTRACT_HOOKS += EUDEV_OPENRC_INIT_EXTRACT
> > +endif
>
> I think I would really prefer this to be handled by a separate package,
> because that's really what you're doing here. So let's have a
> udev-gentoo-scripts package, which eudev can select when OpenRC is the
> init system. I suppose there is no need for a build-time dependency
> between the two, so just selecting at the Config.in level is probably
> enough.
>
> What do you think ?

I sent a second patch but quite frankly I don't think it's worthwhile
to add a packge.

BTW, that hack required to prevent installing the sysvinit script in
eudev.mk is ugly.

-- 
Carlos Santos <unixmania@gmail.com>

  reply	other threads:[~2020-02-25  2:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 20:52 [Buildroot] [PATCH] package/eudev: add openrc init support unixmania at gmail.com
2020-02-24 21:38 ` Thomas Petazzoni
2020-02-25  2:54   ` Carlos Santos [this message]
2020-02-25  2:43 unixmania at gmail.com
2020-02-26 21:21 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ4jsaf6gCoLbc3U6=Haf0_uiGSXFfhx1nni7tzsARM1cvuv8w@mail.gmail.com' \
    --to=unixmania@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.