From: Gregory Farnum <gfarnum@redhat.com>
To: John Spray <jspray@redhat.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: warnings in rgw_crypt.cc
Date: Mon, 14 Aug 2017 09:41:57 -0700 [thread overview]
Message-ID: <CAJ4mKGYODRagB-a6-QRMm1Npj28QdpmPq9jdfo7DygfPvS0qjg@mail.gmail.com> (raw)
In-Reply-To: <CALe9h7cCO+ZLHysdHr8AueyfkHLMvj1Wsy7CO0763cD3ydcJ3w@mail.gmail.com>
On Mon, Aug 14, 2017 at 9:38 AM, John Spray <jspray@redhat.com> wrote:
> Hi all,
>
> These have been in master for quite a while now:
>
> /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_crypt.cc:38:2:
> warning: #warning "TODO: move this code to auth/Crypto for others to
> reuse." [-Wcpp]
> #warning "TODO: move this code to auth/Crypto for others to reuse."
> ^
> /home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_crypt.cc:247:2:
> warning: #warning "TODO: use auth/Crypto instead of reimplementing."
> [-Wcpp]
> #warning "TODO: use auth/Crypto instead of reimplementing."
> ^
>
> Is anyone working in this area? Otherwise we should probably just
> create tracker tickets instead of using preprocessor macros as
> reminders.
Yes. A few key people have had fantasies that this was going to be the
next thing on X person's list, but that's clearly not happening. I'd
merge a PR changing that. :)
-Greg
next prev parent reply other threads:[~2017-08-14 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 16:38 warnings in rgw_crypt.cc John Spray
2017-08-14 16:41 ` Gregory Farnum [this message]
2017-08-15 1:48 ` Jos Collin
2017-08-15 14:46 ` Mahalingam, Ganesh
2017-08-15 22:03 ` Gregory Farnum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ4mKGYODRagB-a6-QRMm1Npj28QdpmPq9jdfo7DygfPvS0qjg@mail.gmail.com \
--to=gfarnum@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jspray@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.