From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754838Ab2EDKLi (ORCPT ); Fri, 4 May 2012 06:11:38 -0400 Received: from na3sys009aog120.obsmtp.com ([74.125.149.140]:52228 "EHLO na3sys009aog120.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754043Ab2EDKLg convert rfc822-to-8bit (ORCPT ); Fri, 4 May 2012 06:11:36 -0400 MIME-Version: 1.0 In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Date: Fri, 4 May 2012 15:41:34 +0530 Message-ID: Subject: Re: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries From: "J, KEERTHY" To: "AnilKumar, Chimata" Cc: "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Hilman, Kevin" , "rjw@sisk.pl" , "linux-kernel@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" , "Pihet-XID, Jean" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi AnilKumar, Thanks for reviewing. On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata wrote: > On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >> From: Jean Pihet >> >> Change the name field value to better reflect the smartreflex >> integration in the system. >> >> Signed-off-by: Jean Pihet >> Signed-off-by: J Keerthy >> --- >>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |    8 ++++---- >>  arch/arm/mach-omap2/smartreflex.c          |    2 +- >>  2 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> index 144d118..15907b0 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { >>  }; >> >>  static struct omap_hwmod omap34xx_sr1_hwmod = { >> -     .name           = "sr1", >> +     .name           = "smartreflex_mpu_iva", >>       .class          = &omap34xx_smartreflex_hwmod_class, >>       .main_clk       = "sr1_fck", >>       .prcm           = { >> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { >>  }; >> >>  static struct omap_hwmod omap36xx_sr1_hwmod = { >> -     .name           = "sr1", >> +     .name           = "smartreflex_mpu_iva", >>       .class          = &omap36xx_smartreflex_hwmod_class, >>       .main_clk       = "sr1_fck", >>       .prcm           = { >> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { >>  }; >> >>  static struct omap_hwmod omap34xx_sr2_hwmod = { >> -     .name           = "sr2", >> +     .name           = "smartreflex_core", >>       .class          = &omap34xx_smartreflex_hwmod_class, >>       .main_clk       = "sr2_fck", >>       .prcm           = { >> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { >>  }; >> >>  static struct omap_hwmod omap36xx_sr2_hwmod = { >> -     .name           = "sr2", >> +     .name           = "smartreflex_core", >>       .class          = &omap36xx_smartreflex_hwmod_class, >>       .main_clk       = "sr2_fck", >>       .prcm           = { >> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c >> index 2edd1e2..d859277 100644 >> --- a/arch/arm/mach-omap2/smartreflex.c >> +++ b/arch/arm/mach-omap2/smartreflex.c >> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >>               sr->err_weight = OMAP3430_SR_ERRWEIGHT; >>               sr->err_maxlimit = OMAP3430_SR_ERRMAXLIMIT; >>               sr->accum_data = OMAP3430_SR_ACCUMDATA; >> -             if (!(strcmp(sr->name, "sr1"))) { >> +             if (!(strcmp(sr->name, "smartreflex_mpu_iva"))) { > > What if voltage rail is different for mpu and iva? I have seen some devices > supports SmartReflex have different voltage rails for mpu and iva. > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards even we have different rails for mpu and iva. I will enhance the checks here. > Regards > AnilKumar -- Regards and Thanks, Keerthy From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J, KEERTHY" Subject: Re: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries Date: Fri, 4 May 2012 15:41:34 +0530 Message-ID: References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Sender: linux-kernel-owner@vger.kernel.org To: "AnilKumar, Chimata" Cc: "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Hilman, Kevin" , "rjw@sisk.pl" , "linux-kernel@vger.kernel.org" , "linux-pm@lists.linux-foundation.org" , "Pihet-XID, Jean" List-Id: linux-pm@vger.kernel.org Hi AnilKumar, Thanks for reviewing. On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata w= rote: > On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >> From: Jean Pihet >> >> Change the name field value to better reflect the smartreflex >> integration in the system. >> >> Signed-off-by: Jean Pihet >> Signed-off-by: J Keerthy >> --- >> =A0arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | =A0 =A08 ++++---- >> =A0arch/arm/mach-omap2/smartreflex.c =A0 =A0 =A0 =A0 =A0| =A0 =A02 += - >> =A02 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/m= ach-omap2/omap_hwmod_3xxx_data.c >> index 144d118..15907b0 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartr= eflex_mpu_irqs[] =3D { >> =A0}; >> >> =A0static struct omap_hwmod omap34xx_sr1_hwmod =3D { >> - =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "sr1", >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "smartreflex_mpu_iva", >> =A0 =A0 =A0 .class =A0 =A0 =A0 =A0 =A0=3D &omap34xx_smartreflex_hwmo= d_class, >> =A0 =A0 =A0 .main_clk =A0 =A0 =A0 =3D "sr1_fck", >> =A0 =A0 =A0 .prcm =A0 =A0 =A0 =A0 =A0 =3D { >> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod =3D= { >> =A0}; >> >> =A0static struct omap_hwmod omap36xx_sr1_hwmod =3D { >> - =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "sr1", >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "smartreflex_mpu_iva", >> =A0 =A0 =A0 .class =A0 =A0 =A0 =A0 =A0=3D &omap36xx_smartreflex_hwmo= d_class, >> =A0 =A0 =A0 .main_clk =A0 =A0 =A0 =3D "sr1_fck", >> =A0 =A0 =A0 .prcm =A0 =A0 =A0 =A0 =A0 =3D { >> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartr= eflex_core_irqs[] =3D { >> =A0}; >> >> =A0static struct omap_hwmod omap34xx_sr2_hwmod =3D { >> - =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "sr2", >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "smartreflex_core", >> =A0 =A0 =A0 .class =A0 =A0 =A0 =A0 =A0=3D &omap34xx_smartreflex_hwmo= d_class, >> =A0 =A0 =A0 .main_clk =A0 =A0 =A0 =3D "sr2_fck", >> =A0 =A0 =A0 .prcm =A0 =A0 =A0 =A0 =A0 =3D { >> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod =3D= { >> =A0}; >> >> =A0static struct omap_hwmod omap36xx_sr2_hwmod =3D { >> - =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "sr2", >> + =A0 =A0 .name =A0 =A0 =A0 =A0 =A0 =3D "smartreflex_core", >> =A0 =A0 =A0 .class =A0 =A0 =A0 =A0 =A0=3D &omap36xx_smartreflex_hwmo= d_class, >> =A0 =A0 =A0 .main_clk =A0 =A0 =A0 =3D "sr2_fck", >> =A0 =A0 =A0 .prcm =A0 =A0 =A0 =A0 =A0 =3D { >> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2= /smartreflex.c >> index 2edd1e2..d859277 100644 >> --- a/arch/arm/mach-omap2/smartreflex.c >> +++ b/arch/arm/mach-omap2/smartreflex.c >> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 sr->err_weight =3D OMAP3430_SR_ERRWEIGHT= ; >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 sr->err_maxlimit =3D OMAP3430_SR_ERRMAXL= IMIT; >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 sr->accum_data =3D OMAP3430_SR_ACCUMDATA= ; >> - =A0 =A0 =A0 =A0 =A0 =A0 if (!(strcmp(sr->name, "sr1"))) { >> + =A0 =A0 =A0 =A0 =A0 =A0 if (!(strcmp(sr->name, "smartreflex_mpu_iv= a"))) { > > What if voltage rail is different for mpu and iva? I have seen some d= evices > supports SmartReflex have different voltage rails for mpu and iva. > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards even we have different rails for mpu and iva. I will enhance the checks= here. > Regards > AnilKumar --=20 Regards and Thanks, Keerthy From mboxrd@z Thu Jan 1 00:00:00 1970 From: j-keerthy@ti.com (J, KEERTHY) Date: Fri, 4 May 2012 15:41:34 +0530 Subject: [PATCH V3 04/10] ARM: OMAP3: hwmod: rename the smartreflex entries In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> References: <1335462041-4949-1-git-send-email-j-keerthy@ti.com> <1335462041-4949-5-git-send-email-j-keerthy@ti.com> <331ABD5ECB02734CA317220B2BBEABC13E9B1AA2@DBDE01.ent.ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi AnilKumar, Thanks for reviewing. On Fri, May 4, 2012 at 2:00 PM, AnilKumar, Chimata wrote: > On Thu, Apr 26, 2012 at 23:10:35, J, KEERTHY wrote: >> From: Jean Pihet >> >> Change the name field value to better reflect the smartreflex >> integration in the system. >> >> Signed-off-by: Jean Pihet >> Signed-off-by: J Keerthy >> --- >> ?arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | ? ?8 ++++---- >> ?arch/arm/mach-omap2/smartreflex.c ? ? ? ? ?| ? ?2 +- >> ?2 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> index 144d118..15907b0 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c >> @@ -1324,7 +1324,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_mpu_irqs[] = { >> ?}; >> >> ?static struct omap_hwmod omap34xx_sr1_hwmod = { >> - ? ? .name ? ? ? ? ? = "sr1", >> + ? ? .name ? ? ? ? ? = "smartreflex_mpu_iva", >> ? ? ? .class ? ? ? ? ?= &omap34xx_smartreflex_hwmod_class, >> ? ? ? .main_clk ? ? ? = "sr1_fck", >> ? ? ? .prcm ? ? ? ? ? = { >> @@ -1342,7 +1342,7 @@ static struct omap_hwmod omap34xx_sr1_hwmod = { >> ?}; >> >> ?static struct omap_hwmod omap36xx_sr1_hwmod = { >> - ? ? .name ? ? ? ? ? = "sr1", >> + ? ? .name ? ? ? ? ? = "smartreflex_mpu_iva", >> ? ? ? .class ? ? ? ? ?= &omap36xx_smartreflex_hwmod_class, >> ? ? ? .main_clk ? ? ? = "sr1_fck", >> ? ? ? .prcm ? ? ? ? ? = { >> @@ -1369,7 +1369,7 @@ static struct omap_hwmod_irq_info omap3_smartreflex_core_irqs[] = { >> ?}; >> >> ?static struct omap_hwmod omap34xx_sr2_hwmod = { >> - ? ? .name ? ? ? ? ? = "sr2", >> + ? ? .name ? ? ? ? ? = "smartreflex_core", >> ? ? ? .class ? ? ? ? ?= &omap34xx_smartreflex_hwmod_class, >> ? ? ? .main_clk ? ? ? = "sr2_fck", >> ? ? ? .prcm ? ? ? ? ? = { >> @@ -1387,7 +1387,7 @@ static struct omap_hwmod omap34xx_sr2_hwmod = { >> ?}; >> >> ?static struct omap_hwmod omap36xx_sr2_hwmod = { >> - ? ? .name ? ? ? ? ? = "sr2", >> + ? ? .name ? ? ? ? ? = "smartreflex_core", >> ? ? ? .class ? ? ? ? ?= &omap36xx_smartreflex_hwmod_class, >> ? ? ? .main_clk ? ? ? = "sr2_fck", >> ? ? ? .prcm ? ? ? ? ? = { >> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c >> index 2edd1e2..d859277 100644 >> --- a/arch/arm/mach-omap2/smartreflex.c >> +++ b/arch/arm/mach-omap2/smartreflex.c >> @@ -183,7 +183,7 @@ static void sr_set_regfields(struct omap_sr *sr) >> ? ? ? ? ? ? ? sr->err_weight = OMAP3430_SR_ERRWEIGHT; >> ? ? ? ? ? ? ? sr->err_maxlimit = OMAP3430_SR_ERRMAXLIMIT; >> ? ? ? ? ? ? ? sr->accum_data = OMAP3430_SR_ACCUMDATA; >> - ? ? ? ? ? ? if (!(strcmp(sr->name, "sr1"))) { >> + ? ? ? ? ? ? if (!(strcmp(sr->name, "smartreflex_mpu_iva"))) { > > What if voltage rail is different for mpu and iva? I have seen some devices > supports SmartReflex have different voltage rails for mpu and iva. > I get the point. OMAP3 iva and mpu have a common rail. OMAP4 onwards even we have different rails for mpu and iva. I will enhance the checks here. > Regards > AnilKumar -- Regards and Thanks, Keerthy