From: Allen Hubbe <allenbh@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Atul Raut <araut@codeaurora.org>, linux-ntb@googlegroups.com
Subject: Re: [PATCH v2 2/4] NTB : Add message library NTB API
Date: Sat, 12 May 2018 20:31:34 -0400 [thread overview]
Message-ID: <CAJ80sauLUqOC0HHA8X272PC2dQLCyh7BgXOWnQWmFpPKPY0j6w@mail.gmail.com> (raw)
In-Reply-To: <CAJ80sav37tU2XhmuUN6NAA9LK9i2frPK7K87O+Tpqf6=J9gpeA@mail.gmail.com>
On Sat, May 12, 2018 at 8:25 PM, Allen Hubbe <allenbh@gmail.com> wrote:
> int send_cmd(u32 cmd_num, void *data, size_t size)
...
> if (!(ack_val & CMD_ACK_BIT) == !(cmd_val & CMD_SEQ_BIT))
> goto out;
Let that be !=.
If the ack bit is received by the peer is the same as the seq bit sent
to the peer, let that indicate acknowledement of the command sent to
the peer. In other words. If ==, ok to send the next message. If
!=, need to wait for peer to ack the current message.
next prev parent reply other threads:[~2018-05-13 0:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-06 19:20 [PATCH v2 0/4] NTB : Introduce message library Atul Raut
2018-05-06 19:20 ` [PATCH v2 1/4] " Atul Raut
2018-05-07 5:29 ` Logan Gunthorpe
2018-05-10 2:10 ` Atul Raut
2018-05-10 4:35 ` Logan Gunthorpe
2018-05-10 18:13 ` Atul Raut
2018-05-11 22:40 ` Serge Semin
2018-05-06 19:20 ` [PATCH v2 2/4] NTB : Add message library NTB API Atul Raut
2018-05-11 22:44 ` Serge Semin
2018-05-11 23:11 ` Logan Gunthorpe
2018-05-14 20:25 ` Serge Semin
2018-05-14 20:59 ` Logan Gunthorpe
2018-05-14 21:39 ` Serge Semin
2018-05-14 22:04 ` Logan Gunthorpe
2018-05-13 0:25 ` Allen Hubbe
2018-05-13 0:31 ` Allen Hubbe [this message]
2018-05-14 23:16 ` Serge Semin
2018-05-15 14:21 ` Allen Hubbe
2018-05-31 22:27 ` Serge Semin
2018-05-06 19:20 ` [PATCH v2 3/4] NTB : Modification to ntb_perf module Atul Raut
2018-05-06 19:20 ` [PATCH v2 4/4] NTB : Add support to message registers based devices Atul Raut
2018-05-11 22:39 ` [PATCH v2 0/4] NTB : Introduce message library Serge Semin
2018-05-11 23:00 ` Logan Gunthorpe
2018-05-14 20:40 ` Serge Semin
2018-05-14 21:04 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ80sauLUqOC0HHA8X272PC2dQLCyh7BgXOWnQWmFpPKPY0j6w@mail.gmail.com \
--to=allenbh@gmail.com \
--cc=araut@codeaurora.org \
--cc=fancer.lancer@gmail.com \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.