All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andre McCurdy" <armccurdy@gmail.com>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] file: Remove unneccessary override of PACKAGECONFIG for native
Date: Tue, 12 May 2020 15:19:46 -0700	[thread overview]
Message-ID: <CAJ86T=U-0v06iC5wm8opzJSO5a7k8a_a_NncF4N5ep6BwnBGTw@mail.gmail.com> (raw)
In-Reply-To: <20200512214255.20678-1-pkj@axis.com>

On Tue, May 12, 2020 at 2:43 PM Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>
> There is no reason to set PACKAGECONFIG_class-native to the same value
> as the default PACKAGECONFIG.

End users often don't know how to safely change PACKAGECONFIG from a
.bbappend and might try PACKAGECONFIG += "foo" or PACKAGECONFIG_append
= " foo" without realising that it could affect more than just the
target build.

Have an explicit PACKAGECONFIG_class-native keeps the native config
stable for users who haven't yet learning through experience that the
safe way to change PACKAGECONFIG is PACKAGECONFIG_append_class-target
= " foo".

So although this PACKAGECONFIG_class-native may seem redundant to the
experts, it helps make OE more robust for regular users.

> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
>  meta/recipes-devtools/file/file_5.38.bb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/file/file_5.38.bb b/meta/recipes-devtools/file/file_5.38.bb
> index f5ad568936..007db4790d 100644
> --- a/meta/recipes-devtools/file/file_5.38.bb
> +++ b/meta/recipes-devtools/file/file_5.38.bb
> @@ -19,7 +19,6 @@ S = "${WORKDIR}/git"
>  inherit autotools update-alternatives
>
>  PACKAGECONFIG ??= "zlib"
> -PACKAGECONFIG_class-native ??= "zlib"
>  PACKAGECONFIG[bz2] = "--enable-bzlib, --disable-bzlib, bzip2"
>  PACKAGECONFIG[lzma] = "--enable-xzlib, --disable-xzlib, xz"
>  PACKAGECONFIG[zlib] = "--enable-zlib, --disable-zlib, zlib"
> --
> 2.21.3
>
> 

  reply	other threads:[~2020-05-12 22:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-12 21:42 [PATCH] file: Remove unneccessary override of PACKAGECONFIG for native Peter Kjellerstedt
2020-05-12 22:19 ` Andre McCurdy [this message]
2020-05-13 17:14   ` [OE-core] " Peter Kjellerstedt
2020-05-13 19:30     ` Andre McCurdy
2020-05-13 21:31       ` Richard Purdie
2020-05-13 22:48         ` Andre McCurdy
2020-05-14 16:09           ` Peter Kjellerstedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ86T=U-0v06iC5wm8opzJSO5a7k8a_a_NncF4N5ep6BwnBGTw@mail.gmail.com' \
    --to=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peter.kjellerstedt@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.