[PATCH 1/2] qemuarmv5: add softfp

[PATCH 1/2] qemuarmv5: add softfp

[Jon Mason]

pulseaudio-14.2 is throwing the following error when compiling for
machine qemuarmv5
"NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softfp or -mfloat-abi=hard"

Using softfp to resolve this issue.

Signed-off-by: Jon Mason <jon.mason@arm.com>
Change-Id: I513ed523f03ed091507a099e3f80fa95a6fc7ca9
---
 meta/conf/machine/qemuarmv5.conf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/conf/machine/qemuarmv5.conf b/meta/conf/machine/qemuarmv5.conf
index dfe2a89573b2..29bcc1199ea1 100644
--- a/meta/conf/machine/qemuarmv5.conf
+++ b/meta/conf/machine/qemuarmv5.conf
@@ -18,3 +18,4 @@ PREFERRED_VERSION_linux-yocto ??= "5.10%"
 QB_DTB = "${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', '4.7', '', 'zImage-versatile-pb.dtb', d)}"
 
 KMACHINE_qemuarmv5 = "qemuarm"
+TUNE_CCARGS_MFLOAT = "softfp"
-- 
2.20.1

[PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Jon Mason]

Currently seeing the following error when running runqemu on qemuarmv5:
runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB

This is due to the memory size being set to 512 instead of the max
allowable of 256.  Limit to this and everything is happy.

Signed-off-by: Jon Mason <jon.mason@arm.com>
Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
---
 meta/recipes-sato/images/core-image-sato.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
index e50b24a47691..8ed8f75e9f92 100644
--- a/meta/recipes-sato/images/core-image-sato.bb
+++ b/meta/recipes-sato/images/core-image-sato.bb
@@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
 
 QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
 QB_MEM_qemumips = "-m 256"
+QB_MEM_qemuarmv5 = "-m 256"
-- 
2.20.1

Re: [OE-core] [PATCH 1/2] qemuarmv5: add softfp

[Andre McCurdy]

On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
>
> pulseaudio-14.2 is throwing the following error when compiling for
> machine qemuarmv5
> "NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softfp or -mfloat-abi=hard"
>
> Using softfp to resolve this issue.

Wouldn't "sidestep" be a more accurate description then "resolve" ?

Either way I'm not sure that changing qemuarmv5 just to workaround one
broken package is the right approach. Doesn't it mean OE will no
longer have any test coverage for ARM soft float?

> Signed-off-by: Jon Mason <jon.mason@arm.com>
> Change-Id: I513ed523f03ed091507a099e3f80fa95a6fc7ca9

Not sure if there's an official policy for this, but personally I'd
say your own private gerrit IDs should be stripped before pushing
changes upstream.

> ---
>  meta/conf/machine/qemuarmv5.conf | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/conf/machine/qemuarmv5.conf b/meta/conf/machine/qemuarmv5.conf
> index dfe2a89573b2..29bcc1199ea1 100644
> --- a/meta/conf/machine/qemuarmv5.conf
> +++ b/meta/conf/machine/qemuarmv5.conf
> @@ -18,3 +18,4 @@ PREFERRED_VERSION_linux-yocto ??= "5.10%"
>  QB_DTB = "${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', '4.7', '', 'zImage-versatile-pb.dtb', d)}"
>
>  KMACHINE_qemuarmv5 = "qemuarm"
> +TUNE_CCARGS_MFLOAT = "softfp"
> --
> 2.20.1
>
>
> 
>

Re: [OE-core] [PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Andre McCurdy]

On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
>
> Currently seeing the following error when running runqemu on qemuarmv5:
> runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB
>
> This is due to the memory size being set to 512 instead of the max
> allowable of 256.  Limit to this and everything is happy.
>
> Signed-off-by: Jon Mason <jon.mason@arm.com>
> Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
> ---
>  meta/recipes-sato/images/core-image-sato.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> index e50b24a47691..8ed8f75e9f92 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
>
>  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
>  QB_MEM_qemumips = "-m 256"
> +QB_MEM_qemuarmv5 = "-m 256"

Grepping for QB_MEM suggests there are other images which need the
same fix. Maybe good to fix all of them at once rather than one at a
time.

> 2.20.1
>
>
> 
>

Re: [OE-core] [PATCH 1/2] qemuarmv5: add softfp

[Jon Mason]

On Wed, Mar 10, 2021 at 6:25 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
> >
> > pulseaudio-14.2 is throwing the following error when compiling for
> > machine qemuarmv5
> > "NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softfp or -mfloat-abi=hard"
> >
> > Using softfp to resolve this issue.
>
> Wouldn't "sidestep" be a more accurate description then "resolve" ?
>
> Either way I'm not sure that changing qemuarmv5 just to workaround one
> broken package is the right approach. Doesn't it mean OE will no
> longer have any test coverage for ARM soft float?

With these obvious issues, no one is even compiling these, let alone
testing qemuarmv5.  And these issues have probably been around for
months.  Even after getting all of these issues addressed, qemuarmv5
is still failing testimage.  Honestly, it should be dropped since it's
not really being used.  If you are only worried about compiling, there
are other machines in other layers that can be used for this.

> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > Change-Id: I513ed523f03ed091507a099e3f80fa95a6fc7ca9
>
> Not sure if there's an official policy for this, but personally I'd
> say your own private gerrit IDs should be stripped before pushing
> changes upstream.

These can be dropped if they are problematic.  I haven't heard they
are forbidden.

>
> > ---
> >  meta/conf/machine/qemuarmv5.conf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/conf/machine/qemuarmv5.conf b/meta/conf/machine/qemuarmv5.conf
> > index dfe2a89573b2..29bcc1199ea1 100644
> > --- a/meta/conf/machine/qemuarmv5.conf
> > +++ b/meta/conf/machine/qemuarmv5.conf
> > @@ -18,3 +18,4 @@ PREFERRED_VERSION_linux-yocto ??= "5.10%"
> >  QB_DTB = "${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', '4.7', '', 'zImage-versatile-pb.dtb', d)}"
> >
> >  KMACHINE_qemuarmv5 = "qemuarm"
> > +TUNE_CCARGS_MFLOAT = "softfp"
> > --
> > 2.20.1
> >
> >
> > 
> >

Re: [OE-core] [PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Jon Mason]

On Wed, Mar 10, 2021 at 6:30 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
> >
> > Currently seeing the following error when running runqemu on qemuarmv5:
> > runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB
> >
> > This is due to the memory size being set to 512 instead of the max
> > allowable of 256.  Limit to this and everything is happy.
> >
> > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
> > ---
> >  meta/recipes-sato/images/core-image-sato.bb | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> > index e50b24a47691..8ed8f75e9f92 100644
> > --- a/meta/recipes-sato/images/core-image-sato.bb
> > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > @@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
> >
> >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
> >  QB_MEM_qemumips = "-m 256"
> > +QB_MEM_qemuarmv5 = "-m 256"
>
> Grepping for QB_MEM suggests there are other images which need the
> same fix. Maybe good to fix all of them at once rather than one at a
> time.

I do not know if other machines have this same issue with qemu, and
this is probably not the best way to resolve this (as I really think
this should be part of the machine config file, and have runqemu be
smarter logic about setting the memory size).  I can open a bug in
bugzilla and get back to it later.

>
> > 2.20.1
> >
> >
> > 
> >

Re: [OE-core] [PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Khem Raj]

On 3/10/21 7:16 PM, Jon Mason wrote:
> On Wed, Mar 10, 2021 at 6:30 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>>
>> On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
>>>
>>> Currently seeing the following error when running runqemu on qemuarmv5:
>>> runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB
>>>
>>> This is due to the memory size being set to 512 instead of the max
>>> allowable of 256.  Limit to this and everything is happy.
>>>
>>> Signed-off-by: Jon Mason <jon.mason@arm.com>
>>> Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
>>> ---
>>>   meta/recipes-sato/images/core-image-sato.bb | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
>>> index e50b24a47691..8ed8f75e9f92 100644
>>> --- a/meta/recipes-sato/images/core-image-sato.bb
>>> +++ b/meta/recipes-sato/images/core-image-sato.bb
>>> @@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
>>>
>>>   QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
>>>   QB_MEM_qemumips = "-m 256"
>>> +QB_MEM_qemuarmv5 = "-m 256"
>>
>> Grepping for QB_MEM suggests there are other images which need the
>> same fix. Maybe good to fix all of them at once rather than one at a
>> time.
> 
> I do not know if other machines have this same issue with qemu, and
> this is probably not the best way to resolve this (as I really think
> this should be part of the machine config file, and have runqemu be
> smarter logic about setting the memory size).  I can open a bug in
> bugzilla and get back to it later.

perhaps we should define MAX_MEMORY to define this limit for every 
emulated machine and present a diagnostic if QB_MEM exceded MAX value

> 
>>
>>> 2.20.1
>>>
>>>
>>>
>>>
>>>
>>>
>>> 
>>>

Re: [OE-core] [PATCH 1/2] qemuarmv5: add softfp

[Andre McCurdy]

On Wed, Mar 10, 2021 at 7:09 PM Jon Mason <jdmason@kudzu.us> wrote:
>
> On Wed, Mar 10, 2021 at 6:25 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> >
> > On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
> > >
> > > pulseaudio-14.2 is throwing the following error when compiling for
> > > machine qemuarmv5
> > > "NEON intrinsics not available with the soft-float ABI.  Please use -mfloat-abi=softfp or -mfloat-abi=hard"
> > >
> > > Using softfp to resolve this issue.
> >
> > Wouldn't "sidestep" be a more accurate description then "resolve" ?
> >
> > Either way I'm not sure that changing qemuarmv5 just to workaround one
> > broken package is the right approach. Doesn't it mean OE will no
> > longer have any test coverage for ARM soft float?
>
> With these obvious issues, no one is even compiling these, let alone
> testing qemuarmv5.  And these issues have probably been around for
> months.  Even after getting all of these issues addressed, qemuarmv5
> is still failing testimage.  Honestly, it should be dropped since it's
> not really being used.  If you are only worried about compiling, there
> are other machines in other layers that can be used for this.

The issue with pulseaudio has been discussed on the list and bugs have
been raised upstream. It's due to pulseaudio's switch to meson (ie the
autotools build still correctly detects ARM soft float, although
switching back to the autotools build obviously isn't a good long term
solution).

If you want to drop soft float support in qemuarmv5 or drop the
machine config entirely then there may be valid arguments for doing
that, but a bug in the pulseaudio meson build doesn't seem to be one
of them (since it's completely independent of qemuarmv5).

> > > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > > Change-Id: I513ed523f03ed091507a099e3f80fa95a6fc7ca9
> >
> > Not sure if there's an official policy for this, but personally I'd
> > say your own private gerrit IDs should be stripped before pushing
> > changes upstream.
>
> These can be dropped if they are problematic.  I haven't heard they
> are forbidden.

I haven't heard they are forbidden either, I was just giving my opinion.

> > > ---
> > >  meta/conf/machine/qemuarmv5.conf | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/conf/machine/qemuarmv5.conf b/meta/conf/machine/qemuarmv5.conf
> > > index dfe2a89573b2..29bcc1199ea1 100644
> > > --- a/meta/conf/machine/qemuarmv5.conf
> > > +++ b/meta/conf/machine/qemuarmv5.conf
> > > @@ -18,3 +18,4 @@ PREFERRED_VERSION_linux-yocto ??= "5.10%"
> > >  QB_DTB = "${@oe.utils.version_less_or_equal('PREFERRED_VERSION_linux-yocto', '4.7', '', 'zImage-versatile-pb.dtb', d)}"
> > >
> > >  KMACHINE_qemuarmv5 = "qemuarm"
> > > +TUNE_CCARGS_MFLOAT = "softfp"
> > > --
> > > 2.20.1
> > >
> > >
> > > 
> > >

Re: [OE-core] [PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Andre McCurdy]

On Wed, Mar 10, 2021 at 7:16 PM Jon Mason <jdmason@kudzu.us> wrote:
>
> On Wed, Mar 10, 2021 at 6:30 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> >
> > On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
> > >
> > > Currently seeing the following error when running runqemu on qemuarmv5:
> > > runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB
> > >
> > > This is due to the memory size being set to 512 instead of the max
> > > allowable of 256.  Limit to this and everything is happy.
> > >
> > > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > > Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
> > > ---
> > >  meta/recipes-sato/images/core-image-sato.bb | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> > > index e50b24a47691..8ed8f75e9f92 100644
> > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > @@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
> > >
> > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
> > >  QB_MEM_qemumips = "-m 256"
> > > +QB_MEM_qemuarmv5 = "-m 256"
> >
> > Grepping for QB_MEM suggests there are other images which need the
> > same fix. Maybe good to fix all of them at once rather than one at a
> > time.
>
> I do not know if other machines have this same issue with qemu

It's not related to other machines. There are other images which set
QB_MEM to "-m 512" based on the opengl distro feature. If
qemu-system-arm versatilepb can only support 256MB then these images
need to force QB_MEM to 256MB in the same way that you have done for
core-image-sato.

Cleaning up QB_MEM and how the qemu machine configs may more cleanly
control it is a separate issue.

>, and
> this is probably not the best way to resolve this (as I really think
> this should be part of the machine config file, and have runqemu be
> smarter logic about setting the memory size).  I can open a bug in
> bugzilla and get back to it later.
>
> >
> > > 2.20.1
> > >
> > >
> > > 
> > >

Re: [OE-core] [PATCH 2/2] core-image-sato: qemuarmv5 doesn't work with >256M RAM

[Jon Mason]

On Wed, Mar 10, 2021 at 10:59 PM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> On 3/10/21 7:16 PM, Jon Mason wrote:
> > On Wed, Mar 10, 2021 at 6:30 PM Andre McCurdy <armccurdy@gmail.com> wrote:
> >>
> >> On Wed, Mar 10, 2021 at 3:04 PM Jon Mason <jdmason@kudzu.us> wrote:
> >>>
> >>> Currently seeing the following error when running runqemu on qemuarmv5:
> >>> runqemu - ERROR - Failed to run qemu: qemu-system-arm: versatilepb: memory size must not exceed 256MB
> >>>
> >>> This is due to the memory size being set to 512 instead of the max
> >>> allowable of 256.  Limit to this and everything is happy.
> >>>
> >>> Signed-off-by: Jon Mason <jon.mason@arm.com>
> >>> Change-Id: I3339e50a53464b95f52a987ed37868ebf0935b07
> >>> ---
> >>>   meta/recipes-sato/images/core-image-sato.bb | 1 +
> >>>   1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> >>> index e50b24a47691..8ed8f75e9f92 100644
> >>> --- a/meta/recipes-sato/images/core-image-sato.bb
> >>> +++ b/meta/recipes-sato/images/core-image-sato.bb
> >>> @@ -14,3 +14,4 @@ TOOLCHAIN_HOST_TASK_remove_task-populate-sdk-ext = " nativesdk-intltool nativesd
> >>>
> >>>   QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m 512", "-m 256", d)}'
> >>>   QB_MEM_qemumips = "-m 256"
> >>> +QB_MEM_qemuarmv5 = "-m 256"
> >>
> >> Grepping for QB_MEM suggests there are other images which need the
> >> same fix. Maybe good to fix all of them at once rather than one at a
> >> time.
> >
> > I do not know if other machines have this same issue with qemu, and
> > this is probably not the best way to resolve this (as I really think
> > this should be part of the machine config file, and have runqemu be
> > smarter logic about setting the memory size).  I can open a bug in
> > bugzilla and get back to it later.
>
> perhaps we should define MAX_MEMORY to define this limit for every
> emulated machine and present a diagnostic if QB_MEM exceded MAX value

I'm making an assumption that QB_MEM is the max.  If we simply added
sanity checks to the places where it is overridden, there would be no
problems.  It shouldn't be too hard to do, but based on other comments
I think it's best to abandon this series and simply remove qemuarmv5.


>
> >
> >>
> >>> 2.20.1
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> 
> >>>