All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] package_rpm.bbclass: use multithreaded xz compression
Date: Thu, 1 Jun 2017 12:02:38 -0700	[thread overview]
Message-ID: <CAJ86T=Vgkosu=ubwF62dp8mHhaL7n1nKfSQXi4G1Si5F3J6TfA@mail.gmail.com> (raw)
In-Reply-To: <dc21b6be8d46f824831ff9bf4a5055dec3895b6b.1496329361.git.alexander.kanavin@linux.intel.com>

On Thu, Jun 1, 2017 at 8:15 AM, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> RPM's default is single-threaded gz; the change greatly helps with
> both buildtimes (when there is a small number of large-sized packages)
> and disk space taken by resulting rpms.

Do you have any test results for that? Obviously build times will be
longer when building with a single CPU since xz compression needs more
CPU than gzip, but I'm curious how many CPUs are required before the
multiple threads win over and build times actually get shorter. 4? 8?

One other concern with parallel xz compression is memory usage. Single
threaded xz needs more memory than gzip and running multiple xz
compression threads together will push the memory usage up again.
Maybe not an issue if the peak is still acceptable, but something to
be aware of (I've given up trying to build in 4GB, but hopefully 8GB
build machines still have some life left in them...).

> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
> ---
>  meta/classes/package_rpm.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index a844c4d4360..dc241975c3b 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -644,6 +644,8 @@ python do_package_rpm () {
>      cmd = cmd + " --define '_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm'"
>      cmd = cmd + " --define '_use_internal_dependency_generator 0'"
>      cmd = cmd + " --define '_binaries_in_noarch_packages_terminate_build 0'"
> +    cmd = cmd + " --define '_binary_payload w6T.xzdio'"
> +    cmd = cmd + " --define '_source_payload w6T.xzdio'"
>      if perfiledeps:
>          cmd = cmd + " --define '__find_requires " + outdepends + "'"
>          cmd = cmd + " --define '__find_provides " + outprovides + "'"
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


  parent reply	other threads:[~2017-06-01 19:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 15:15 [PATCH 0/2] Multi-threaded RPM support Alexander Kanavin
2017-06-01 15:15 ` [PATCH 1/2] package_rpm.bbclass: use multithreaded xz compression Alexander Kanavin
2017-06-01 17:11   ` Mark Hatle
2017-06-01 17:44     ` Alexander Kanavin
2017-06-01 19:02   ` Andre McCurdy [this message]
2017-06-02 11:40     ` Alexander Kanavin
2017-06-02 18:33       ` Andre McCurdy
2017-06-01 15:15 ` [PATCH 2/2] rpm: run binary package generation via thread pools Alexander Kanavin
2017-06-01 16:02   ` Alexander Kanavin
2017-06-02 12:44     ` Alexander Kanavin
2017-06-01 16:52 ` [PATCH 0/2] Multi-threaded RPM support Leonardo Sandoval
2017-06-01 17:13   ` Mark Hatle
2017-06-01 17:37     ` Alexander Kanavin
2017-06-02 21:41       ` Leonardo Sandoval
2017-06-02 22:20 ` Richard Purdie
2017-06-04 14:15 ` Richard Purdie
2017-06-05 12:14   ` Alexander Kanavin
2017-06-05 12:41     ` Alexander Kanavin
2017-06-05 13:01     ` Burton, Ross
2017-06-05 13:15       ` Alexander Kanavin
2017-06-05 13:21     ` Joshua Lock
2017-06-05 13:34       ` Alexander Kanavin
2017-06-05 13:47         ` Davis, Michael
2017-06-05 14:00           ` Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ86T=Vgkosu=ubwF62dp8mHhaL7n1nKfSQXi4G1Si5F3J6TfA@mail.gmail.com' \
    --to=armccurdy@gmail.com \
    --cc=alexander.kanavin@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.