From: Andre McCurdy <armccurdy@gmail.com>
To: Ross Burton <ross.burton@intel.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH V2] libjpeg-turbo: don't depend on NASM for non-x86 targets
Date: Mon, 3 Apr 2017 10:03:44 -0700 [thread overview]
Message-ID: <CAJ86T=WFKTpB=ZAffa0_zttrh3uEjuKV+1gLcvmxcgkxPhTb-Q@mail.gmail.com> (raw)
In-Reply-To: <1491221074-30437-1-git-send-email-ross.burton@intel.com>
On Mon, Apr 3, 2017 at 5:04 AM, Ross Burton <ross.burton@intel.com> wrote:
> NASM is a x86-specific assembler so it is only required when building for x86
> targets. Use x86-architecture and class-target overrides to depend on NASM, but
> explicitly disable and don't depend on it for native as complications in the
> native overrides meant NASM was enabled for x86-64 but disabled for x86 (this
> will be investigated later).
>
> Original patch by Tristan Van Berkom <tristan.vanberkom@codethink.co.uk>, more
> work to solve selftest failures by Richard Purdie
> <richard.purdie@linuxfoundation.org>. I just wrote a nice commit message.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
> index 70d38f4..6f407cc 100644
> --- a/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
> +++ b/meta/recipes-graphics/jpeg/libjpeg-turbo_1.5.1.bb
> @@ -7,7 +7,8 @@ LIC_FILES_CHKSUM = "file://cdjpeg.h;endline=13;md5=05bab7c7ad899d85bfba60da1a127
> file://jpeglib.h;endline=16;md5=f67d70e547a2662c079781c72f877f72 \
> file://djpeg.c;endline=11;md5=b90b6d2b4119f9e5807cd273f525d2af \
> "
> -DEPENDS = "nasm-native"
> +DEPENDS_append_x86-64_class-target = " nasm-native"
> +DEPENDS_append_x86_class-target = " nasm-native"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz \
> file://fix-mips.patch"
> @@ -26,6 +27,9 @@ RCONFLICTS_${PN} += "jpeg"
>
> inherit autotools pkgconfig
>
> +# Add nasm-native dependency consistently for all build arches is hard
> +EXTRA_OECONF_append_class-native = "--without-simd"
Missing space?
> +
> # Work around missing x32 ABI support
> EXTRA_OECONF_append_class-target = " ${@bb.utils.contains("TUNE_FEATURES", "mx32", "--without-simd", "", d)}"
>
> --
> 2.8.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2017-04-03 17:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 12:04 [PATCH V2] libjpeg-turbo: don't depend on NASM for non-x86 targets Ross Burton
2017-04-03 17:03 ` Andre McCurdy [this message]
2017-04-03 17:25 ` Burton, Ross
2017-04-04 8:08 ` Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=WFKTpB=ZAffa0_zttrh3uEjuKV+1gLcvmxcgkxPhTb-Q@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.