Re: [PATCH 2/2] apr/apr-util: Add ptest dependency on libgcc

[Andre McCurdy <armccurdy@gmail.com>]

On Mon, May 20, 2019 at 11:43 AM Khem Raj <raj.khem@gmail.com> wrote:
> On 5/16/19 4:49 AM, Richard Purdie wrote:
> > Avoid:
> >
> > libgcc_s.so.1 must be installed for pthread_cancel to work
> >
> > when running the ptest without libgcc.
>
> this is interesting, do we get this error explicitly from running some
> tests ?
>
> I wonder why libgcc is not detected during rdep calculation time.

Other questions... why does it only affect ptest and not other use
cases? Is calling dlopen() on libgcc glibc specific? If so, perhaps a
better fix would be to add the rdep to the glibc pthreads library?

> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >   meta/recipes-support/apr/apr-util_1.6.1.bb | 1 +
> >   meta/recipes-support/apr/apr_1.7.0.bb      | 2 ++
> >   2 files changed, 3 insertions(+)
> >
> > diff --git a/meta/recipes-support/apr/apr-util_1.6.1.bb b/meta/recipes-support/apr/apr-util_1.6.1.bb
> > index 0c90f8d2527..1f9fea25d87 100644
> > --- a/meta/recipes-support/apr/apr-util_1.6.1.bb
> > +++ b/meta/recipes-support/apr/apr-util_1.6.1.bb
> > @@ -79,6 +79,7 @@ INSANE_SKIP_${PN} += "dev-so"
> >   inherit ptest
> >
> >   RDEPENDS_${PN}-ptest_append_libc-glibc = " glibc-gconv-iso8859-1 glibc-gconv-iso8859-2 glibc-gconv-utf-7"
> > +RDEPENDS_${PN}-ptest += "libgcc"
> >
> >   do_compile_ptest() {
> >       cd ${B}/test
> > diff --git a/meta/recipes-support/apr/apr_1.7.0.bb b/meta/recipes-support/apr/apr_1.7.0.bb
> > index a58651d0774..09a65bfdd68 100644
> > --- a/meta/recipes-support/apr/apr_1.7.0.bb
> > +++ b/meta/recipes-support/apr/apr_1.7.0.bb
> > @@ -53,6 +53,8 @@ do_configure_prepend() {
> >   FILES_${PN}-dev += "${libdir}/apr.exp ${datadir}/build-1/*"
> >   RDEPENDS_${PN}-dev += "bash"
> >
> > +RDEPENDS_${PN}-ptest += "libgcc"
> > +
> >   #for some reason, build/libtool.m4 handled by buildconf still be overwritten
> >   #when autoconf, so handle it again.
> >   do_configure_append() {
> >
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core