All of lore.kernel.org
 help / color / mirror / Atom feed
* [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
       [not found] <20210723214527.2225841-1-fib@cisco.com>
@ 2021-07-23 21:45 ` Ruslan Babayev (fib)
  2021-07-26 15:04   ` Steve Sakoman
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 2/3] qemu.inc: Add seccomp PACKAGECONFIG option Ruslan Babayev (fib)
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 3/3] qemu: Enable seccomp if FEATURE is set Ruslan Babayev (fib)
  2 siblings, 1 reply; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-23 21:45 UTC (permalink / raw)
  To: openembedded-core
  Cc: Samuli Piippo, Samuli Piippo, Richard Purdie, Ruslan Babayev

From: Samuli Piippo <samuli.piippo@gmail.com>

CMake depends on having all formats supported and build issues can
arise when zstd is not available:
https://gitlab.kitware.com/cmake/cmake/-/issues/21552

Quote from a CMake dev:
"As far as CMake's design is concerned, we have no optional formats.
All should be supported. That's why we bundle sufficiently new versions
of libarchive and libzstd. If a distro builds with an older libarchive
that doesn't have zstd support, then that is not a proper packaging of CMake."

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ruslan Babayev <fib@cisco.com>
---
 meta/recipes-devtools/cmake/cmake-native_3.16.5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
index b2952ee5f5..6034b654da 100644
--- a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
+++ b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
@@ -1,7 +1,7 @@
 require cmake.inc
 inherit native
 
-DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native"
+DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native zstd-native"
 
 SRC_URI += "file://OEToolchainConfig.cmake \
             file://environment.d-cmake.sh \
-- 
2.26.2.Cisco


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [OE-core][dunfell][PATCH v2 2/3] qemu.inc: Add seccomp PACKAGECONFIG option
       [not found] <20210723214527.2225841-1-fib@cisco.com>
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support Ruslan Babayev (fib)
@ 2021-07-23 21:45 ` Ruslan Babayev (fib)
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 3/3] qemu: Enable seccomp if FEATURE is set Ruslan Babayev (fib)
  2 siblings, 0 replies; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-23 21:45 UTC (permalink / raw)
  To: openembedded-core; +Cc: Nathan Rossi, Richard Purdie, Ruslan Babayev

From: Nathan Rossi <nathan@nathanrossi.com>

Add the seccomp PACKAGECONFIG option to allow building seccomp features
in QEMU. The libseccomp library is available in additional layers (e.g.
meta-security).

Additionally this serves as a way to disable seccomp by default to avoid
the configure of QEMU automatically finding it (via pkg-config) on the
build host when building qemu-system-native and auto enabling the
feature.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ruslan Babayev <fib@cisco.com>
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index 8f927bdf54..e25c2524aa 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -210,6 +210,7 @@ PACKAGECONFIG[glusterfs] = "--enable-glusterfs,--disable-glusterfs"
 PACKAGECONFIG[xkbcommon] = "--enable-xkbcommon,--disable-xkbcommon,libxkbcommon"
 PACKAGECONFIG[libudev] = "--enable-libudev,--disable-libudev,eudev"
 PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable-libxml2,libxml2"
+PACKAGECONFIG[seccomp] = "--enable-seccomp,--disable-seccomp,libseccomp"
 
 INSANE_SKIP_${PN} = "arch"
 
-- 
2.26.2.Cisco


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [OE-core][dunfell][PATCH v2 3/3] qemu: Enable seccomp if FEATURE is set
       [not found] <20210723214527.2225841-1-fib@cisco.com>
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support Ruslan Babayev (fib)
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 2/3] qemu.inc: Add seccomp PACKAGECONFIG option Ruslan Babayev (fib)
@ 2021-07-23 21:45 ` Ruslan Babayev (fib)
  2 siblings, 0 replies; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-23 21:45 UTC (permalink / raw)
  To: openembedded-core; +Cc: Armin Kuster, Richard Purdie, Ruslan Babayev

From: Armin Kuster <akuster808@gmail.com>

Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Ruslan Babayev <fib@cisco.com>
---
 meta/recipes-devtools/qemu/qemu_4.2.0.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu_4.2.0.bb b/meta/recipes-devtools/qemu/qemu_4.2.0.bb
index 9c76144749..f9905e2812 100644
--- a/meta/recipes-devtools/qemu/qemu_4.2.0.bb
+++ b/meta/recipes-devtools/qemu/qemu_4.2.0.bb
@@ -26,5 +26,6 @@ do_install_append_class-nativesdk() {
 PACKAGECONFIG ??= " \
     fdt sdl kvm \
     ${@bb.utils.filter('DISTRO_FEATURES', 'alsa xen', d)} \
+    ${@bb.utils.filter('DISTRO_FEATURES', 'seccomp', d)} \
 "
 PACKAGECONFIG_class-nativesdk ??= "fdt sdl kvm"
-- 
2.26.2.Cisco


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
  2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support Ruslan Babayev (fib)
@ 2021-07-26 15:04   ` Steve Sakoman
  2021-07-26 22:27     ` Ruslan Babayev (fib)
  0 siblings, 1 reply; 8+ messages in thread
From: Steve Sakoman @ 2021-07-26 15:04 UTC (permalink / raw)
  To: fib
  Cc: Patches and discussions about the oe-core layer, Samuli Piippo,
	Samuli Piippo, Richard Purdie

On Fri, Jul 23, 2021 at 11:45 AM Ruslan Babayev (fib) via
lists.openembedded.org <fib=cisco.com@lists.openembedded.org> wrote:
>
> From: Samuli Piippo <samuli.piippo@gmail.com>
>
> CMake depends on having all formats supported and build issues can
> arise when zstd is not available:
> https://gitlab.kitware.com/cmake/cmake/-/issues/21552
>
> Quote from a CMake dev:
> "As far as CMake's design is concerned, we have no optional formats.
> All should be supported. That's why we bundle sufficiently new versions
> of libarchive and libzstd. If a distro builds with an older libarchive
> that doesn't have zstd support, then that is not a proper packaging of CMake."
>
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
>  meta/recipes-devtools/cmake/cmake-native_3.16.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> index b2952ee5f5..6034b654da 100644
> --- a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> +++ b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> @@ -1,7 +1,7 @@
>  require cmake.inc
>  inherit native
>
> -DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native"
> +DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native zstd-native"

In hardknott/master the zstd recipe has been moved from
meta-openembedded to oe-core.  This is not the case for dunfell, so
this change will result in failures for builds that do not include
meta-openembedded.

So this patch is not suitable for dunfell unless the
community/steering committee decide to also move the recipe in
dunfell.

Steve

>
>  SRC_URI += "file://OEToolchainConfig.cmake \
>              file://environment.d-cmake.sh \
> --
> 2.26.2.Cisco
>
>
> 
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
  2021-07-26 15:04   ` Steve Sakoman
@ 2021-07-26 22:27     ` Ruslan Babayev (fib)
  2021-07-27  0:40       ` Steve Sakoman
  0 siblings, 1 reply; 8+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-26 22:27 UTC (permalink / raw)
  To: Steve Sakoman
  Cc: Patches and discussions about the oe-core layer, Samuli Piippo,
	Samuli Piippo, Richard Purdie

Hi Steve,

Thanks for reviewing the patches. I understand the problem of merging this patch as is.
But Dunfell currently has a host contamination issue on systems with zstd installed as part of base OS resulting in broken cmake-native recipe. Can you help bring this up to the attention of the steering committee?

As for the other two patches in the series. Do they look OK? Do you see any issues in merging them? Or would you like me to separated them from the cmake patch?

Thanks,
Ruslan

-----Original Message-----
From: Steve Sakoman <steve@sakoman.com> 
Sent: Monday, July 26, 2021 8:05 AM
To: Ruslan Babayev (fib) <fib@cisco.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>; Samuli Piippo <samuli.piippo@gmail.com>; Samuli Piippo <samuli.piippo@qt.io>; Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support

On Fri, Jul 23, 2021 at 11:45 AM Ruslan Babayev (fib) via lists.openembedded.org <fib=cisco.com@lists.openembedded.org> wrote:
>
> From: Samuli Piippo <samuli.piippo@gmail.com>
>
> CMake depends on having all formats supported and build issues can 
> arise when zstd is not available:
> https://gitlab.kitware.com/cmake/cmake/-/issues/21552
>
> Quote from a CMake dev:
> "As far as CMake's design is concerned, we have no optional formats.
> All should be supported. That's why we bundle sufficiently new 
> versions of libarchive and libzstd. If a distro builds with an older 
> libarchive that doesn't have zstd support, then that is not a proper packaging of CMake."
>
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
>  meta/recipes-devtools/cmake/cmake-native_3.16.5.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb 
> b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> index b2952ee5f5..6034b654da 100644
> --- a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> +++ b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> @@ -1,7 +1,7 @@
>  require cmake.inc
>  inherit native
>
> -DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native"
> +DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native zstd-native"

In hardknott/master the zstd recipe has been moved from meta-openembedded to oe-core.  This is not the case for dunfell, so this change will result in failures for builds that do not include meta-openembedded.

So this patch is not suitable for dunfell unless the community/steering committee decide to also move the recipe in dunfell.

Steve

>
>  SRC_URI += "file://OEToolchainConfig.cmake \
>              file://environment.d-cmake.sh \
> --
> 2.26.2.Cisco
>
>
> 
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
  2021-07-26 22:27     ` Ruslan Babayev (fib)
@ 2021-07-27  0:40       ` Steve Sakoman
  2021-07-27  7:24         ` Richard Purdie
  0 siblings, 1 reply; 8+ messages in thread
From: Steve Sakoman @ 2021-07-27  0:40 UTC (permalink / raw)
  To: Ruslan Babayev (fib)
  Cc: Patches and discussions about the oe-core layer, Samuli Piippo,
	Samuli Piippo, Richard Purdie

On Mon, Jul 26, 2021 at 12:27 PM Ruslan Babayev (fib) <fib@cisco.com> wrote:
>
> Hi Steve,
>
> Thanks for reviewing the patches. I understand the problem of merging this patch as is.
> But Dunfell currently has a host contamination issue on systems with zstd installed as part of base OS resulting in broken cmake-native recipe. Can you help bring this up to the attention of the steering committee?

Perhaps Richard can comment on this.  You are asking for a feature
change to dunfell that involves modifications in both
openembedded-core and meta-openembedded. So both technical steering
committees would need to agree that this is appropriate.

> As for the other two patches in the series. Do they look OK? Do you see any issues in merging them? Or would you like me to separated them from the cmake patch?

The other two patches don't have issues, so no need to re-submit!

Steve
>
> Thanks,
> Ruslan
>
> -----Original Message-----
> From: Steve Sakoman <steve@sakoman.com>
> Sent: Monday, July 26, 2021 8:05 AM
> To: Ruslan Babayev (fib) <fib@cisco.com>
> Cc: Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>; Samuli Piippo <samuli.piippo@gmail.com>; Samuli Piippo <samuli.piippo@qt.io>; Richard Purdie <richard.purdie@linuxfoundation.org>
> Subject: Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
>
> On Fri, Jul 23, 2021 at 11:45 AM Ruslan Babayev (fib) via lists.openembedded.org <fib=cisco.com@lists.openembedded.org> wrote:
> >
> > From: Samuli Piippo <samuli.piippo@gmail.com>
> >
> > CMake depends on having all formats supported and build issues can
> > arise when zstd is not available:
> > https://gitlab.kitware.com/cmake/cmake/-/issues/21552
> >
> > Quote from a CMake dev:
> > "As far as CMake's design is concerned, we have no optional formats.
> > All should be supported. That's why we bundle sufficiently new
> > versions of libarchive and libzstd. If a distro builds with an older
> > libarchive that doesn't have zstd support, then that is not a proper packaging of CMake."
> >
> > Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > Signed-off-by: Ruslan Babayev <fib@cisco.com>
> > ---
> >  meta/recipes-devtools/cmake/cmake-native_3.16.5.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> > b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> > index b2952ee5f5..6034b654da 100644
> > --- a/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> > +++ b/meta/recipes-devtools/cmake/cmake-native_3.16.5.bb
> > @@ -1,7 +1,7 @@
> >  require cmake.inc
> >  inherit native
> >
> > -DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native"
> > +DEPENDS += "bzip2-replacement-native expat-native xz-native zlib-native curl-native ncurses-native zstd-native"
>
> In hardknott/master the zstd recipe has been moved from meta-openembedded to oe-core.  This is not the case for dunfell, so this change will result in failures for builds that do not include meta-openembedded.
>
> So this patch is not suitable for dunfell unless the community/steering committee decide to also move the recipe in dunfell.
>
> Steve
>
> >
> >  SRC_URI += "file://OEToolchainConfig.cmake \
> >              file://environment.d-cmake.sh \
> > --
> > 2.26.2.Cisco
> >
> >
> > 
> >

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
  2021-07-27  0:40       ` Steve Sakoman
@ 2021-07-27  7:24         ` Richard Purdie
  2021-07-27 17:05           ` Andre McCurdy
  0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2021-07-27  7:24 UTC (permalink / raw)
  To: Steve Sakoman, Ruslan Babayev (fib), Armin Kuster
  Cc: Patches and discussions about the oe-core layer, Samuli Piippo,
	Samuli Piippo

On Mon, 2021-07-26 at 14:40 -1000, Steve Sakoman wrote:
> On Mon, Jul 26, 2021 at 12:27 PM Ruslan Babayev (fib) <fib@cisco.com> wrote:
> > 
> > Hi Steve,
> > 
> > Thanks for reviewing the patches. I understand the problem of merging this 
> > patch as is.
> > But Dunfell currently has a host contamination issue on systems with zstd 
> > installed as part of base OS resulting in broken cmake-native recipe. Can 
> > you help bring this up to the attention of the steering committee?
> 
> Perhaps Richard can comment on this.  You are asking for a feature
> change to dunfell that involves modifications in both
> openembedded-core and meta-openembedded. So both technical steering
> committees would need to agree that this is appropriate.

We don't have to go straight to the TSC, the layer maintainers can try and
agree a plan first.

I've added Armin as meta-openembedded maintainer for dunfell.

Context: cmake-native suffers host contamination on dunfell due to zstd being
detected on the host. The upstream cmake community say they don't support 
configuring it without it.

Do we agree we should move zstd from meta-oe to oe-core in dunfell to fix 
this? Should we patch cmake in dunfell to try and use it's own copy of zstd 
internally? The latter is more risky in that we've not tried that and multiple
configures can be 'fun' in builds. Moving the recipe has a different kind of
pain.

Thoughts?

Cheers,

Richard


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support
  2021-07-27  7:24         ` Richard Purdie
@ 2021-07-27 17:05           ` Andre McCurdy
  0 siblings, 0 replies; 8+ messages in thread
From: Andre McCurdy @ 2021-07-27 17:05 UTC (permalink / raw)
  To: Richard Purdie
  Cc: Steve Sakoman, Ruslan Babayev (fib),
	Armin Kuster, Patches and discussions about the oe-core layer,
	Samuli Piippo, Samuli Piippo

On Tue, Jul 27, 2021 at 12:24 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Mon, 2021-07-26 at 14:40 -1000, Steve Sakoman wrote:
> > On Mon, Jul 26, 2021 at 12:27 PM Ruslan Babayev (fib) <fib@cisco.com> wrote:
> > >
> > > Hi Steve,
> > >
> > > Thanks for reviewing the patches. I understand the problem of merging this
> > > patch as is.
> > > But Dunfell currently has a host contamination issue on systems with zstd
> > > installed as part of base OS resulting in broken cmake-native recipe. Can
> > > you help bring this up to the attention of the steering committee?
> >
> > Perhaps Richard can comment on this.  You are asking for a feature
> > change to dunfell that involves modifications in both
> > openembedded-core and meta-openembedded. So both technical steering
> > committees would need to agree that this is appropriate.
>
> We don't have to go straight to the TSC, the layer maintainers can try and
> agree a plan first.
>
> I've added Armin as meta-openembedded maintainer for dunfell.
>
> Context: cmake-native suffers host contamination on dunfell due to zstd being
> detected on the host. The upstream cmake community say they don't support
> configuring it without it.
>
> Do we agree we should move zstd from meta-oe to oe-core in dunfell to fix
> this? Should we patch cmake in dunfell to try and use it's own copy of zstd
> internally? The latter is more risky in that we've not tried that and multiple
> configures can be 'fun' in builds. Moving the recipe has a different kind of
> pain.

There's no need to move the recipe, just adding to oe-core should be enough.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-27 17:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210723214527.2225841-1-fib@cisco.com>
2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 1/3] cmake-native: enabled zstd support Ruslan Babayev (fib)
2021-07-26 15:04   ` Steve Sakoman
2021-07-26 22:27     ` Ruslan Babayev (fib)
2021-07-27  0:40       ` Steve Sakoman
2021-07-27  7:24         ` Richard Purdie
2021-07-27 17:05           ` Andre McCurdy
2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 2/3] qemu.inc: Add seccomp PACKAGECONFIG option Ruslan Babayev (fib)
2021-07-23 21:45 ` [OE-core][dunfell][PATCH v2 3/3] qemu: Enable seccomp if FEATURE is set Ruslan Babayev (fib)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.