From: Andre McCurdy <armccurdy@gmail.com>
To: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets
Date: Thu, 26 Jan 2017 15:43:52 -0800 [thread overview]
Message-ID: <CAJ86T=WxBVjhFMED3Y6tFnSjjdXbU9A-sYBfpfj5JUjMa9L7mg@mail.gmail.com> (raw)
In-Reply-To: <e981be87-9ea5-83df-6ee1-a52ffda3fb1e@gmail.com>
On Thu, Jan 26, 2017 at 2:41 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On 1/25/17 1:43 PM, Andre McCurdy wrote:
>> When cross compiling, the word size of the compiler set via HOST_CC
>> must match the word size of the target. That's achieved by appending
>> "-m32" to BUILD_CC_ARCH if the target word size is known to be 32bits.
>>
>> Unfortunately the current list of over-rides (powerpc, x86 and arm)
>> does not cover all cases (e.g. it ignores MIPS). Using SITEINFO_BITS
>> is a more generic solution.
>>
>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>> ---
>> meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> index 964dc1d..430279f 100644
>> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.4.bb
>> @@ -11,7 +11,7 @@ SRC_URI[sha256sum] = "620fa4eb12375021bef6e4f237cbd2dd5d49e56beb414bee052c746bee
>>
>> S = "${WORKDIR}/LuaJIT-${PV}"
>>
>> -inherit pkgconfig binconfig
>> +inherit pkgconfig binconfig siteinfo
>>
>> BBCLASSEXTEND = "native"
>>
>> @@ -21,9 +21,7 @@ BBCLASSEXTEND = "native"
>> # you need to install the multilib development package (e.g.
>> # libc6-dev-i386 on Debian/Ubuntu) and build a 32 bit host part
>> # (HOST_CC="gcc -m32").
>> -BUILD_CC_ARCH_append_powerpc = ' -m32'
>> -BUILD_CC_ARCH_append_x86 = ' -m32'
>> -BUILD_CC_ARCH_append_arm = ' -m32'
>> +BUILD_CC_ARCH_append = " ${@['-m32',''][d.getVar('SITEINFO_BITS') != '32']}"
>
> not related but
> This makes me think about another issue, will it work on non-x86 build
> machines, currently we do have aarch64 based boxes
Right (unless aarch64 host toolchains accept "-m32"?)
Building on 32bit x86 is probably broken too.
>> # The lua makefiles expect the TARGET_SYS to be from uname -s
>> # Values: Windows, Linux, Darwin, iOS, SunOS, PS3, GNU/kFreeBSD
>>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
next prev parent reply other threads:[~2017-01-26 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 21:43 [meta-oe][PATCH] luajit: test SITEINFO_BITS instead of maintaining a list of 32bit targets Andre McCurdy
2017-01-26 22:41 ` Khem Raj
2017-01-26 23:43 ` Andre McCurdy [this message]
2017-03-13 19:24 ` Andre McCurdy
2017-03-13 19:32 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=WxBVjhFMED3Y6tFnSjjdXbU9A-sYBfpfj5JUjMa9L7mg@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.