All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre McCurdy <armccurdy@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	openembedded-architecture
	<openembedded-architecture@lists.openembedded.org>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [Openembedded-architecture] Cached size of off_t
Date: Tue, 12 Jan 2016 16:22:57 -0800	[thread overview]
Message-ID: <CAJ86T=XNsV6gVhFvN2EEDbTV=FWaDL+XnLJjBj5t9kJVfViirg@mail.gmail.com> (raw)
In-Reply-To: <CAMKF1spYKDvYh2uvVBVqesyFM0_jAdYYTBnzEnOfQ-YQXw-xsA@mail.gmail.com>

On Tue, Jan 12, 2016 at 4:19 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Tue, Jan 12, 2016 at 4:09 PM, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
>> On Tue, 12 Jan 2016 15:23:33 Khem Raj wrote:
>>> Hi
>>>
>>> We cache size of off_t in site files and the value is 4 in most cases
>>>
>>>
>>> meta/site/arm-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/ix86-common:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/nios2-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/powerpc32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=4}
>>> meta/site/x32-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>>> meta/site/x86_64-linux:ac_cv_sizeof_off_t=${ac_cv_sizeof_off_t=8}
>>>
>>>
>>> However this value is wrong when largefile support is enabled (which is
>>> default) on most OE based distros. It also lands us in nasty bugs which are
>>> complicated to uncover eg. the curl issue
>>>
>>> http://git.openembedded.org/openembedded-core/commit/?id=3c58712465494e441c4
>>> 036a7cf21d2e6d343efab
>>>
>>> and just in OE-Core more e.g. grub2,libsndfile1,pax are showing same
>>> symptoms.
>>>
>>> I think this value should be left for configure to compute and
>>> autotools.bbclass should pass --{enable|disable}-largefile based upon
>>> DISTRO_FEATURES enabling largefile support
>>>
>>> Do we see any downsides or point I might have missed
>>
>> IIRC I think the issue was older configure scripts without the capability to
>> compute this properly (where we're not auto-reconf'ing them).
>
> Thanks Paul.
> I think in that case it is better to move that into the concerned
> recipe and let defaults be reversed

How do these older configure scripts work today for MIPS and SH4 which
don't seem to define ac_cv_sizeof_off_t in their site files?

>>
>> Ross, any thoughts?
>>
>> Cheers,
>> Paul
>>
>> --
>>
>> Paul Eggleton
>> Intel Open Source Technology Centre
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


  reply	other threads:[~2016-01-13  0:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 23:23 Cached size of off_t Khem Raj
2016-01-13  0:09 ` [Openembedded-architecture] " Paul Eggleton
2016-01-13  0:19   ` Khem Raj
2016-01-13  0:22     ` Andre McCurdy [this message]
2016-01-13  9:00   ` Burton, Ross
2016-01-14 11:33 ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ86T=XNsV6gVhFvN2EEDbTV=FWaDL+XnLJjBj5t9kJVfViirg@mail.gmail.com' \
    --to=armccurdy@gmail.com \
    --cc=openembedded-architecture@lists.openembedded.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.