From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 20B83E009F4; Thu, 10 May 2018 16:41:33 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (armccurdy[at]gmail.com) * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.217.196 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id D8B63E00831 for ; Thu, 10 May 2018 16:41:31 -0700 (PDT) Received: by mail-ua0-f196.google.com with SMTP id d4-v6so2454955ual.10 for ; Thu, 10 May 2018 16:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Nb4FoL4/jw2K9vkkMxyFaAosx2MH0Ltid0MRQl5KcLg=; b=fDZjQhQka9M38Snu1ZyyfyDcPcZ9wXPADeXD1aV3pUaZztFoGjzG8zwrBTod5dnBMl Rbchs8ALLrWxpHsgyp6mTvPsjGbMNbdkI1FVhEogW2Q1OCgN+xhFgAgPeO+N6wesCBzr 6ZGAC/OBi7RLT/tkIiQKiieR0iZ7ryF58nL2BvF4RHDs5LwIJw1JrogB1Sj9uLePji1E SPRcP+P0Vs85aMxk3nJ9qCdebjLLwfHasTIeIEkHNo0aPun5pl//oa+JwF8X7wI+rdwo IZg8KMjtlCWFk1vaOMZBS2WwvDrdsXZ3M6RVxbJNoivQb7nt1usgqYbndAJVQZwEOW4s gKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Nb4FoL4/jw2K9vkkMxyFaAosx2MH0Ltid0MRQl5KcLg=; b=oNnJiz207YJe7DDjzZP4cTd+7y26Bn/8N0w/5xxt1OtLowvDeAnIzUYLmcjoB8sdVn 1ngVQNA97uqkR6s2mjTLiLNSejwkAddjEDsU6e4m//V5dTErJGdz5IH4agnWma9Vx8zF bLEYpgNVFQFDVGdILcGpg1F8DLaw+J/1COhvtfUdZnvvcNJNquhwCvlPEg9nxxIgUNsD qETMyclajwlp84CzVih9x/0PcpZhV/obLSEvrBHWY9xc7xsC+gGJPM4rnLZsV+QO/OG7 elZRHmRW5LzBh94aIrLMaOHlY/tklfBu58uP0rnmjwql+ma/FnQH0zoRs2nS9BL9JEbL y/RQ== X-Gm-Message-State: ALKqPwfAjYHBpTz2P536z/mlm30D//llA7bsY1iITyj4ZnX+nYCKHcX0 J+m6n96w5hP2pD8eyLgTDKGmGq0gi0qjOekPt3Q= X-Google-Smtp-Source: AB8JxZpuwpGA3LwK+i614PWiLnHmmZ9Ip6qcn5doE80EcU3ua6ng9uz2d6WW2s0sYVFUFUHte62C4jRwREe53a2SNAY= X-Received: by 2002:ab0:1567:: with SMTP id p36-v6mr2601359uae.81.1525995690735; Thu, 10 May 2018 16:41:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.48.148 with HTTP; Thu, 10 May 2018 16:41:30 -0700 (PDT) In-Reply-To: <20180510233233.GF1954@jama> References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> <20180510233233.GF1954@jama> From: Andre McCurdy Date: Thu, 10 May 2018 16:41:30 -0700 Message-ID: To: Martin Jansa Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [OE-core] [RFT] GCC 8.1 X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:41:33 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 4:32 PM, Martin Jansa wrote: > On Thu, May 10, 2018 at 04:11:00PM -0700, Andre McCurdy wrote: >> On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >> > On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >> >> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >> >> > see >> >> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >> >> >> >> Removing -fno-omit-frame-pointer isn't the same as adding >> >> -fomit-frame-pointer. Frame pointers may get enabled depending on the >> >> optimisation level etc (ie not only by -fno-omit-frame-pointer). >> > >> > Should I send v2 adding -fomit-frame-pointer instead of removing >> > -fno-omit-frame-pointer? >> > >> > The v1 fixes the issue for me with default config + DEBUG_BUILD. >> >> The v1 patch isn't wrong, it's just incomplete (the problem could come >> back if someone changes optimisation level or switches gcc to clang, >> etc). >> >> My choice would be a v2 patch which adds -fomit-frame-pointer to >> CFLAGS unconditionally for all ARM builds when Thumb is enabled. That >> should fix the problem for all optimisation levels etc and avoids >> building the main strace binary differently depending on whether or >> not ptest is enabled. > > Only for thumb? makes me a bit sad that thumb override was dropped by > you in > 351443d71eb246a946b41f12b54d57b36fe1574e No need for a thumb over-ride. You can copy and paste from the musl recipe: CFLAGS_append_arm = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}" From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f195.google.com (mail-ua0-f195.google.com [209.85.217.195]) by mail.openembedded.org (Postfix) with ESMTP id 353FE75408; Thu, 10 May 2018 23:41:29 +0000 (UTC) Received: by mail-ua0-f195.google.com with SMTP id b25-v6so2471984uak.3; Thu, 10 May 2018 16:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Nb4FoL4/jw2K9vkkMxyFaAosx2MH0Ltid0MRQl5KcLg=; b=fDZjQhQka9M38Snu1ZyyfyDcPcZ9wXPADeXD1aV3pUaZztFoGjzG8zwrBTod5dnBMl Rbchs8ALLrWxpHsgyp6mTvPsjGbMNbdkI1FVhEogW2Q1OCgN+xhFgAgPeO+N6wesCBzr 6ZGAC/OBi7RLT/tkIiQKiieR0iZ7ryF58nL2BvF4RHDs5LwIJw1JrogB1Sj9uLePji1E SPRcP+P0Vs85aMxk3nJ9qCdebjLLwfHasTIeIEkHNo0aPun5pl//oa+JwF8X7wI+rdwo IZg8KMjtlCWFk1vaOMZBS2WwvDrdsXZ3M6RVxbJNoivQb7nt1usgqYbndAJVQZwEOW4s gKHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Nb4FoL4/jw2K9vkkMxyFaAosx2MH0Ltid0MRQl5KcLg=; b=GAuvh9kNsHSmpff4JGhHoNeElBoS6z7JBatlYDxjVb/2t8XMwcJgqW9tPTTgbJt3JC cQO5x+s0I1oHDwralZP3gZmM2dYwAORebVC79kmynRxzeVMdopGZsxF93SazjfAj1Aeh SThbtN4Iy3I/9781IxhRuEhRhphhpKSw0BV49DU0T+YC7iVzqFM/gWbgkJ9aEgSLjugt +yQRzTweQvFzaeNrs7ftyn7xJQmcZg1zlL44F+B2iSQKPy8x64jaqDford/9qwKG9NJ8 L0E7fUg3kiROVWGFG09+uZD+VRz7bxhXrkSKMc2QSBFbzYQw6ijvnIpRLH1JXfg6mKrI HThQ== X-Gm-Message-State: ALKqPwfgfS9hR1ibTxBjfNYlWP23aWJYEwbDNyr8V3WSq1A60Rzn4uCf H3gMp+Fl+HmUqiGyUjM3Ewnp/93rWEGExuw/qAk= X-Google-Smtp-Source: AB8JxZpuwpGA3LwK+i614PWiLnHmmZ9Ip6qcn5doE80EcU3ua6ng9uz2d6WW2s0sYVFUFUHte62C4jRwREe53a2SNAY= X-Received: by 2002:ab0:1567:: with SMTP id p36-v6mr2601359uae.81.1525995690735; Thu, 10 May 2018 16:41:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.48.148 with HTTP; Thu, 10 May 2018 16:41:30 -0700 (PDT) In-Reply-To: <20180510233233.GF1954@jama> References: <8d962430-ac63-5e97-fd32-2c0464c62acb@gmail.com> <20180510191145.GA1954@jama> <20180510214325.GC1954@jama> <20180510220735.GD1954@jama> <20180510225017.GE1954@jama> <20180510233233.GF1954@jama> From: Andre McCurdy Date: Thu, 10 May 2018 16:41:30 -0700 Message-ID: To: Martin Jansa Cc: Yocto Project , Patches and discussions about the oe-core layer , openembedded-devel Subject: Re: [RFT] GCC 8.1 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 23:41:30 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, May 10, 2018 at 4:32 PM, Martin Jansa wrote: > On Thu, May 10, 2018 at 04:11:00PM -0700, Andre McCurdy wrote: >> On Thu, May 10, 2018 at 3:50 PM, Martin Jansa wrote: >> > On Thu, May 10, 2018 at 03:40:53PM -0700, Andre McCurdy wrote: >> >> On Thu, May 10, 2018 at 3:38 PM, Martin Jansa wrote: >> >> > see >> >> > http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150654.html >> >> >> >> Removing -fno-omit-frame-pointer isn't the same as adding >> >> -fomit-frame-pointer. Frame pointers may get enabled depending on the >> >> optimisation level etc (ie not only by -fno-omit-frame-pointer). >> > >> > Should I send v2 adding -fomit-frame-pointer instead of removing >> > -fno-omit-frame-pointer? >> > >> > The v1 fixes the issue for me with default config + DEBUG_BUILD. >> >> The v1 patch isn't wrong, it's just incomplete (the problem could come >> back if someone changes optimisation level or switches gcc to clang, >> etc). >> >> My choice would be a v2 patch which adds -fomit-frame-pointer to >> CFLAGS unconditionally for all ARM builds when Thumb is enabled. That >> should fix the problem for all optimisation levels etc and avoids >> building the main strace binary differently depending on whether or >> not ptest is enabled. > > Only for thumb? makes me a bit sad that thumb override was dropped by > you in > 351443d71eb246a946b41f12b54d57b36fe1574e No need for a thumb over-ride. You can copy and paste from the musl recipe: CFLAGS_append_arm = " ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-pointer', '', d)}"