From: Magnus Karlsson <magnus.karlsson@gmail.com>
To: Dan Siemon <dan@coverfire.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Alexei Starovoitov" <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Ciara Loftus" <ciara.loftus@intel.com>
Subject: Re: [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link
Date: Wed, 17 Feb 2021 08:36:14 +0100 [thread overview]
Message-ID: <CAJ8uoz0WAM8oSag5b4uuLgUdQHNVdHjm0EmUtXyQ6XW0RFgKFA@mail.gmail.com> (raw)
In-Reply-To: <CAJ8uoz0QqR97qEYYK=VVCE9A=V=k2tKnH6wNM48jeak2RAmL0A@mail.gmail.com>
On Wed, Feb 17, 2021 at 8:16 AM Magnus Karlsson
<magnus.karlsson@gmail.com> wrote:
>
> On Wed, Feb 17, 2021 at 3:26 AM Dan Siemon <dan@coverfire.com> wrote:
> >
> > On Mon, 2021-02-15 at 22:38 +0100, Toke Høiland-Jørgensen wrote:
> > > The idea is to keep libbpf focused on bpf, and move the AF_XDP stuff
> > > to
> > > libxdp (so the socket stuff in xsk.h). We're adding the existing code
> > > wholesale, and keeping API compatibility during the move, so all
> > > that's
> > > needed is adding -lxdp when compiling. And obviously the existing
> > > libbpf
> > > code isn't going anywhere until such a time as there's a general
> > > backwards compatibility-breaking deprecation in libbpf (which I
> > > believe
> > > Andrii is planning to do in an upcoming and as-of-yet unannounced
> > > v1.0
> > > release).
> >
> > I maintain a Rust binding to the AF_XDP parts of libbpf [1][2]. On the
> > chance that more significant changes can be entertained in the switch
> > to libxdp... The fact that many required functions like the ring access
> > functions exist only in xsk.h makes building a binding more difficult
> > because we need to wrap it with an extra C function [3]. From that
> > perspective, it would be great if those could move to xsk.c.
>
> The only reason they were put in xsk.h is performance. But with LTO
> (link-time optimizations) being present in most C-compilers these
> days, it might not be a valid argument anymore. I will perform some
> experiments and let you know. As you say, it would be much nicer to
> hide away these functions in the library proper and make your life
> easier.
I would be very grateful for any more suggested changes that users out
there would like to see. Now, when we move to libxdp is the perfect
chance to fix those things. We might even decide to partially break
compatibility or change some behavior if the gain is large enough.
> > [1] - https://github.com/aterlo/afxdp-rs
> > [2] - https://github.com/alexforster/libbpf-sys
> > [3] - https://github.com/alexforster/libbpf-sys/blob/master/bindings.c
> >
next prev parent reply other threads:[~2021-02-17 7:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:46 [PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk Maciej Fijalkowski
2021-02-15 15:46 ` [PATCH bpf-next 1/3] libbpf: xsk: use bpf_link Maciej Fijalkowski
2021-02-15 17:07 ` Toke Høiland-Jørgensen
2021-02-15 17:38 ` Björn Töpel
2021-02-15 19:35 ` Toke Høiland-Jørgensen
2021-02-16 2:01 ` Maciej Fijalkowski
2021-02-16 9:15 ` Björn Töpel
2021-02-16 10:27 ` Toke Høiland-Jørgensen
2021-02-16 20:15 ` Maciej Fijalkowski
2021-02-15 20:22 ` John Fastabend
2021-02-15 21:38 ` Toke Høiland-Jørgensen
2021-02-16 0:18 ` John Fastabend
2021-02-16 2:23 ` Maciej Fijalkowski
2021-02-16 9:23 ` Björn Töpel
2021-02-16 10:36 ` Toke Høiland-Jørgensen
2021-02-23 1:15 ` Andrii Nakryiko
2021-02-17 2:23 ` Dan Siemon
2021-02-17 7:16 ` Magnus Karlsson
2021-02-17 7:36 ` Magnus Karlsson [this message]
2021-02-16 2:10 ` Maciej Fijalkowski
2021-02-15 20:49 ` John Fastabend
2021-02-16 2:38 ` Maciej Fijalkowski
2021-02-16 18:19 ` John Fastabend
2021-02-16 20:10 ` Maciej Fijalkowski
2021-02-16 9:20 ` Björn Töpel
2021-02-16 10:39 ` Toke Høiland-Jørgensen
2021-02-16 19:15 ` John Fastabend
2021-02-16 20:50 ` Maciej Fijalkowski
2021-02-16 21:17 ` John Fastabend
2021-02-15 15:46 ` [PATCH bpf-next 2/3] libbpf: clear map_info before each bpf_obj_get_info_by_fd Maciej Fijalkowski
2021-02-15 20:33 ` John Fastabend
2021-02-16 2:42 ` Maciej Fijalkowski
2021-02-15 15:46 ` [PATCH bpf-next 3/3] samples: bpf: do not unload prog within xdpsock Maciej Fijalkowski
2021-02-15 20:24 ` John Fastabend
2021-02-16 9:22 ` Björn Töpel
2021-02-16 14:15 ` Maciej Fijalkowski
2021-02-15 16:07 ` [PATCH bpf-next 0/3] Introduce bpf_link in libbpf's xsk Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ8uoz0WAM8oSag5b4uuLgUdQHNVdHjm0EmUtXyQ6XW0RFgKFA@mail.gmail.com \
--to=magnus.karlsson@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=ciara.loftus@intel.com \
--cc=dan@coverfire.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.