Re: [PATCH] xsk: align xdp socket batch size with dpdk

[Magnus Karlsson <magnus.karlsson@gmail.com>]

On Wed, Apr 14, 2021 at 2:39 PM Li RongQing <lirongqing@baidu.com> wrote:
>
> DPDK default burst size is 32, however, kernel xsk sendto
> syscall can not handle all 32 at one time, and return with
> error.
>
> So make kernel xdp socket batch size larger to avoid
> unnecessary syscall fail and context switch which will help
> increase performance.

My apologies for the delay RongQing. I forgot to ack this for some
reason. Your suggestion makes sense and will improve performance in
other cases too. Thank you.

Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>

> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>  net/xdp/xsk.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index a71ed66..cd62d4b 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -30,7 +30,7 @@
>  #include "xdp_umem.h"
>  #include "xsk.h"
>
> -#define TX_BATCH_SIZE 16
> +#define TX_BATCH_SIZE 32
>
>  static DEFINE_PER_CPU(struct list_head, xskmap_flush_list);
>
> --
> 1.7.1
>