From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66547C433EF for ; Sun, 5 Sep 2021 21:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5020860F5E for ; Sun, 5 Sep 2021 21:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238349AbhIEV0K (ORCPT ); Sun, 5 Sep 2021 17:26:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238316AbhIEVZz (ORCPT ); Sun, 5 Sep 2021 17:25:55 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88577C0613CF for ; Sun, 5 Sep 2021 14:24:51 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id b10so6863134wru.0 for ; Sun, 05 Sep 2021 14:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F1e0hbv3ZsiJNNAHKyqEnrPS9MqX6cUig82FuR1+yU4=; b=wVGZAh4ytWMN/R/wB6lATwcSZgUDP8NwEYQyuIHXnQXXF4mGYHBthshCs0RCobdwtF i0bPxTtRbONrs85UFIYny393EZRpCEDxNspp3Ic7TcBlRz9xmDJByXi5CpcVL7alE39u NjzZaZ9AMafDLj9U0+XeGIJdjxQ5koq47chWwA9CZBzQPU9po8ik129DrMVqaRco76d7 hGAq95+PCjOyFJDGb5e9BhLdd+S9/ZBUN9AXsxRWb5KkB5kedUs/9QMSCLEmksHe5fPL 2cYx7YBQGmm+Sqz3MItdKjRYJ9LcDN+FKXMP9XUDtDUefIIVNY+UY/UzTToKU2Z/UEHl d+FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F1e0hbv3ZsiJNNAHKyqEnrPS9MqX6cUig82FuR1+yU4=; b=MYrSPokTu6+w7cC6gjlWQ/XpJh/riKwt3OVQd3u7C3bo2kto8S9b6fjO49/mIlw1xR BcHCFJfq7sAFtNOV8mz9V+QrI7bbHj3Hqzrte9ciRtUnU8aFlKm81tfw7vBo70Y4yDua vOLpESmZUrrGwlhmw1SNInUb9fe/GVnMXzzdo+c46AXGfAtbQBvIC/Q4/JdoQz6dK1au tgyldB1QD7m3X3ZnzVX2/AKfJ91VKub/xiglMm+5i6QZW/ZdK9kM9QHsIoUdf2a3F0BA YN8hS4R4WOsvlVYO77H/lubNIpMHSqiobEPr9mYfyYYXrSX000CYn2CvfTnxPn3X+jge OImA== X-Gm-Message-State: AOAM531yC616AVzABF6pwBKWNc9RPIJ23uymE/3rVKzsGmWD8ydY8kiP HbNZFOhm/snXbGsO+6LUxfutS9LWOcmmCLTwgj4gRA== X-Google-Smtp-Source: ABdhPJzZ8iRqYHJstJBoyH7sckuZt82cSSeCX+52p0ngldq9SUEOXAYxUMBGzcCj0RPX02xBkR3mXtNJE06Jo1I1G1k= X-Received: by 2002:adf:e449:: with SMTP id t9mr9880840wrm.135.1630877090158; Sun, 05 Sep 2021 14:24:50 -0700 (PDT) MIME-Version: 1.0 References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-8-james.clark@arm.com> <4da533c0-8da6-00d4-1849-e210e163d326@arm.com> In-Reply-To: From: Mike Leach Date: Sun, 5 Sep 2021 22:24:39 +0100 Message-ID: Subject: Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder To: Arnaldo Carvalho de Melo Cc: Suzuki K Poulose , James Clark , Mathieu Poirier , Leo Yan , Coresight ML , linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Mike Leach On Fri, 3 Sept 2021 at 12:16, Arnaldo Carvalho de Melo wrote: > > Em Fri, Sep 03, 2021 at 10:15:07AM +0100, Suzuki K Poulose escreveu: > > On 06/08/2021 14:41, James Clark wrote: > > > If the magic number indicates ETE instantiate a OCSD_BUILTIN_DCD_ETE > > > decoder instead of OCSD_BUILTIN_DCD_ETMV4I. ETE is the new trace feature > > > for Armv9. > > > > > > Testing performed > > > ================= > > > > > > * Old files with v0 and v1 headers for ETMv4 still open correctly > > > * New files with new magic number open on new versions of perf > > > * New files with new magic number fail to open on old versions of perf > > > * Decoding with the ETE decoder results in the same output as the ETMv4 > > > decoder as long as there are no new ETE packet types > > > > > > Signed-off-by: James Clark > > > > Changes look good to me with my limited knowledge about the decoder > > facing code. > > > > FWIW, > > > > Acked-by: Suzuki K Poulose > > Thanks, collected the Acked-by. > > - Arnaldo -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F495C433F5 for ; Sun, 5 Sep 2021 21:28:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F80060F45 for ; Sun, 5 Sep 2021 21:28:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F80060F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VB3+I/8N/Pyd5ddhm3YCZP2FIkKsJNwMk/V+lIYYP58=; b=NU7sUWFDzxvQIX u9KRNNXCJe9L0qbjaa87azTCgxOGvirCOvBxjpoE34cCao4bQZlpANnoDRy4r+FkZT8cur6YySERr jwx8CU/Ey8+Wp1iehEYCAiWboSPFSitVmWRJsnF6cLzz7rLfjubl4E30F1+KQhtVcBlcO/AJAG8HH AuXKbA7PLwXgqHWLnfAx/YFj3zrghEwYcgIJn0TQ4h31Gm3ZsTkq+kxUAa1AQpvK+Oi5j4mdYVMFH FlG3DqhVe8x91trzGY+yo/wasURhQcB25oR4fmPJ9ZJSiQXu0+YN7OmTuTOuc1OIi8NY8+AEkHYJz rtxJe7Vt8sKJJZUEpKqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMzeg-00GahY-Dg; Sun, 05 Sep 2021 21:26:22 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMzdD-00Ga9J-B5 for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 21:24:52 +0000 Received: by mail-wr1-x429.google.com with SMTP id n5so6774624wro.12 for ; Sun, 05 Sep 2021 14:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F1e0hbv3ZsiJNNAHKyqEnrPS9MqX6cUig82FuR1+yU4=; b=wVGZAh4ytWMN/R/wB6lATwcSZgUDP8NwEYQyuIHXnQXXF4mGYHBthshCs0RCobdwtF i0bPxTtRbONrs85UFIYny393EZRpCEDxNspp3Ic7TcBlRz9xmDJByXi5CpcVL7alE39u NjzZaZ9AMafDLj9U0+XeGIJdjxQ5koq47chWwA9CZBzQPU9po8ik129DrMVqaRco76d7 hGAq95+PCjOyFJDGb5e9BhLdd+S9/ZBUN9AXsxRWb5KkB5kedUs/9QMSCLEmksHe5fPL 2cYx7YBQGmm+Sqz3MItdKjRYJ9LcDN+FKXMP9XUDtDUefIIVNY+UY/UzTToKU2Z/UEHl d+FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F1e0hbv3ZsiJNNAHKyqEnrPS9MqX6cUig82FuR1+yU4=; b=aBiIwDf5J2K5usxWlAvTlaSQbliYwgcKSCJGOoTH0UaEgGDFV+CGpvXocNJxblsFif fQwb76gwo2NKO+1isIm3aW7IVMLDjqBZJTeapw48vS0dprSqSHXm2AzvktLgYJ8TT7pJ dcJrkKd+xZph43mnz5Pf1mNX6bx0qG7q3Gx384R8wzjyRBh65smPhZp/dj65K7J49PcJ yg/0dP6T9qy1Wva90uzFKRisvtzx3zDFCjjFiYoNX5FwLKCz4X/a14lg+1ZQlLDrvwnd dDAMsZU/Ua//P7bvMLzNq9SV5BsvC1z81cSKtoMha2DRDWeAsFv5Rcwts/m4pLwIz9a4 k5WA== X-Gm-Message-State: AOAM532PN3nwvl+ICbWxPuo3fqEKSs6jbCIMbHnnqExqm4lbpt2x0DGy teArhmsDx7hAfB5kvXpjQI2Lg/eIxuDOa/655GX1+w== X-Google-Smtp-Source: ABdhPJzZ8iRqYHJstJBoyH7sckuZt82cSSeCX+52p0ngldq9SUEOXAYxUMBGzcCj0RPX02xBkR3mXtNJE06Jo1I1G1k= X-Received: by 2002:adf:e449:: with SMTP id t9mr9880840wrm.135.1630877090158; Sun, 05 Sep 2021 14:24:50 -0700 (PDT) MIME-Version: 1.0 References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-8-james.clark@arm.com> <4da533c0-8da6-00d4-1849-e210e163d326@arm.com> In-Reply-To: From: Mike Leach Date: Sun, 5 Sep 2021 22:24:39 +0100 Message-ID: Subject: Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder To: Arnaldo Carvalho de Melo Cc: Suzuki K Poulose , James Clark , Mathieu Poirier , Leo Yan , Coresight ML , linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210905_142451_422742_595046FA X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Reviewed-by: Mike Leach On Fri, 3 Sept 2021 at 12:16, Arnaldo Carvalho de Melo wrote: > > Em Fri, Sep 03, 2021 at 10:15:07AM +0100, Suzuki K Poulose escreveu: > > On 06/08/2021 14:41, James Clark wrote: > > > If the magic number indicates ETE instantiate a OCSD_BUILTIN_DCD_ETE > > > decoder instead of OCSD_BUILTIN_DCD_ETMV4I. ETE is the new trace feature > > > for Armv9. > > > > > > Testing performed > > > ================= > > > > > > * Old files with v0 and v1 headers for ETMv4 still open correctly > > > * New files with new magic number open on new versions of perf > > > * New files with new magic number fail to open on old versions of perf > > > * Decoding with the ETE decoder results in the same output as the ETMv4 > > > decoder as long as there are no new ETE packet types > > > > > > Signed-off-by: James Clark > > > > Changes look good to me with my limited knowledge about the decoder > > facing code. > > > > FWIW, > > > > Acked-by: Suzuki K Poulose > > Thanks, collected the Acked-by. > > - Arnaldo -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel