From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93477C433E0 for ; Mon, 3 Aug 2020 17:13:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F20A20A8B for ; Mon, 3 Aug 2020 17:13:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tAD6Cgrz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QnEsUVY6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F20A20A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+SCW8QVkwS0OMUU/VQe6UzaX9KrgCbTd2+9fZtUKxEk=; b=tAD6CgrzFfPkgIcDvsw63B5fR 3QyPE58idusz5MJ2ubhoQDe9fmoRtANKHwQMfx1jjiRW5xuH2Rnf4ADJBRgnaKhMlxyIHyLY97BLZ sWC3ssN+E+KylidgX6KtkVoA8tCP27f9iLo3bKYAKCVqudQMhJupfxtU4y3wUu1X+p3e42Q3iXz3L a20qYpL0P+1aSXGxhVjJ7uXD0PK+vsIaXY5e/4KRUraU6mfR55kDXnbmvjreIPRftg2ZRR/f7oBS+ 23ChSPnaIaLY/M3TuQNSqgxZurFHK7DgH7sZ5eC5Qq9UFmbUb4jFw4UMMnEI82SPD/KEYESX7aZsR FhpyX3siA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2dzq-0005Yl-Sp; Mon, 03 Aug 2020 17:11:34 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2dzm-0005Wt-Q4 for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 17:11:32 +0000 Received: by mail-ed1-x544.google.com with SMTP id o18so13359006eds.10 for ; Mon, 03 Aug 2020 10:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Og6LQyqEJXa0K7EHCJ8mxkCCb3UfL2ZsGkbj416PR3U=; b=QnEsUVY6jCStyY0obFvGhrVUirrKj0L9OFZ2snYm6dAm7Z/uYaJwH5CiILpSFa4IJ2 UYvSLybDzsJff5coj8lZZn37GoV801jGXfPxr1LZfYZC9oeBHbeXwaHta36GpeOwlD+E xr1UO4jiNhlcXNeG2yMAgYxrc/go15rrehqG6SEAmrxdNpYmjUVPytDgkgghIX+T4tqo P+dgUAIGFszzBOXtmtXzb5TYY0iRfsjmLneYZY54ST+4GP0n4oigVsi/P6GTjxW/q2bZ IqKLZGUioCuqpVpvq+gvRZKg7jcOdk4CPzfl8EbY7f59AooJKB5QL2pY0PqTpsRtTWyJ ToYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Og6LQyqEJXa0K7EHCJ8mxkCCb3UfL2ZsGkbj416PR3U=; b=HNXADbGxVJS5jAo5plha+O7nT/l3wsfThdjJ4/yMrzQec1wXnq8ydelllVhx0o/2xL y7BGTG61cF5dCj7be20PHS37S/NM80vLHepJJjNkXjGyKLdqDK3Rjn6G8T9Gnp4jrlXX +Zy3uw1/i6w6hM7bJeTE9gKa4UoKMI156dYOMpKSAmNU8kApyBCYE3ExmsL/Fe+HuK7c VH6abHVc10n7EqXevkPKPCBzB1HJyBkB96liv4neEk5pkBNBeabBb3TxL4YNgulmgRrx cRvhK5+XC9MyqYwJteDymMmeeK0ILhpuDvJ5QTweio2rM/8IaA+XEnUZoRhTw1C+mC9a GtQw== X-Gm-Message-State: AOAM5337fSSKHR0ruDEhQCG90Qh7KUlLe5gHCyX2bNIl9GVZx0Y9GKmd u2IHggt9GGMmbRxUYALYQYpRmEaLITAFHAWRiWpO5Q== X-Google-Smtp-Source: ABdhPJwvnYZTBSNUsChmfFbm3B9nDSlGNHMtVGqz6Xrc2pf1IuvaTmO9Q1JAwNAltvGPNM/wvcRLebkbBL5VMQzJmOI= X-Received: by 2002:a50:f10c:: with SMTP id w12mr16849142edl.202.1596474689809; Mon, 03 Aug 2020 10:11:29 -0700 (PDT) MIME-Version: 1.0 References: <20200731064012.8076-1-tingwei@codeaurora.org> <20200731064012.8076-13-tingwei@codeaurora.org> In-Reply-To: <20200731064012.8076-13-tingwei@codeaurora.org> From: Mike Leach Date: Mon, 3 Aug 2020 18:11:18 +0100 Message-ID: Subject: Re: [PATCH v6 12/25] coresight: tpiu: allow tpiu to be built as a module To: Tingwei Zhang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_131130_921745_BB8D6A3B X-CRM114-Status: GOOD ( 26.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Randy Dunlap , Mian Yousaf Kaukab , Russell King , Mao Jinlong , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 31 Jul 2020 at 07:41, Tingwei Zhang wrote: > > From: Kim Phillips > > Allow to build coresight-tpiu as a module, for ease of development. > > - Kconfig becomes a tristate, to allow =m > - add a tpiu_remove function, for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > --- > drivers/hwtracing/coresight/Kconfig | 5 ++++- > drivers/hwtracing/coresight/coresight-tpiu.c | 19 ++++++++++++++++++- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index 996d84a1edb8..8fd9887fb03b 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -46,7 +46,7 @@ config CORESIGHT_CATU > mode where the address is not translated. > > config CORESIGHT_SINK_TPIU > - bool "Coresight generic TPIU driver" > + tristate "Coresight generic TPIU driver" > depends on CORESIGHT_LINKS_AND_SINKS > help > This enables support for the Trace Port Interface Unit driver, > @@ -56,6 +56,9 @@ config CORESIGHT_SINK_TPIU > connected to an external host for use case capturing more traces than > the on-board coresight memory can handle. > > + To compile this driver as a module, choose M here: the > + module will be called coresight-tpiu. > + > config CORESIGHT_SINK_ETBV10 > tristate "Coresight ETBv1.0 driver" > depends on CORESIGHT_LINKS_AND_SINKS > diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c > index f8583e4032a6..e4ddd9801535 100644 > --- a/drivers/hwtracing/coresight/coresight-tpiu.c > +++ b/drivers/hwtracing/coresight/coresight-tpiu.c > @@ -173,6 +173,15 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id) > return PTR_ERR(drvdata->csdev); > } > > +static int __exit tpiu_remove(struct amba_device *adev) > +{ > + struct tpiu_drvdata *drvdata = dev_get_drvdata(&adev->dev); > + > + coresight_unregister(drvdata->csdev); > + > + return 0; > +} > + > #ifdef CONFIG_PM > static int tpiu_runtime_suspend(struct device *dev) > { > @@ -216,6 +225,8 @@ static const struct amba_id tpiu_ids[] = { > { 0, 0}, > }; > > +MODULE_DEVICE_TABLE(amba, tpiu_ids); > + > static struct amba_driver tpiu_driver = { > .drv = { > .name = "coresight-tpiu", > @@ -224,6 +235,12 @@ static struct amba_driver tpiu_driver = { > .suppress_bind_attrs = true, > }, > .probe = tpiu_probe, > + .remove = tpiu_remove, > .id_table = tpiu_ids, > }; > -builtin_amba_driver(tpiu_driver); > +module_amba_driver(tpiu_driver); > + > +MODULE_AUTHOR("Pratik Patel "); > +MODULE_AUTHOR("Mathieu Poirier "); > +MODULE_DESCRIPTION("Arm CoreSight TPIU (Trace Port Interface Unit) driver"); > +MODULE_LICENSE("GPL v2"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > Reviewed by: Mike Leach -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel