From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C78AC433DF for ; Mon, 3 Aug 2020 17:14:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 090E120A8B for ; Mon, 3 Aug 2020 17:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Goo5dBAQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OShFlbfO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 090E120A8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=t02YVGLex8GsIkehA1o+UcXWo6zYOgCtXFcYNy0WDwY=; b=Goo5dBAQEfV8bglwApCSqSjKn M3jfkEF8SBGIKzUjLArVYwkI6ok6y+Pu6awBUBaR9mwUHrjQTFE+i54gEYc9eYF16Nb9fuOtO6z5T OBX3UH0ajT5viMYcJdONO8xUkWfoPmYhABttRDDU03G1Yv8si/PdQsaZxyOtGddMMv6Q8f5ilfke0 FuZTHzdN6CllHQrJ7I5PbZWt8btf3H3auRm/dggH7e0UjyUBpWl32PFCM4TnYKnWEXAd9kPbsSqL8 96F4I6NWOIl4JUujBCfbMeis9TP3lmJSoJYqgAvCMpOmt4dCelAOJqsMhE7DEnS1L/gdBn0T3cV3g EsbgE5esA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2e0A-0005jf-9D; Mon, 03 Aug 2020 17:11:54 +0000 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2e00-0005ea-QH for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2020 17:11:46 +0000 Received: by mail-ej1-x641.google.com with SMTP id l4so39351484ejd.13 for ; Mon, 03 Aug 2020 10:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nLkgwYojomdAmZsl1KC/rnE/sTgSzGdZQJa4oLczvbI=; b=OShFlbfOqVrOQCssZzBjekvSHP0Wp8py68cYvyxG6zMlLiDKWD/tJ158r7ix1tarDD OEgW6tYf7R0mCKkQMYwgr2ZWzQkPCZ/BiI325oikFZp/zTD8b7q5PO2LHyHvyozNx7Qt iaN6gXJKmNvSoEMA6s+db1WYiJK9yjJAcMqhN3YhQrd7A+dT4gVPDzB1YQ8FaG0bqK/P ccZtSB5NW+Z2f6J7sPw+JXwgMTBUTlGwiOHtK0YiYwVG/733DmygNXqOwyrUt0CEhLbT CIDDwXq2qCU9J+Bw6ljZGYvGhDpr48GjA0Q6kKRefLG+WRvN6Hjp+fx7a1YJBOA/b2sk 1foQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nLkgwYojomdAmZsl1KC/rnE/sTgSzGdZQJa4oLczvbI=; b=jHry0RC2zptCeKveCoArdZLZJZk5/ptW4NOvuzuvEX8QCO2HKYdx1b4IdBMcoSDMIZ je2Yv7HP0VLoOygUEXXY6esi2LOH/HH9Vuw/lIN7TqNxd4PEdvj7f0qWHeF2a03dG3zQ +dXaqGBrAn01iiZCxZ3xZ6+90uksJabw8uobUfbt2TbKCL6Ioc/vu7Y/Rbw4yVu1A5uc IhWeG4nRVmlGYsLjNU4JQ0ISI56um3jtdGVORrWbJpbhNj5SH8Ozg+exgkEVFrKFo0FK zY8wg/43mQ205+y8HFi+cJ81SkA2LsX2dt1UtF8t4hDVn3YlhvcrKp5Qa+AYyvcwd9r6 2LQA== X-Gm-Message-State: AOAM5334X0SogECNXRDsIvUgZbE/4SX/WPDiOW6bBkJzMb8+jB33GZ9x 7+AnGAI/TGH4jUrM+iPoyPJQfm+EURotrdLz9tBWNQ== X-Google-Smtp-Source: ABdhPJz4/SaFp0Sw0rtQ0LnL1mdCDMAMrjf7Pu7OagQLZF8hsL42iyvxI7xEjUby2tIIxdO8V2cE1s7/8PEsopB8IR4= X-Received: by 2002:a17:907:20f5:: with SMTP id rh21mr17252671ejb.194.1596474703925; Mon, 03 Aug 2020 10:11:43 -0700 (PDT) MIME-Version: 1.0 References: <20200731064012.8076-1-tingwei@codeaurora.org> <20200731064012.8076-15-tingwei@codeaurora.org> In-Reply-To: <20200731064012.8076-15-tingwei@codeaurora.org> From: Mike Leach Date: Mon, 3 Aug 2020 18:11:32 +0100 Message-ID: Subject: Re: [PATCH v6 14/25] coresight: funnel: remove multiple init calls from funnel driver To: Tingwei Zhang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_131144_938048_6D64B6A8 X-CRM114-Status: GOOD ( 21.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , Coresight ML , Randy Dunlap , Mian Yousaf Kaukab , Russell King , Mao Jinlong , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 31 Jul 2020 at 07:41, Tingwei Zhang wrote: > > From: Mian Yousaf Kaukab > > Dynamic-funnel uses module_amba_driver to register. Whereas > static-funnel uses builtin_platform_driver. Combine these init calls > into a single module_init/exit pair in preparation to make the driver > modular. > > Signed-off-by: Mian Yousaf Kaukab > Signed-off-by: Tingwei Zhang > --- > .../hwtracing/coresight/coresight-funnel.c | 30 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c > index 900690a9f7f0..46b277ed8606 100644 > --- a/drivers/hwtracing/coresight/coresight-funnel.c > +++ b/drivers/hwtracing/coresight/coresight-funnel.c > @@ -341,7 +341,6 @@ static struct platform_driver static_funnel_driver = { > .suppress_bind_attrs = true, > }, > }; > -builtin_platform_driver(static_funnel_driver); > > static int dynamic_funnel_probe(struct amba_device *adev, > const struct amba_id *id) > @@ -372,4 +371,31 @@ static struct amba_driver dynamic_funnel_driver = { > .probe = dynamic_funnel_probe, > .id_table = dynamic_funnel_ids, > }; > -builtin_amba_driver(dynamic_funnel_driver); > + > +static int __init funnel_init(void) > +{ > + int ret; > + > + ret = platform_driver_register(&static_funnel_driver); > + if (ret) { > + pr_info("Error registering platform driver\n"); > + return ret; > + } > + > + ret = amba_driver_register(&dynamic_funnel_driver); > + if (ret) { > + pr_info("Error registering amba driver\n"); > + platform_driver_unregister(&static_funnel_driver); > + } > + > + return ret; > +} > + > +static void __exit funnel_exit(void) > +{ > + platform_driver_unregister(&static_funnel_driver); > + amba_driver_unregister(&dynamic_funnel_driver); > +} > + > +module_init(funnel_init); > +module_exit(funnel_exit); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > Tested by: Mike Leach -- Mike Leach Principal Engineer, ARM Ltd. Manchester Design Centre. UK _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel