From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Hung Subject: Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86 Date: Thu, 16 Feb 2017 19:38:28 +0800 Message-ID: References: <20170116132204.6421-1-kernel@kempniu.pl> <20170213112640.GA1188@ozzy.nask.waw.pl> <20170215135455.GA2014@ozzy.nask.waw.pl> <20170216092747.GA1350@ozzy.nask.waw.pl> <20170216113258.GD1350@ozzy.nask.waw.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-qk0-f177.google.com ([209.85.220.177]:35684 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753514AbdBPLia (ORCPT ); Thu, 16 Feb 2017 06:38:30 -0500 Received: by mail-qk0-f177.google.com with SMTP id u25so12531767qki.2 for ; Thu, 16 Feb 2017 03:38:30 -0800 (PST) In-Reply-To: <20170216113258.GD1350@ozzy.nask.waw.pl> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Jacek Anaszewski , Pavel Machek , Jaroslav Kysela , Takashi Iwai , Anthony Wong , Richard Purdie , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Darren Hart , Andy Shevchenko , Linux LED Subsystem , "platform-driver-x86@vger.kernel.org" , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 7:32 PM, Micha=C5=82 K=C4=99pie=C5=84 wrote: >> The led stops working after 4th patch "platform/x86: dell-laptop: >> import dell_micmute_led_set() from drivers/leds/dell-led.c", and the >> .config is with CONFIG_DELL_LAPTOP=3Dm >> >> However, I found dell-laptop is not loaded on Latitude 7480 as its >> chassis type is Notebook (10), instead of 8 (Portable) or 9 (Laptop). >> That's also what I see for newer Dell laptops. >> >> After I added the below entry into dell-laptop, the led works fine. >> This is not in kernel 4.10 rc8 either, and I will submit a patch for >> it. >> >> { >> .matches =3D { >> DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> DMI_MATCH(DMI_CHASSIS_TYPE, "10"), /*Notebook*/ >> }, >> }, > > Great, so it all makes sense now. Thanks once again for investigating. > > For maintainers' convenience, I am planning to submit a v3 with all the > tags supplied by everyone who reviewed this series and also some minor > coding style tweaks suggested along the way. > > Alex, in the light of your findings quoted above, would it be okay to > also apply your Tested-by to all patches? Certainly. Tested-by: Alex Hung > > Jacek, Pavel, which linux-leds branch would you like me to base v3 on? > > -- > Best regards, > Micha=C5=82 K=C4=99pie=C5=84 --=20 Cheers, Alex Hung