All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mirza Krak <mirza.krak@hostmobility.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes
Date: Tue, 21 Jul 2015 11:41:21 +0200	[thread overview]
Message-ID: <CAJ=nTssgoKHnFOMGM211mY=7CNXBnF=TxOps66cozCsfSedFcA@mail.gmail.com> (raw)
In-Reply-To: <20150721090246.GC20388@ulmo.nvidia.com>

2015-07-21 11:02 GMT+02:00 Thierry Reding <treding@nvidia.com>:
>
> On Mon, Jul 20, 2015 at 01:41:00PM +0200, Mirza Krak wrote:
> > From: Mirza Krak <mirza.krak@hostmobility.com>
> >
> > Add the device tree node for the SPI controllers found on Tegra20 SOCs.
> >
> > Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
> >
> > ---
> >  arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >
> > diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> > index b8c8a923017e..82168c9012e3 100644
> > --- a/arch/arm/dts/tegra20.dtsi
> > +++ b/arch/arm/dts/tegra20.dtsi
> > @@ -268,6 +268,50 @@
> >               #pwm-cells = <2>;
> >       };
> >
> > +     spi at 7000d400 {
> > +             compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
>
> This can't be correct on Tegra20 since Tegra30 didn't exist at the time.
> You'll need to drop the first string in the list for this to be correct.

Sent v2 of patch dropping tegra30 compatible string.

>
> Also, might be worth copying these from the Linux kernel's copy of the
> device tree files, since they are slightly different. That might involve
> pulling in a couple of headers too, though, so might not be worth it.
>
> Thierry

Pulling from Linux kernel's copy of these files is not something I am
up for at the moment.

-- 
Med V?nliga H?lsningar / Best Regards

*******************************************************************
Mirza Krak
Host Mobility AB
mirza.krak at hostmobility.com
Anders Personsgatan 12, 416 64 G?teborg
Sweden
http://www.hostmobility.com
Direct: +46 31 31 32 704
Phone: +46 31 31 32 700
Fax: +46 31 80 67 51
Mobile: +46 730 28 06 22
*******************************************************************

      reply	other threads:[~2015-07-21  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 11:41 [U-Boot] [PATCH 1/1] ARM: tegra: Add Tegra20 SPI device nodes Mirza Krak
2015-07-20 13:13 ` Simon Glass
2015-07-21  9:02 ` Thierry Reding
2015-07-21  9:41   ` Mirza Krak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ=nTssgoKHnFOMGM211mY=7CNXBnF=TxOps66cozCsfSedFcA@mail.gmail.com' \
    --to=mirza.krak@hostmobility.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.