From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754370AbdLFCfP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 21:35:15 -0500
Received: from mail-wm0-f45.google.com ([74.125.82.45]:38257 "EHLO
        mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753348AbdLFCfO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 21:35:14 -0500
X-Google-Smtp-Source: AGs4zMZdqiuI34poMm5CbFs5MmSUxKJUd54hBj//YbObkJ8c2dTUbDP9AJ4IuUo616YZvAUq1SIO1Nq0Xt12udzYlxU=
MIME-Version: 1.0
In-Reply-To: <20171130005828.GA15628@vader>
References: <20171130005828.GA15628@vader>
From: Fubo Chen <fubo.chen@gmail.com>
Date: Tue, 5 Dec 2017 18:35:12 -0800
Message-ID: <CAJAFBLB1n68o_2mXJuWeQfb1fa3rP4XkZKS=v7Fj-1p9j5O7xA@mail.gmail.com>
Subject: Re: add_wait_queue() (unintentional?) behavior change in v4.13
To: Omar Sandoval <osandov@osandov.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 29, 2017 at 4:58 PM, Omar Sandoval <osandov@osandov.com> wrote:
> diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c
> index 98feab7933c7..929ecb7d6b78 100644
> --- a/kernel/sched/wait.c
> +++ b/kernel/sched/wait.c
> @@ -27,7 +27,7 @@ void add_wait_queue(struct wait_queue_head *wq_head, struct wait_queue_entry *wq
>
>         wq_entry->flags &= ~WQ_FLAG_EXCLUSIVE;
>         spin_lock_irqsave(&wq_head->lock, flags);
> -       __add_wait_queue_entry_tail(wq_head, wq_entry);
> +       __add_wait_queue(wq_head, wq_entry);
>         spin_unlock_irqrestore(&wq_head->lock, flags);
>  }
>  EXPORT_SYMBOL(add_wait_queue);

Reviewed-by: Fubo Chen <fubo.chen@gmail.com>