From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B48B7ECAAD3 for ; Thu, 1 Sep 2022 14:23:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234638AbiIAOX5 (ORCPT ); Thu, 1 Sep 2022 10:23:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234761AbiIAOXl (ORCPT ); Thu, 1 Sep 2022 10:23:41 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0CDC72FDE for ; Thu, 1 Sep 2022 07:23:15 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 435203F495 for ; Thu, 1 Sep 2022 14:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1662042192; bh=0pValQemCvGX1LEq88UuNr8omRZeEtwxwFj8CYGFUUk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tbxhzmPqBTixnRFsFnJM2I7Y6WYR3dBghMd+YxJPxOuuPjUkLweDKVzolAXPQvJEw X0/BGPLuDBjQuoSj1IEUVH0031lXFoQ9cNrVMSKHIFfuPALRkw2sozNj11PgSuEzZq wEXlCZBkn8BzhZHJjzv2FNMdWHPtnzbkyNvVg7mATDqvGQws8ZEYuyxWNaQ02Z+Yam aYW/HIHUjYleFbGPUmSKHGmW2PFTm70Mcl4V/1z8ZB0GIRoDXjh1cbmz/Zxkj6iLVX chlIZDxQrlZ3FJVnSY/qr0iBishbT2VFljxTyRGPbvDPkg6CECHu2Z6CydnAF5gGfV yd5r7nkLsMnPw== Received: by mail-ed1-f70.google.com with SMTP id p4-20020a056402500400b00447e8b6f62bso11934057eda.17 for ; Thu, 01 Sep 2022 07:23:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=0pValQemCvGX1LEq88UuNr8omRZeEtwxwFj8CYGFUUk=; b=nOCmiX9Y5ym9l/qs+yAuElZzjSTvdKL8CWTUpOFZCdZHg/z5EsWl3xdGGu5n/piKIS BBzeRSnslZxTVil6mu26QxZRdlsR+kJqhDE2A5/Zki6nS/E2y4U4H7ZhT6Yf+hgl8W1H itYCTVQqRAWdEvXrbkU5BWtE1+Q8/0+MUK2txqUx56x0zoaUVv2Np4R6C3PoEkmZQPtp BcANe23JSOoKkUm7stIYb8QyJKJ6PVtaJ+O7RQjqXoN4qxdrn+l2todZrKwUpC6jQAg2 8d+WSk/u0Me1gRb5b8sm2HuaxyN+vhcPyaywT073KgoPSRaMIa4YT8q69Z1s8WvBwr+p SzcQ== X-Gm-Message-State: ACgBeo0qalPHG24kgva3PSHRoRRdaalyssDbhDC0r4Fx2ku81U3Za7Va A5yNIRqsj0kDjiLH4FaUdXVMtV9KE3ZwBiNJvEnCfmZEkG0z+E3SCGoGMBc/bo+sWl0C8aP1cuC iw8oq5adwGoTV57vfKHo1JQQd1pV9+pbpsO7RAB3yKx/ZyJ0xH1djFDBIfA== X-Received: by 2002:a17:907:a40f:b0:730:c4ce:631c with SMTP id sg15-20020a170907a40f00b00730c4ce631cmr22980394ejc.362.1662042191768; Thu, 01 Sep 2022 07:23:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR6dHZiBfcopnPXJIfA5GSHw2vUA5qpfnN2mvP2jawWAAaOlWxzZ7hqBDDEokKvraMfzduYbvBcwVBBAMcsW9dQ= X-Received: by 2002:a17:907:a40f:b0:730:c4ce:631c with SMTP id sg15-20020a170907a40f00b00730c4ce631cmr22980376ejc.362.1662042191485; Thu, 01 Sep 2022 07:23:11 -0700 (PDT) MIME-Version: 1.0 References: <20220901021628.1130985-1-koba.ko@canonical.com> In-Reply-To: From: Koba Ko Date: Thu, 1 Sep 2022 22:23:00 +0800 Message-ID: Subject: Re: [PATCH V2] crypto: ccp - Release dma channels before dmaengine unrgister To: Tom Lendacky Cc: John Allen , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Sep 1, 2022 at 9:57 PM Koba Ko wrote: > > On Thu, Sep 1, 2022 at 9:42 PM Tom Lendacky wrote: > > > > On 8/31/22 21:16, Koba Ko wrote: > > > A warning is shown during shutdown, > > > > > > __dma_async_device_channel_unregister called while 2 clients hold a reference > > > WARNING: CPU: 15 PID: 1 at drivers/dma/dmaengine.c:1110 __dma_async_device_channel_unregister+0xb7/0xc0 > > > > > > Call dma_release_channel for occupied channles before dma_async_device_unregister. > > > > > > Fixes: 4cbe9bc34ed0 ("crypto: ccp - ccp_dmaengine_unregister release dma channels") > > > > I can't find this Fixes: tag. I did find: > > > > 54cce8ecb925 ("crypto: ccp - ccp_dmaengine_unregister release dma channels") > > > > Not sure if Herbert can take care of that or if you'll need a v3. > > Sorry, it should be 54cce8ecb925("crypto: ccp - > ccp_dmaengine_unregister release dma channels") > > > > > With the change to the Fixes: tag > > > > Acked-by: Tom Lendacky Should I add acked-by in V3 by myself? thanks > > > Reported-by: kernel test robot > > > Signed-off-by: Koba Ko > > > --- > > > V2: Fix the unused warning > > > --- > > > drivers/crypto/ccp/ccp-dmaengine.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/crypto/ccp/ccp-dmaengine.c b/drivers/crypto/ccp/ccp-dmaengine.c > > > index 7d4b4ad1db1f3..9f753cb4f5f18 100644 > > > --- a/drivers/crypto/ccp/ccp-dmaengine.c > > > +++ b/drivers/crypto/ccp/ccp-dmaengine.c > > > @@ -641,6 +641,10 @@ static void ccp_dma_release(struct ccp_device *ccp) > > > for (i = 0; i < ccp->cmd_q_count; i++) { > > > chan = ccp->ccp_dma_chan + i; > > > dma_chan = &chan->dma_chan; > > > + > > > + if (dma_chan->client_count) > > > + dma_release_channel(dma_chan); > > > + > > > tasklet_kill(&chan->cleanup_tasklet); > > > list_del_rcu(&dma_chan->device_node); > > > } > > > @@ -766,8 +770,8 @@ void ccp_dmaengine_unregister(struct ccp_device *ccp) > > > if (!dmaengine) > > > return; > > > > > > - dma_async_device_unregister(dma_dev); > > > ccp_dma_release(ccp); > > > + dma_async_device_unregister(dma_dev); > > > > > > kmem_cache_destroy(ccp->dma_desc_cache); > > > kmem_cache_destroy(ccp->dma_cmd_cache);