All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Murphy <lists@colorremedies.com>
To: Martin Steigerwald <martin@lichtvoll.de>
Cc: Chris Murphy <lists@colorremedies.com>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: Scrub: Uncorrectable error due to SSD read error
Date: Fri, 4 Jun 2021 01:26:03 -0600	[thread overview]
Message-ID: <CAJCQCtTkmUs9DUO41Dwf8t9FQ+zKkKoQY=1mFByJgihaRBM-=w@mail.gmail.com> (raw)
In-Reply-To: <4030217.cPEZuEdVPn@shanti>

On Fri, Jun 4, 2021 at 1:07 AM Martin Steigerwald <martin@lichtvoll.de> wrote:
>
> Mount options look like this.
>
> rw,relatime,lazytime,compress=zstd:3,ssd,discard=async,space_cache,subvolid=257,subvol=/home
>
> I am removing "discard=async". I thought this would be safe with modern
> SSDs.

It should be. So now the question is whether it's some kind of defect
with this particular SSD. Or if it affects make/model. And if it's in
the deny list for mainline. And if upstream is aware of any issues
with this model.

> I always used fstrim manually before, because I was aware of SSDs having
> issue with discard, but when BTRFS introduced queued or batched discard
> I thought I give it a try on a modern SSD.

Completely reasonable.



> > So the drive is not handling queued discard properly is what I
> > suspect. It gets confused. Face plants. Libata then does a hard reset
> > to try to get the drive to come back to reality. And then another
> > discard gets issued and the drive wigs out again.
>
> Thank you. Where did you read this from? I find it challenging to interpret
> the error message the kernel ata layer puts out. They are very detailed and
> I think that is good, but I just do not understand most of it.

Oh man lots of emails on linux-raid@ list over the years. And other
people decipher them. I don't understand most of it either.


-- 
Chris Murphy

  reply	other threads:[~2021-06-04  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 19:59 Scrub: Uncorrectable error due to SSD read error Martin Steigerwald
2021-06-04  5:50 ` Chris Murphy
2021-06-04  7:07   ` Martin Steigerwald
2021-06-04  7:26     ` Chris Murphy [this message]
2021-06-04 14:00   ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJCQCtTkmUs9DUO41Dwf8t9FQ+zKkKoQY=1mFByJgihaRBM-=w@mail.gmail.com' \
    --to=lists@colorremedies.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.