From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38C3EC636CB for ; Sun, 18 Jul 2021 21:31:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15F1361108 for ; Sun, 18 Jul 2021 21:31:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233400AbhGRVek (ORCPT ); Sun, 18 Jul 2021 17:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232898AbhGRVej (ORCPT ); Sun, 18 Jul 2021 17:34:39 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46BF9C061764 for ; Sun, 18 Jul 2021 14:31:40 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id a7so14097330iln.6 for ; Sun, 18 Jul 2021 14:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ow7yd/6EUrynMpV9RE7C75DLtK0l6+jas8yJI3xp7nA=; b=M46LF2jPXQUEqMWCQA1GJEDgHnFKPafk0j/m7OJpzIwXIXSeRamjQeBx6AezMOeN0g IEreoVDKuzhzDPvO8dwW4w9RNjfMLFsLHmuM7cdzhQ5e9Y0zknjPlOTeC4VifadUxhHb 7rB5RdkrVyPtsfCKYPbOPa3mdXwk5Rz2f4IqQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ow7yd/6EUrynMpV9RE7C75DLtK0l6+jas8yJI3xp7nA=; b=KX6Qjmf09AvTpW21rpISrqExqnyxX3NC2DYPO0tHikf8H66qdoJoYTmENEUrlKxTAD ylC6WhRpQU88bx0zoyQ0o8hHXt3oUP7z0O1xh2N85b1Q1K43TBX3wXGfwQ09KdzUlKIW aMblTphftqRgq2lf3J7M1e+XAfD81XhH9aHsVZqWl/fKZyRxCTeBB6pAgHmhUrIUH0vv jpq4p/Tw59bDtOo8hie1UBZZKelVj5uu0W9B7m8W9HLMAyw9O06t1EuWggdHboAOJb+R 44K62CfgZm62o5cU4A6iemFymHzNZniU1nPKtWJ42VnzGPC0/8owjygDhTuxNrRFirE8 MBVA== X-Gm-Message-State: AOAM5328cuk63hecLkSfGVS4LB1Adas6TdRZodUF34LCPwPSn72wYp2o /wm2aRGdNK/KgQGVYsJNgmTfintnkttB2IgrTXnelg== X-Google-Smtp-Source: ABdhPJwghGaCyhofCPCUPvO43wl6OmCztC95fJB9QhJBHJw32g7l8URTTePKqAz97E7EEj9n5OiidKZJxOgHf4ayC/4= X-Received: by 2002:a92:2010:: with SMTP id j16mr14254152ile.98.1626643899633; Sun, 18 Jul 2021 14:31:39 -0700 (PDT) MIME-Version: 1.0 References: <20210614141820.2034827-1-chris.lesiak@licor.com> <20210616134335.76715e55@jic23-huawei> <20210718155152.66f791bc@jic23-huawei> In-Reply-To: <20210718155152.66f791bc@jic23-huawei> From: Matt Ranostay Date: Sun, 18 Jul 2021 14:31:28 -0700 Message-ID: Subject: Re: [PATCH v3] iio: humidity: hdc100x: Add margin to the conversion time To: Jonathan Cameron Cc: Chris Lesiak , "open list:IIO SUBSYSTEM AND DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 18, 2021 at 7:49 AM Jonathan Cameron wrote: > > On Wed, 16 Jun 2021 13:43:35 +0100 > Jonathan Cameron wrote: > > > On Mon, 14 Jun 2021 09:18:20 -0500 > > Chris Lesiak wrote: > > > > > The datasheets have the following note for the conversion time > > > specification: "This parameter is specified by design and/or > > > characterization and it is not tested in production." > > > > > > Parts have been seen that require more time to do 14-bit conversions for > > > the relative humidity channel. The result is ENXIO due to the address > > > phase of a transfer not getting an ACK. > > > > > > Delay an additional 1 ms per conversion to allow for additional margin. > > > > > > Fixes: 4839367d99e3 ("iio: humidity: add HDC100x support") > > > Signed-off-by: Chris Lesiak > > > > +CC Matt as this is one of his drivers. > > @Matt. Ping. > > > > > Looks good to me. Looks good to me as well. Acked-by: Matt Ranostay > > > > > --- > > > drivers/iio/humidity/hdc100x.c | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c > > > index 2a957f19048e..9e0fce917ce4 100644 > > > --- a/drivers/iio/humidity/hdc100x.c > > > +++ b/drivers/iio/humidity/hdc100x.c > > > @@ -25,6 +25,8 @@ > > > #include > > > #include > > > > > > +#include > > > + > > > #define HDC100X_REG_TEMP 0x00 > > > #define HDC100X_REG_HUMIDITY 0x01 > > > > > > @@ -166,7 +168,7 @@ static int hdc100x_get_measurement(struct hdc100x_data *data, > > > struct iio_chan_spec const *chan) > > > { > > > struct i2c_client *client = data->client; > > > - int delay = data->adc_int_us[chan->address]; > > > + int delay = data->adc_int_us[chan->address] + 1*USEC_PER_MSEC; > > > int ret; > > > __be16 val; > > > > > > @@ -316,7 +318,7 @@ static irqreturn_t hdc100x_trigger_handler(int irq, void *p) > > > struct iio_dev *indio_dev = pf->indio_dev; > > > struct hdc100x_data *data = iio_priv(indio_dev); > > > struct i2c_client *client = data->client; > > > - int delay = data->adc_int_us[0] + data->adc_int_us[1]; > > > + int delay = data->adc_int_us[0] + data->adc_int_us[1] + 2*USEC_PER_MSEC; > > > int ret; > > > > > > /* dual read starts at temp register */ > > >