From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B97C388F7 for ; Sat, 31 Oct 2020 21:42:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3881C20679 for ; Sat, 31 Oct 2020 21:42:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=konsulko.com header.i=@konsulko.com header.b="psNqDzJw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbgJaVmJ (ORCPT ); Sat, 31 Oct 2020 17:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbgJaVmJ (ORCPT ); Sat, 31 Oct 2020 17:42:09 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D39E7C0617A7 for ; Sat, 31 Oct 2020 14:42:07 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id c11so9617120iln.9 for ; Sat, 31 Oct 2020 14:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6XcWCTkucGDHKx9lOBdII+rsZh1Z/z1JMeKqo0EGjDA=; b=psNqDzJwkmPu4mljj6GsuZbkZZvF55KwWJDbcz7LD7kJj1fxj7Yc3dTNZB3lEwycBc 5w+amFtal2us5YyNsKHEoVMwVxs7DXrmnpDDBA8I0Wk4oIsAadBuxZZHwuQ0R1pe2bi8 uy2t5Oh8jnEjEqpaIKnuEwrGxUo5fHvBQ9bvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6XcWCTkucGDHKx9lOBdII+rsZh1Z/z1JMeKqo0EGjDA=; b=PN/vsgNpW3bZyYOEA0tLVi/55rhCn8xo8G6gxcZgpsxdyBXZ2qxA9TJJ1KIDpiZD+o mIxaVyMvN7r4tNN/LHjloG8yXOVMjvJIZuiwYr0RsAmfFAC/L8MNfXQe7ebA84g5dqU9 4bzeaTzv7UcAxwNQxXDa4+tgGEfbvJnTM4PXBLHv/PnBHIeQFac05qbLzdiP9Aun+yyG dGqmZ2/Z8WtRFkG53lV9oQCjYRhEGM3bGrtDTE9xSIBsoVATJN43KfKhDKimOUa0q7b2 8VCpPN1m7te/GTTj6Mp9OaYM6iUOpYqJUwb2yF/nTpn/vn3qa1dnoLozBMDvDFYpgE8r a+bA== X-Gm-Message-State: AOAM530pRjcRg+EGio9cq+CQpENqNyduGGvE9UoHzRTTSRyhNrA/LS8T 5XicjwKrzqoMzt0eYRroPjou854gBWnGa+L3cBHSTw== X-Google-Smtp-Source: ABdhPJwB2XXIyntOw6zXIfcFKmZABeuP9G8/vvncClWs9KNoGmXhPRCse/nx6MugL9mhYBvPZdRYW060/VThrYmbYIo= X-Received: by 2002:a05:6e02:c:: with SMTP id h12mr6403716ilr.177.1604180527273; Sat, 31 Oct 2020 14:42:07 -0700 (PDT) MIME-Version: 1.0 References: <20201031184854.745828-1-jic23@kernel.org> <20201031184854.745828-10-jic23@kernel.org> In-Reply-To: <20201031184854.745828-10-jic23@kernel.org> From: Matt Ranostay Date: Sat, 31 Oct 2020 14:41:56 -0700 Message-ID: Subject: Re: [PATCH 09/46] dt-bindings:iio:health:maxim,max30100: txt to yaml conversion To: Jonathan Cameron Cc: "open list:IIO SUBSYSTEM AND DRIVERS" , Rob Herring , devicetree@vger.kernel.org, Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 31, 2020 at 11:51 AM Jonathan Cameron wrote: > > From: Jonathan Cameron > > Straight forward conversion. As with other bindings I've dropped > any standrd description, but kept the unusual bits, in thisscase > the maxim,led-current-microamp and it's description. > > Signed-off-by: Jonathan Cameron > --- > .../bindings/iio/health/max30100.txt | 28 ---------- > .../bindings/iio/health/maxim,max30100.yaml | 52 +++++++++++++++++++ > 2 files changed, 52 insertions(+), 28 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/health/max30100.txt b/Documentation/devicetree/bindings/iio/health/max30100.txt > deleted file mode 100644 > index 0054908a6e74..000000000000 > --- a/Documentation/devicetree/bindings/iio/health/max30100.txt > +++ /dev/null > @@ -1,28 +0,0 @@ > -Maxim MAX30100 heart rate and pulse oximeter sensor > - > -* https://datasheets.maximintegrated.com/en/ds/MAX30100.pdf > - > -Required properties: > - - compatible: must be "maxim,max30100" > - - reg: the I2C address of the sensor > - - interrupts: the sole interrupt generated by the device > - > - Refer to interrupt-controller/interrupts.txt for generic > - interrupt client node bindings. > - > -Optional properties: > - - maxim,led-current-microamp: configuration for LED current in microamperes > - while the engine is running. First indexed value is the configuration for > - the RED LED, and second value is for the IR LED. > - > - Refer to the datasheet for the allowed current values. > - > -Example: > - > -max30100@57 { > - compatible = "maxim,max30100"; > - reg = <0x57>; > - maxim,led-current-microamp = <24000 50000>; > - interrupt-parent = <&gpio1>; > - interrupts = <16 2>; > -}; > diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml > new file mode 100644 > index 000000000000..5684f2f61bcc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30100.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/health/maxim,max30100.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim MAX30100 heart rate and pulse oximeter sensor > + > +maintainers: > + - Matt Ranostay Please change to my Konsulko email, but otherwise LGTM Acked-by: Matt Ranostay > + > +properties: > + compatible: > + const: maxim,max30100 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + description: Connected to ADC_RDY pin. > + > + maxim,led-current-microamp: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 > + maxItems: 2 > + description: | > + LED current whilst the engine is running. First indexed value is > + the configuration for the RED LED, and second value is for the IR LED. > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + heart-rate@57 { > + compatible = "maxim,max30100"; > + reg = <0x57>; > + maxim,led-current-microamp = <24000 50000>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 2>; > + }; > + }; > +... > -- > 2.28.0 >