From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97013C433EF for ; Fri, 10 Jun 2022 21:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348721AbiFJVap (ORCPT ); Fri, 10 Jun 2022 17:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346371AbiFJVak (ORCPT ); Fri, 10 Jun 2022 17:30:40 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B0916F35A for ; Fri, 10 Jun 2022 14:30:38 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id u8so119038wrm.13 for ; Fri, 10 Jun 2022 14:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95Jw5s5U+9h+RH3k4GM+5YUCgDK6/y0zF6sj5xk3tV0=; b=I+ONCW4N40xi6OHman8kT5DVagz+dhj6LV2/JU1uBHo+0lmkQbKluqGvs343u50BiS OyvUQ4SPAlJtyZOqfiIWw4B7wLi1gaxgumSP6uftAkDU76vru5Oo+77mrE0i9qhYJ1Dj jQA0YKZTzSfZtqzfixdeJuPJ/r4nZCV6ViCmqpISYzWBLUSyhDBw77FX6rMZFxmlfcNN Lfrl98LpKkvIFHqxznHvSNq8sQyfhl7nVGOQoP75TBvCmjitZYk8Jq7e+KBEHa28eMky OUKnIRVFISHidByYyg5+mBN3C+AoCqeHKMyfjs6CuC5cZoGFs4SZYnlM1X0zRNJc6cx0 bsAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=95Jw5s5U+9h+RH3k4GM+5YUCgDK6/y0zF6sj5xk3tV0=; b=K4nD27bTdrx6Cv50q/ONn4qVQEG5e8D9RYJTo0piTs5HyL/luTDlVrqoQIdwe5WMKF NgQ0TL091ytopg0izv+QpGol76bTZJ8bTpsTYvdlt3jNjlnD+JypvyuxKbB9QprnflQ9 ZYUIX3IQXUl/5ELe5veitjNSHz1YnScBCHveitQtRqtxrta8+RC5TfIACrDkF8PrNY5G FWmsewVX5aVMR8juGCs0ZkzImpTN+aWjajXAPYi2wRE7E2qI55ZRU39oM14jYp0Z29Fi oA4o6KI4EdgnTR4RVRiVmRS06WHvrYXLbVRPlTDX4v6HDcIYtm8l0/S5E6Vhe7sVt4Yl r4mg== X-Gm-Message-State: AOAM530YoYN4jOuNm58zhhiTywawJS2oz9ddtXrp+RiwNnKV+cnIE1b3 ++ATgNG0Mknqth0gmyjEAdSmipWj4rxQ66O0hcyGvA== X-Google-Smtp-Source: ABdhPJxzGybtZ6uQAuitoi6eQ4H1r7WjMlGRVlPssDwL2Qk1WogiF+6kTSmqyCidwoPtKlFgR+vNONC+zuhdPj2u5WM= X-Received: by 2002:adf:fb05:0:b0:20a:e113:8f3f with SMTP id c5-20020adffb05000000b0020ae1138f3fmr45526846wrr.534.1654896636555; Fri, 10 Jun 2022 14:30:36 -0700 (PDT) MIME-Version: 1.0 References: <20220610194435.2268290-7-yosryahmed@google.com> <202206110544.D5cTU0WQ-lkp@intel.com> In-Reply-To: <202206110544.D5cTU0WQ-lkp@intel.com> From: Yosry Ahmed Date: Fri, 10 Jun 2022 14:30:00 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat To: kernel test robot Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Tejun Heo , Zefan Li , Johannes Weiner , Shuah Khan , Michal Hocko , kbuild-all@lists.01.org, Roman Gushchin , David Rientjes , Stanislav Fomichev , Greg Thelen , Shakeel Butt , Linux Kernel Mailing List , Networking , bpf , Cgroups Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2022 at 2:23 PM kernel test robot wrote: > > Hi Yosry, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220611/202206110544.D5cTU0WQ-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b511f071b9eadf38339387b41 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 > git checkout 83f297e2b47dc41b511f071b9eadf38339387b41 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > kernel/cgroup/rstat.c:161:22: warning: no previous prototype for 'bpf_rstat_flush' [-Wmissing-prototypes] > 161 | __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, > | ^~~~~~~~~~~~~~~ > >> kernel/cgroup/rstat.c:509:10: error: 'const struct btf_kfunc_id_set' has no member named 'sleepable_set'; did you mean 'release_set'? > 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > | ^~~~~~~~~~~~~ > | release_set > kernel/cgroup/rstat.c:509:27: warning: excess elements in struct initializer > 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > | ^ > kernel/cgroup/rstat.c:509:27: note: (near initialization for 'bpf_rstat_kfunc_set') > > > vim +509 kernel/cgroup/rstat.c > > 505 > 506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set = { > 507 .owner = THIS_MODULE, > 508 .check_set = &bpf_rstat_check_kfunc_ids, > > 509 .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > 510 }; > 511 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp AFAICT these failures are because the patch series depends on a patch in the mailing list [1] that is not in bpf-next, as explained by the cover letter. [1] https://lore.kernel.org/bpf/20220421140740.459558-5-benjamin.tissoires@redhat.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3530702515143801450==" MIME-Version: 1.0 From: Yosry Ahmed To: kbuild-all@lists.01.org Subject: Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat Date: Fri, 10 Jun 2022 14:30:00 -0700 Message-ID: In-Reply-To: <202206110544.D5cTU0WQ-lkp@intel.com> List-Id: --===============3530702515143801450== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2022 at 2:23 PM kernel test robot wrote: > > Hi Yosry, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rs= tat-cgroup-hierarchical-stats/20220611-034720 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git = master > config: um-i386_defconfig (https://download.01.org/0day-ci/archive/202206= 11/202206110544.D5cTU0WQ-lkp(a)intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=3D1 build): > # https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b5= 11f071b9eadf38339387b41 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hie= rarchical-stats/20220611-034720 > git checkout 83f297e2b47dc41b511f071b9eadf38339387b41 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=3D1 O=3Dbuild_dir ARCH=3Dum SUBARCH=3Di386 SHELL=3D/bin/ba= sh > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > kernel/cgroup/rstat.c:161:22: warning: no previous prototype for 'bpf_= rstat_flush' [-Wmissing-prototypes] > 161 | __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, > | ^~~~~~~~~~~~~~~ > >> kernel/cgroup/rstat.c:509:10: error: 'const struct btf_kfunc_id_set' h= as no member named 'sleepable_set'; did you mean 'release_set'? > 509 | .sleepable_set =3D &bpf_rstat_sleepable_kfunc_ids, > | ^~~~~~~~~~~~~ > | release_set > kernel/cgroup/rstat.c:509:27: warning: excess elements in struct initi= alizer > 509 | .sleepable_set =3D &bpf_rstat_sleepable_kfunc_ids, > | ^ > kernel/cgroup/rstat.c:509:27: note: (near initialization for 'bpf_rsta= t_kfunc_set') > > > vim +509 kernel/cgroup/rstat.c > > 505 > 506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set =3D { > 507 .owner =3D THIS_MODULE, > 508 .check_set =3D &bpf_rstat_check_kfunc_ids, > > 509 .sleepable_set =3D &bpf_rstat_sleepable_kfunc_ids, > 510 }; > 511 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp AFAICT these failures are because the patch series depends on a patch in the mailing list [1] that is not in bpf-next, as explained by the cover letter. [1] https://lore.kernel.org/bpf/20220421140740.459558-5-benjamin.tissoires(= a)redhat.com/ --===============3530702515143801450==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosry Ahmed Subject: Re: [PATCH bpf-next v2 6/8] cgroup: bpf: enable bpf programs to integrate with rstat Date: Fri, 10 Jun 2022 14:30:00 -0700 Message-ID: References: <20220610194435.2268290-7-yosryahmed@google.com> <202206110544.D5cTU0WQ-lkp@intel.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=95Jw5s5U+9h+RH3k4GM+5YUCgDK6/y0zF6sj5xk3tV0=; b=I+ONCW4N40xi6OHman8kT5DVagz+dhj6LV2/JU1uBHo+0lmkQbKluqGvs343u50BiS OyvUQ4SPAlJtyZOqfiIWw4B7wLi1gaxgumSP6uftAkDU76vru5Oo+77mrE0i9qhYJ1Dj jQA0YKZTzSfZtqzfixdeJuPJ/r4nZCV6ViCmqpISYzWBLUSyhDBw77FX6rMZFxmlfcNN Lfrl98LpKkvIFHqxznHvSNq8sQyfhl7nVGOQoP75TBvCmjitZYk8Jq7e+KBEHa28eMky OUKnIRVFISHidByYyg5+mBN3C+AoCqeHKMyfjs6CuC5cZoGFs4SZYnlM1X0zRNJc6cx0 bsAQ== In-Reply-To: <202206110544.D5cTU0WQ-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel test robot Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Tejun Heo , Zefan Li , Johannes Weiner , Shuah Khan , Michal Hocko , kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Roman Gushchin , David Rientjes , Stanislav Fomichev , Greg Thelen , Shakeel Butt , Linux Kernel Mailing List , Ne On Fri, Jun 10, 2022 at 2:23 PM kernel test robot wrote: > > Hi Yosry, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220611/202206110544.D5cTU0WQ-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce (this is a W=1 build): > # https://github.com/intel-lab-lkp/linux/commit/83f297e2b47dc41b511f071b9eadf38339387b41 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220611-034720 > git checkout 83f297e2b47dc41b511f071b9eadf38339387b41 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > kernel/cgroup/rstat.c:161:22: warning: no previous prototype for 'bpf_rstat_flush' [-Wmissing-prototypes] > 161 | __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, > | ^~~~~~~~~~~~~~~ > >> kernel/cgroup/rstat.c:509:10: error: 'const struct btf_kfunc_id_set' has no member named 'sleepable_set'; did you mean 'release_set'? > 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > | ^~~~~~~~~~~~~ > | release_set > kernel/cgroup/rstat.c:509:27: warning: excess elements in struct initializer > 509 | .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > | ^ > kernel/cgroup/rstat.c:509:27: note: (near initialization for 'bpf_rstat_kfunc_set') > > > vim +509 kernel/cgroup/rstat.c > > 505 > 506 static const struct btf_kfunc_id_set bpf_rstat_kfunc_set = { > 507 .owner = THIS_MODULE, > 508 .check_set = &bpf_rstat_check_kfunc_ids, > > 509 .sleepable_set = &bpf_rstat_sleepable_kfunc_ids, > 510 }; > 511 > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp AFAICT these failures are because the patch series depends on a patch in the mailing list [1] that is not in bpf-next, as explained by the cover letter. [1] https://lore.kernel.org/bpf/20220421140740.459558-5-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org/