From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D47C77B73 for ; Sat, 27 May 2023 03:56:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbjE0D4g (ORCPT ); Fri, 26 May 2023 23:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231250AbjE0D4a (ORCPT ); Fri, 26 May 2023 23:56:30 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C9919A for ; Fri, 26 May 2023 20:56:26 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96fa4a6a79bso207409166b.3 for ; Fri, 26 May 2023 20:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685159785; x=1687751785; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zcxx+uBeHJ8GiGdDOZOOVVIqwP9cLUm7L1SVeB9sLvM=; b=xE6160P9Zr4wEkT61Vr5IkbHXpmY1HjWeK774oQn5uOLjZ2QEShy9mhrvVb4HqrxNS Z6YAg0LrJSUZi4tWr0CbVwQP+J5RhaPpDHoV4HUQHCB33J/wh1mvABD2dO+suyipiw9p QCz+GmmD3/0o1Pyp7lX+CznaXnTzdYR0Id4oWQEPZ5F2ga6slqiCNJPehrr+OrqLM2d1 Whe/YslfEdc084vxdVSFYv/Jl+2Z69RrvRZpAXfhZZiPq2ClZnt9quqrkENE6BIROcRp P+9RUjet0hlHRR4Qtj6bY4XtxobK8M7zWElCDxcqPoakr+NiUD5EL3rinGOj0K2M14QT nKRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685159785; x=1687751785; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zcxx+uBeHJ8GiGdDOZOOVVIqwP9cLUm7L1SVeB9sLvM=; b=WuEu1PlEVtprW76RgR/Cjv0HGMRYhrJOcoSxqc8FZZ1TQS4Ax+/uuCdpZPKMjpZCh0 Ixws9/AS6H6FA94/8FQRe8VegwtBIr9F5wEvvnT1rgnQnshSEN/UDIZ5u0hUWfQTJJfs aiVWaG2QvaX1b+zDyoTnQs5k6tAGrKrN7DRDmPGd3wovDNaPbw7m9wbrbJl4MZMPgJJz HPXm5TTrI2KtmuAxZGdG1qJNLg04vwDOVX5NBRMYJRAEkmAiMizOfu21oc+4F22HAdNG Xs34dwud8ioncwDoRZB/vewHlQGLHY7+ZCavBE+qMFPGNL2b7y0d79KgfmZO0gnSGgzs oWAg== X-Gm-Message-State: AC+VfDwcHcaiRxk/XMubH8/gZAs2cRyEBwLQYBq/xGnUnxiDTETSbHqf +x49x34KC36sGMxdaQD2VdarwoRnrJN/IKADgzsZnw== X-Google-Smtp-Source: ACHHUZ6Frq44/ZM1/LAefqKVo+JOcYtTAHNn83kaMix4r51rZzunIi70oDj7h1R4lHYEPc3BxQhVVEKHW1NueeZXB+8= X-Received: by 2002:a17:907:9455:b0:94f:1c90:cb71 with SMTP id dl21-20020a170907945500b0094f1c90cb71mr5112500ejc.65.1685159785332; Fri, 26 May 2023 20:56:25 -0700 (PDT) MIME-Version: 1.0 References: <20230527093353.153078-1-linmiaohe@huawei.com> In-Reply-To: <20230527093353.153078-1-linmiaohe@huawei.com> From: Yosry Ahmed Date: Fri, 26 May 2023 20:55:49 -0700 Message-ID: Subject: Re: [PATCH] cgroup: remove unused macro for_each_e_css() To: Miaohe Lin Cc: lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 26, 2023 at 6:43=E2=80=AFPM Miaohe Lin w= rote: > > for_each_e_css() is unused now. Remove it. > > Signed-off-by: Miaohe Lin LGTM. I can't see any references in Linus's tree or mm-unstable. Reviewed-by: Yosry Ahmed > --- > kernel/cgroup/cgroup.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 625d7483951c..413b4f1f1b70 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css); > lockdep_is_held(&cgroup_mutex)))) { } \ > else > > -/** > - * for_each_e_css - iterate all effective css's of a cgroup > - * @css: the iteration cursor > - * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching= the end > - * @cgrp: the target cgroup to iterate css's of > - * > - * Should be called under cgroup_[tree_]mutex. > - */ > -#define for_each_e_css(css, ssid, cgrp) = \ > - for ((ssid) =3D 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) = \ > - if (!((css) =3D cgroup_e_css_by_mask(cgrp, = \ > - cgroup_subsys[(ssid)])= )) \ > - ; = \ > - else > - > /** > * do_each_subsys_mask - filter for_each_subsys with a bitmask > * @ss: the iteration cursor > -- > 2.27.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yosry Ahmed Subject: Re: [PATCH] cgroup: remove unused macro for_each_e_css() Date: Fri, 26 May 2023 20:55:49 -0700 Message-ID: References: <20230527093353.153078-1-linmiaohe@huawei.com> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685159785; x=1687751785; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zcxx+uBeHJ8GiGdDOZOOVVIqwP9cLUm7L1SVeB9sLvM=; b=xE6160P9Zr4wEkT61Vr5IkbHXpmY1HjWeK774oQn5uOLjZ2QEShy9mhrvVb4HqrxNS Z6YAg0LrJSUZi4tWr0CbVwQP+J5RhaPpDHoV4HUQHCB33J/wh1mvABD2dO+suyipiw9p QCz+GmmD3/0o1Pyp7lX+CznaXnTzdYR0Id4oWQEPZ5F2ga6slqiCNJPehrr+OrqLM2d1 Whe/YslfEdc084vxdVSFYv/Jl+2Z69RrvRZpAXfhZZiPq2ClZnt9quqrkENE6BIROcRp P+9RUjet0hlHRR4Qtj6bY4XtxobK8M7zWElCDxcqPoakr+NiUD5EL3rinGOj0K2M14QT nKRg== In-Reply-To: <20230527093353.153078-1-linmiaohe-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="windows-1252" To: Miaohe Lin Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Fri, May 26, 2023 at 6:43=E2=80=AFPM Miaohe Lin w= rote: > > for_each_e_css() is unused now. Remove it. > > Signed-off-by: Miaohe Lin LGTM. I can't see any references in Linus's tree or mm-unstable. Reviewed-by: Yosry Ahmed > --- > kernel/cgroup/cgroup.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c > index 625d7483951c..413b4f1f1b70 100644 > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -689,21 +689,6 @@ EXPORT_SYMBOL_GPL(of_css); > lockdep_is_held(&cgroup_mutex)))) { } \ > else > > -/** > - * for_each_e_css - iterate all effective css's of a cgroup > - * @css: the iteration cursor > - * @ssid: the index of the subsystem, CGROUP_SUBSYS_COUNT after reaching= the end > - * @cgrp: the target cgroup to iterate css's of > - * > - * Should be called under cgroup_[tree_]mutex. > - */ > -#define for_each_e_css(css, ssid, cgrp) = \ > - for ((ssid) =3D 0; (ssid) < CGROUP_SUBSYS_COUNT; (ssid)++) = \ > - if (!((css) =3D cgroup_e_css_by_mask(cgrp, = \ > - cgroup_subsys[(ssid)])= )) \ > - ; = \ > - else > - > /** > * do_each_subsys_mask - filter for_each_subsys with a bitmask > * @ss: the iteration cursor > -- > 2.27.0 >