All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Aguilar <davvid@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
	"Git List" <git@vger.kernel.org>,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	"Denton Liu" <liu.denton@gmail.com>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH] contrib/completion: fix remote completion for "git push/remote"
Date: Sat, 29 May 2021 20:32:30 -0700	[thread overview]
Message-ID: <CAJDDKr4rVLYxPpwEg3K4Ok1XUeKhupthPehyKczhHYmFFMF_0Q@mail.gmail.com> (raw)
In-Reply-To: <CAPig+cTOFySGeUKM2oa9nHmkGVaWUbq8ghcid0hHxxSbV6jAjg@mail.gmail.com>

On Sat, May 29, 2021 at 8:12 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Sat, May 29, 2021 at 10:49 PM David Aguilar <davvid@gmail.com> wrote:
> > If __git_cmd_idx is empty then zsh will silelntly fail to
> > complete remotes when doing "git push <tab>".
>
> s/silelntly/silently/


Thanks! I'm going to wait a bit for the completion experts to chime in
before I prepare a v2.

For v2, I'm thinking it might make sense to go ahead and squash both
of the completion changes into a single patch.

(sorry for the noisy resend -- I wasn't in text mode so vger dropped
the original reply)
-- 
David

      reply	other threads:[~2021-05-30  3:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  2:49 [PATCH] contrib/completion: fix remote completion for "git push/remote" David Aguilar
2021-05-30  3:12 ` Eric Sunshine
2021-05-30  3:32   ` David Aguilar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJDDKr4rVLYxPpwEg3K4Ok1XUeKhupthPehyKczhHYmFFMF_0Q@mail.gmail.com \
    --to=davvid@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=liu.denton@gmail.com \
    --cc=sunshine@sunshineco.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.