All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] riscv: tracing: Improve hardirq tracing message
@ 2022-09-01 10:45 ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Currently, hardirq tracing log in riscv showing the last {enabled,disabled}
at __trace_hardirqs_{on,off} all the time.

We can use trace_hardirqs_on_caller to display the caller we really want
to see.

Yipeng Zou (2):
  tracing: hold caller_addr to hardirq_{enable,disable}_ip
  riscv: tracing: Improve hardirq tracing message

 arch/riscv/kernel/trace_irq.c   | 4 ++--
 include/linux/irqflags.h        | 2 ++
 kernel/trace/trace_preemptirq.c | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH 0/2] riscv: tracing: Improve hardirq tracing message
@ 2022-09-01 10:45 ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Currently, hardirq tracing log in riscv showing the last {enabled,disabled}
at __trace_hardirqs_{on,off} all the time.

We can use trace_hardirqs_on_caller to display the caller we really want
to see.

Yipeng Zou (2):
  tracing: hold caller_addr to hardirq_{enable,disable}_ip
  riscv: tracing: Improve hardirq tracing message

 arch/riscv/kernel/trace_irq.c   | 4 ++--
 include/linux/irqflags.h        | 2 ++
 kernel/trace/trace_preemptirq.c | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

-- 
2.17.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip
  2022-09-01 10:45 ` Yipeng Zou
@ 2022-09-01 10:45   ` Yipeng Zou
  -1 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Currently, The arguments passing to lockdep_hardirqs_{on,off} was fixed
in CALLER_ADDR0.
The function trace_hardirqs_on_caller should have been intended to use
caller_addr to represent the address that caller wants to be traced.

For example, lockdep log in riscv showing the last {enabled,disabled} at
__trace_hardirqs_{on,off} all the time(if called by):
[   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
[   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14

After use trace_hardirqs_xx_caller, we can get more effective information:
[   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
[   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
---
 kernel/trace/trace_preemptirq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_preemptirq.c b/kernel/trace/trace_preemptirq.c
index 95b58bd757ce..1e130da1b742 100644
--- a/kernel/trace/trace_preemptirq.c
+++ b/kernel/trace/trace_preemptirq.c
@@ -95,14 +95,14 @@ __visible void trace_hardirqs_on_caller(unsigned long caller_addr)
 	}
 
 	lockdep_hardirqs_on_prepare();
-	lockdep_hardirqs_on(CALLER_ADDR0);
+	lockdep_hardirqs_on(caller_addr);
 }
 EXPORT_SYMBOL(trace_hardirqs_on_caller);
 NOKPROBE_SYMBOL(trace_hardirqs_on_caller);
 
 __visible void trace_hardirqs_off_caller(unsigned long caller_addr)
 {
-	lockdep_hardirqs_off(CALLER_ADDR0);
+	lockdep_hardirqs_off(caller_addr);
 
 	if (!this_cpu_read(tracing_irq_cpu)) {
 		this_cpu_write(tracing_irq_cpu, 1);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip
@ 2022-09-01 10:45   ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Currently, The arguments passing to lockdep_hardirqs_{on,off} was fixed
in CALLER_ADDR0.
The function trace_hardirqs_on_caller should have been intended to use
caller_addr to represent the address that caller wants to be traced.

For example, lockdep log in riscv showing the last {enabled,disabled} at
__trace_hardirqs_{on,off} all the time(if called by):
[   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
[   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14

After use trace_hardirqs_xx_caller, we can get more effective information:
[   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
[   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
---
 kernel/trace/trace_preemptirq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/trace_preemptirq.c b/kernel/trace/trace_preemptirq.c
index 95b58bd757ce..1e130da1b742 100644
--- a/kernel/trace/trace_preemptirq.c
+++ b/kernel/trace/trace_preemptirq.c
@@ -95,14 +95,14 @@ __visible void trace_hardirqs_on_caller(unsigned long caller_addr)
 	}
 
 	lockdep_hardirqs_on_prepare();
-	lockdep_hardirqs_on(CALLER_ADDR0);
+	lockdep_hardirqs_on(caller_addr);
 }
 EXPORT_SYMBOL(trace_hardirqs_on_caller);
 NOKPROBE_SYMBOL(trace_hardirqs_on_caller);
 
 __visible void trace_hardirqs_off_caller(unsigned long caller_addr)
 {
-	lockdep_hardirqs_off(CALLER_ADDR0);
+	lockdep_hardirqs_off(caller_addr);
 
 	if (!this_cpu_read(tracing_irq_cpu)) {
 		this_cpu_write(tracing_irq_cpu, 1);
-- 
2.17.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
  2022-09-01 10:45 ` Yipeng Zou
@ 2022-09-01 10:45   ` Yipeng Zou
  -1 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Use trace_hardirqs_on_caller to improve irq_tracing message.

lockdep log in riscv showing the last {enabled,disabled} at
__trace_hardirqs_{on,off} all the time(if called by).
But that's not what we want to see, the caller is what we want.

Before this commit:
[   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
[   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14

After this commit
[   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
[   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
---
 arch/riscv/kernel/trace_irq.c | 4 ++--
 include/linux/irqflags.h      | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c
index 095ac976d7da..7ca24b26e19f 100644
--- a/arch/riscv/kernel/trace_irq.c
+++ b/arch/riscv/kernel/trace_irq.c
@@ -16,12 +16,12 @@
 
 void __trace_hardirqs_on(void)
 {
-	trace_hardirqs_on();
+	trace_hardirqs_on_caller(CALLER_ADDR0);
 }
 NOKPROBE_SYMBOL(__trace_hardirqs_on);
 
 void __trace_hardirqs_off(void)
 {
-	trace_hardirqs_off();
+	trace_hardirqs_off_caller(CALLER_ADDR0);
 }
 NOKPROBE_SYMBOL(__trace_hardirqs_off);
diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index 5ec0fa71399e..46774fa85cde 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
 extern void trace_hardirqs_off_finish(void);
 extern void trace_hardirqs_on(void);
 extern void trace_hardirqs_off(void);
+extern void trace_hardirqs_on_caller(unsigned long caller_addr);
+extern void trace_hardirqs_off_caller(unsigned long caller_addr);
 
 # define lockdep_hardirq_context()	(raw_cpu_read(hardirq_context))
 # define lockdep_softirq_context(p)	((p)->softirq_context)
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
@ 2022-09-01 10:45   ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-01 10:45 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh, zouyipeng

Use trace_hardirqs_on_caller to improve irq_tracing message.

lockdep log in riscv showing the last {enabled,disabled} at
__trace_hardirqs_{on,off} all the time(if called by).
But that's not what we want to see, the caller is what we want.

Before this commit:
[   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
[   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14

After this commit
[   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
[   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
---
 arch/riscv/kernel/trace_irq.c | 4 ++--
 include/linux/irqflags.h      | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c
index 095ac976d7da..7ca24b26e19f 100644
--- a/arch/riscv/kernel/trace_irq.c
+++ b/arch/riscv/kernel/trace_irq.c
@@ -16,12 +16,12 @@
 
 void __trace_hardirqs_on(void)
 {
-	trace_hardirqs_on();
+	trace_hardirqs_on_caller(CALLER_ADDR0);
 }
 NOKPROBE_SYMBOL(__trace_hardirqs_on);
 
 void __trace_hardirqs_off(void)
 {
-	trace_hardirqs_off();
+	trace_hardirqs_off_caller(CALLER_ADDR0);
 }
 NOKPROBE_SYMBOL(__trace_hardirqs_off);
diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
index 5ec0fa71399e..46774fa85cde 100644
--- a/include/linux/irqflags.h
+++ b/include/linux/irqflags.h
@@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
 extern void trace_hardirqs_off_finish(void);
 extern void trace_hardirqs_on(void);
 extern void trace_hardirqs_off(void);
+extern void trace_hardirqs_on_caller(unsigned long caller_addr);
+extern void trace_hardirqs_off_caller(unsigned long caller_addr);
 
 # define lockdep_hardirq_context()	(raw_cpu_read(hardirq_context))
 # define lockdep_softirq_context(p)	((p)->softirq_context)
-- 
2.17.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip
  2022-09-01 10:45   ` Yipeng Zou
@ 2022-09-07  1:12     ` Steven Rostedt
  -1 siblings, 0 replies; 13+ messages in thread
From: Steven Rostedt @ 2022-09-07  1:12 UTC (permalink / raw)
  To: Yipeng Zou
  Cc: linux-riscv, linux-kernel, mingo, paul.walmsley, palmer, aou,
	liaochang1, chris.zjh, Joel Fernandes

On Thu, 1 Sep 2022 18:45:14 +0800
Yipeng Zou <zouyipeng@huawei.com> wrote:

> Currently, The arguments passing to lockdep_hardirqs_{on,off} was fixed
> in CALLER_ADDR0.
> The function trace_hardirqs_on_caller should have been intended to use
> caller_addr to represent the address that caller wants to be traced.
> 
> For example, lockdep log in riscv showing the last {enabled,disabled} at
> __trace_hardirqs_{on,off} all the time(if called by):
> [   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
> [   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14
> 
> After use trace_hardirqs_xx_caller, we can get more effective information:
> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
> [   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

I'm going to mark this as stable and send it in my next push to Linus.

I'll also add:

Fixes: c3bc8fd637a96 ("tracing: Centralize preemptirq tracepoints and unify their usage")

The code was copied from functions that were originally called directly,
but now that they are called indirectly, CALLER_ADDR0 is not the right
thing to use.

Thanks!

-- Steve


> 
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> ---
>  kernel/trace/trace_preemptirq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_preemptirq.c b/kernel/trace/trace_preemptirq.c
> index 95b58bd757ce..1e130da1b742 100644
> --- a/kernel/trace/trace_preemptirq.c
> +++ b/kernel/trace/trace_preemptirq.c
> @@ -95,14 +95,14 @@ __visible void trace_hardirqs_on_caller(unsigned long caller_addr)
>  	}
>  
>  	lockdep_hardirqs_on_prepare();
> -	lockdep_hardirqs_on(CALLER_ADDR0);
> +	lockdep_hardirqs_on(caller_addr);
>  }
>  EXPORT_SYMBOL(trace_hardirqs_on_caller);
>  NOKPROBE_SYMBOL(trace_hardirqs_on_caller);
>  
>  __visible void trace_hardirqs_off_caller(unsigned long caller_addr)
>  {
> -	lockdep_hardirqs_off(CALLER_ADDR0);
> +	lockdep_hardirqs_off(caller_addr);
>  
>  	if (!this_cpu_read(tracing_irq_cpu)) {
>  		this_cpu_write(tracing_irq_cpu, 1);


^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip
@ 2022-09-07  1:12     ` Steven Rostedt
  0 siblings, 0 replies; 13+ messages in thread
From: Steven Rostedt @ 2022-09-07  1:12 UTC (permalink / raw)
  To: Yipeng Zou
  Cc: linux-riscv, linux-kernel, mingo, paul.walmsley, palmer, aou,
	liaochang1, chris.zjh, Joel Fernandes

On Thu, 1 Sep 2022 18:45:14 +0800
Yipeng Zou <zouyipeng@huawei.com> wrote:

> Currently, The arguments passing to lockdep_hardirqs_{on,off} was fixed
> in CALLER_ADDR0.
> The function trace_hardirqs_on_caller should have been intended to use
> caller_addr to represent the address that caller wants to be traced.
> 
> For example, lockdep log in riscv showing the last {enabled,disabled} at
> __trace_hardirqs_{on,off} all the time(if called by):
> [   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
> [   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14
> 
> After use trace_hardirqs_xx_caller, we can get more effective information:
> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
> [   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10

I'm going to mark this as stable and send it in my next push to Linus.

I'll also add:

Fixes: c3bc8fd637a96 ("tracing: Centralize preemptirq tracepoints and unify their usage")

The code was copied from functions that were originally called directly,
but now that they are called indirectly, CALLER_ADDR0 is not the right
thing to use.

Thanks!

-- Steve


> 
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> ---
>  kernel/trace/trace_preemptirq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_preemptirq.c b/kernel/trace/trace_preemptirq.c
> index 95b58bd757ce..1e130da1b742 100644
> --- a/kernel/trace/trace_preemptirq.c
> +++ b/kernel/trace/trace_preemptirq.c
> @@ -95,14 +95,14 @@ __visible void trace_hardirqs_on_caller(unsigned long caller_addr)
>  	}
>  
>  	lockdep_hardirqs_on_prepare();
> -	lockdep_hardirqs_on(CALLER_ADDR0);
> +	lockdep_hardirqs_on(caller_addr);
>  }
>  EXPORT_SYMBOL(trace_hardirqs_on_caller);
>  NOKPROBE_SYMBOL(trace_hardirqs_on_caller);
>  
>  __visible void trace_hardirqs_off_caller(unsigned long caller_addr)
>  {
> -	lockdep_hardirqs_off(CALLER_ADDR0);
> +	lockdep_hardirqs_off(caller_addr);
>  
>  	if (!this_cpu_read(tracing_irq_cpu)) {
>  		this_cpu_write(tracing_irq_cpu, 1);


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
  2022-09-01 10:45   ` Yipeng Zou
@ 2022-09-09  9:40     ` Yipeng Zou
  -1 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-09  9:40 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh

Ping.

在 2022/9/1 18:45, Yipeng Zou 写道:
> Use trace_hardirqs_on_caller to improve irq_tracing message.
>
> lockdep log in riscv showing the last {enabled,disabled} at
> __trace_hardirqs_{on,off} all the time(if called by).
> But that's not what we want to see, the caller is what we want.
>
> Before this commit:
> [   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
> [   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14
>
> After this commit
> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
> [   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10
>
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> ---
>   arch/riscv/kernel/trace_irq.c | 4 ++--
>   include/linux/irqflags.h      | 2 ++
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c
> index 095ac976d7da..7ca24b26e19f 100644
> --- a/arch/riscv/kernel/trace_irq.c
> +++ b/arch/riscv/kernel/trace_irq.c
> @@ -16,12 +16,12 @@
>   
>   void __trace_hardirqs_on(void)
>   {
> -	trace_hardirqs_on();
> +	trace_hardirqs_on_caller(CALLER_ADDR0);
>   }
>   NOKPROBE_SYMBOL(__trace_hardirqs_on);
>   
>   void __trace_hardirqs_off(void)
>   {
> -	trace_hardirqs_off();
> +	trace_hardirqs_off_caller(CALLER_ADDR0);
>   }
>   NOKPROBE_SYMBOL(__trace_hardirqs_off);
> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
> index 5ec0fa71399e..46774fa85cde 100644
> --- a/include/linux/irqflags.h
> +++ b/include/linux/irqflags.h
> @@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
>   extern void trace_hardirqs_off_finish(void);
>   extern void trace_hardirqs_on(void);
>   extern void trace_hardirqs_off(void);
> +extern void trace_hardirqs_on_caller(unsigned long caller_addr);
> +extern void trace_hardirqs_off_caller(unsigned long caller_addr);
>   
>   # define lockdep_hardirq_context()	(raw_cpu_read(hardirq_context))
>   # define lockdep_softirq_context(p)	((p)->softirq_context)

-- 
Regards,
Yipeng Zou


^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
@ 2022-09-09  9:40     ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-09  9:40 UTC (permalink / raw)
  To: linux-riscv, linux-kernel, rostedt, mingo, paul.walmsley, palmer, aou
  Cc: liaochang1, chris.zjh

Ping.

在 2022/9/1 18:45, Yipeng Zou 写道:
> Use trace_hardirqs_on_caller to improve irq_tracing message.
>
> lockdep log in riscv showing the last {enabled,disabled} at
> __trace_hardirqs_{on,off} all the time(if called by).
> But that's not what we want to see, the caller is what we want.
>
> Before this commit:
> [   57.853175] hardirqs last  enabled at (2519): __trace_hardirqs_on+0xc/0x14
> [   57.853848] hardirqs last disabled at (2520): __trace_hardirqs_off+0xc/0x14
>
> After this commit
> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
> [   53.782185] hardirqs last disabled at (2596): ret_from_exception+0xa/0x10
>
> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> ---
>   arch/riscv/kernel/trace_irq.c | 4 ++--
>   include/linux/irqflags.h      | 2 ++
>   2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kernel/trace_irq.c b/arch/riscv/kernel/trace_irq.c
> index 095ac976d7da..7ca24b26e19f 100644
> --- a/arch/riscv/kernel/trace_irq.c
> +++ b/arch/riscv/kernel/trace_irq.c
> @@ -16,12 +16,12 @@
>   
>   void __trace_hardirqs_on(void)
>   {
> -	trace_hardirqs_on();
> +	trace_hardirqs_on_caller(CALLER_ADDR0);
>   }
>   NOKPROBE_SYMBOL(__trace_hardirqs_on);
>   
>   void __trace_hardirqs_off(void)
>   {
> -	trace_hardirqs_off();
> +	trace_hardirqs_off_caller(CALLER_ADDR0);
>   }
>   NOKPROBE_SYMBOL(__trace_hardirqs_off);
> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
> index 5ec0fa71399e..46774fa85cde 100644
> --- a/include/linux/irqflags.h
> +++ b/include/linux/irqflags.h
> @@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
>   extern void trace_hardirqs_off_finish(void);
>   extern void trace_hardirqs_on(void);
>   extern void trace_hardirqs_off(void);
> +extern void trace_hardirqs_on_caller(unsigned long caller_addr);
> +extern void trace_hardirqs_off_caller(unsigned long caller_addr);
>   
>   # define lockdep_hardirq_context()	(raw_cpu_read(hardirq_context))
>   # define lockdep_softirq_context(p)	((p)->softirq_context)

-- 
Regards,
Yipeng Zou


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
  2022-09-09  9:40     ` Yipeng Zou
  (?)
@ 2022-09-14  7:29     ` Yipeng Zou
  2022-09-15  1:34       ` Guo Ren
  -1 siblings, 1 reply; 13+ messages in thread
From: Yipeng Zou @ 2022-09-14  7:29 UTC (permalink / raw)
  To: linux-riscv, rostedt, mingo, paul.walmsley, palmer, aou, Guo Ren
  Cc: liaochang1, chris.zjh

Loop in guoren@kernel.org,

Please help review on this patch, thanks very much.

在 2022/9/9 17:40, Yipeng Zou 写道:
> Ping.
>
> 在 2022/9/1 18:45, Yipeng Zou 写道:
>> Use trace_hardirqs_on_caller to improve irq_tracing message.
>>
>> lockdep log in riscv showing the last {enabled,disabled} at
>> __trace_hardirqs_{on,off} all the time(if called by).
>> But that's not what we want to see, the caller is what we want.
>>
>> Before this commit:
>> [   57.853175] hardirqs last  enabled at (2519): 
>> __trace_hardirqs_on+0xc/0x14
>> [   57.853848] hardirqs last disabled at (2520): 
>> __trace_hardirqs_off+0xc/0x14
>>
>> After this commit
>> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
>> [   53.782185] hardirqs last disabled at (2596): 
>> ret_from_exception+0xa/0x10
>>
>> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
>> ---
>>   arch/riscv/kernel/trace_irq.c | 4 ++--
>>   include/linux/irqflags.h      | 2 ++
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/riscv/kernel/trace_irq.c 
>> b/arch/riscv/kernel/trace_irq.c
>> index 095ac976d7da..7ca24b26e19f 100644
>> --- a/arch/riscv/kernel/trace_irq.c
>> +++ b/arch/riscv/kernel/trace_irq.c
>> @@ -16,12 +16,12 @@
>>     void __trace_hardirqs_on(void)
>>   {
>> -    trace_hardirqs_on();
>> +    trace_hardirqs_on_caller(CALLER_ADDR0);
>>   }
>>   NOKPROBE_SYMBOL(__trace_hardirqs_on);
>>     void __trace_hardirqs_off(void)
>>   {
>> -    trace_hardirqs_off();
>> +    trace_hardirqs_off_caller(CALLER_ADDR0);
>>   }
>>   NOKPROBE_SYMBOL(__trace_hardirqs_off);
>> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
>> index 5ec0fa71399e..46774fa85cde 100644
>> --- a/include/linux/irqflags.h
>> +++ b/include/linux/irqflags.h
>> @@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
>>   extern void trace_hardirqs_off_finish(void);
>>   extern void trace_hardirqs_on(void);
>>   extern void trace_hardirqs_off(void);
>> +extern void trace_hardirqs_on_caller(unsigned long caller_addr);
>> +extern void trace_hardirqs_off_caller(unsigned long caller_addr);
>>     # define lockdep_hardirq_context() (raw_cpu_read(hardirq_context))
>>   # define lockdep_softirq_context(p) ((p)->softirq_context)
>
-- 
Regards,
Yipeng Zou


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
  2022-09-14  7:29     ` Yipeng Zou
@ 2022-09-15  1:34       ` Guo Ren
  2022-09-15  2:42         ` Yipeng Zou
  0 siblings, 1 reply; 13+ messages in thread
From: Guo Ren @ 2022-09-15  1:34 UTC (permalink / raw)
  To: Yipeng Zou
  Cc: linux-riscv, rostedt, mingo, paul.walmsley, palmer, aou,
	liaochang1, chris.zjh

Add Fixes tag, and the upstream should go to generic entry.

Just for stable branches fixup:
Acked-by: Guo Ren <guoren@kernel.org>

On Wed, Sep 14, 2022 at 3:29 PM Yipeng Zou <zouyipeng@huawei.com> wrote:
>
> Loop in guoren@kernel.org,
>
> Please help review on this patch, thanks very much.
>
> 在 2022/9/9 17:40, Yipeng Zou 写道:
> > Ping.
> >
> > 在 2022/9/1 18:45, Yipeng Zou 写道:
> >> Use trace_hardirqs_on_caller to improve irq_tracing message.
> >>
> >> lockdep log in riscv showing the last {enabled,disabled} at
> >> __trace_hardirqs_{on,off} all the time(if called by).
> >> But that's not what we want to see, the caller is what we want.
> >>
> >> Before this commit:
> >> [   57.853175] hardirqs last  enabled at (2519):
> >> __trace_hardirqs_on+0xc/0x14
> >> [   57.853848] hardirqs last disabled at (2520):
> >> __trace_hardirqs_off+0xc/0x14
> >>
> >> After this commit
> >> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
> >> [   53.782185] hardirqs last disabled at (2596):
> >> ret_from_exception+0xa/0x10
> >>
> >> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
> >> ---
> >>   arch/riscv/kernel/trace_irq.c | 4 ++--
> >>   include/linux/irqflags.h      | 2 ++
> >>   2 files changed, 4 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/riscv/kernel/trace_irq.c
> >> b/arch/riscv/kernel/trace_irq.c
> >> index 095ac976d7da..7ca24b26e19f 100644
> >> --- a/arch/riscv/kernel/trace_irq.c
> >> +++ b/arch/riscv/kernel/trace_irq.c
> >> @@ -16,12 +16,12 @@
> >>     void __trace_hardirqs_on(void)
> >>   {
> >> -    trace_hardirqs_on();
> >> +    trace_hardirqs_on_caller(CALLER_ADDR0);
> >>   }
> >>   NOKPROBE_SYMBOL(__trace_hardirqs_on);
> >>     void __trace_hardirqs_off(void)
> >>   {
> >> -    trace_hardirqs_off();
> >> +    trace_hardirqs_off_caller(CALLER_ADDR0);
> >>   }
> >>   NOKPROBE_SYMBOL(__trace_hardirqs_off);
> >> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
> >> index 5ec0fa71399e..46774fa85cde 100644
> >> --- a/include/linux/irqflags.h
> >> +++ b/include/linux/irqflags.h
> >> @@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
> >>   extern void trace_hardirqs_off_finish(void);
> >>   extern void trace_hardirqs_on(void);
> >>   extern void trace_hardirqs_off(void);
> >> +extern void trace_hardirqs_on_caller(unsigned long caller_addr);
> >> +extern void trace_hardirqs_off_caller(unsigned long caller_addr);
> >>     # define lockdep_hardirq_context() (raw_cpu_read(hardirq_context))
> >>   # define lockdep_softirq_context(p) ((p)->softirq_context)
> >
> --
> Regards,
> Yipeng Zou
>


-- 
Best Regards
 Guo Ren

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] riscv: tracing: Improve hardirq tracing message
  2022-09-15  1:34       ` Guo Ren
@ 2022-09-15  2:42         ` Yipeng Zou
  0 siblings, 0 replies; 13+ messages in thread
From: Yipeng Zou @ 2022-09-15  2:42 UTC (permalink / raw)
  To: Guo Ren
  Cc: linux-riscv, rostedt, mingo, paul.walmsley, palmer, aou,
	liaochang1, chris.zjh


在 2022/9/15 9:34, Guo Ren 写道:
> Add Fixes tag, and the upstream should go to generic entry.
>
> Just for stable branches fixup:
> Acked-by: Guo Ren <guoren@kernel.org>
ok,thanks for review.
> On Wed, Sep 14, 2022 at 3:29 PM Yipeng Zou <zouyipeng@huawei.com> wrote:
>> Loop in guoren@kernel.org,
>>
>> Please help review on this patch, thanks very much.
>>
>> 在 2022/9/9 17:40, Yipeng Zou 写道:
>>> Ping.
>>>
>>> 在 2022/9/1 18:45, Yipeng Zou 写道:
>>>> Use trace_hardirqs_on_caller to improve irq_tracing message.
>>>>
>>>> lockdep log in riscv showing the last {enabled,disabled} at
>>>> __trace_hardirqs_{on,off} all the time(if called by).
>>>> But that's not what we want to see, the caller is what we want.
>>>>
>>>> Before this commit:
>>>> [   57.853175] hardirqs last  enabled at (2519):
>>>> __trace_hardirqs_on+0xc/0x14
>>>> [   57.853848] hardirqs last disabled at (2520):
>>>> __trace_hardirqs_off+0xc/0x14
>>>>
>>>> After this commit
>>>> [   53.781428] hardirqs last  enabled at (2595): restore_all+0xe/0x66
>>>> [   53.782185] hardirqs last disabled at (2596):
>>>> ret_from_exception+0xa/0x10
>>>>
>>>> Signed-off-by: Yipeng Zou <zouyipeng@huawei.com>
>>>> ---
>>>>    arch/riscv/kernel/trace_irq.c | 4 ++--
>>>>    include/linux/irqflags.h      | 2 ++
>>>>    2 files changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/riscv/kernel/trace_irq.c
>>>> b/arch/riscv/kernel/trace_irq.c
>>>> index 095ac976d7da..7ca24b26e19f 100644
>>>> --- a/arch/riscv/kernel/trace_irq.c
>>>> +++ b/arch/riscv/kernel/trace_irq.c
>>>> @@ -16,12 +16,12 @@
>>>>      void __trace_hardirqs_on(void)
>>>>    {
>>>> -    trace_hardirqs_on();
>>>> +    trace_hardirqs_on_caller(CALLER_ADDR0);
>>>>    }
>>>>    NOKPROBE_SYMBOL(__trace_hardirqs_on);
>>>>      void __trace_hardirqs_off(void)
>>>>    {
>>>> -    trace_hardirqs_off();
>>>> +    trace_hardirqs_off_caller(CALLER_ADDR0);
>>>>    }
>>>>    NOKPROBE_SYMBOL(__trace_hardirqs_off);
>>>> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h
>>>> index 5ec0fa71399e..46774fa85cde 100644
>>>> --- a/include/linux/irqflags.h
>>>> +++ b/include/linux/irqflags.h
>>>> @@ -53,6 +53,8 @@ extern void trace_hardirqs_on_prepare(void);
>>>>    extern void trace_hardirqs_off_finish(void);
>>>>    extern void trace_hardirqs_on(void);
>>>>    extern void trace_hardirqs_off(void);
>>>> +extern void trace_hardirqs_on_caller(unsigned long caller_addr);
>>>> +extern void trace_hardirqs_off_caller(unsigned long caller_addr);
>>>>      # define lockdep_hardirq_context() (raw_cpu_read(hardirq_context))
>>>>    # define lockdep_softirq_context(p) ((p)->softirq_context)
>> --
>> Regards,
>> Yipeng Zou
>>
>
-- 
Regards,
Yipeng Zou


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-09-15  2:43 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 10:45 [PATCH 0/2] riscv: tracing: Improve hardirq tracing message Yipeng Zou
2022-09-01 10:45 ` Yipeng Zou
2022-09-01 10:45 ` [PATCH 1/2] tracing: hold caller_addr to hardirq_{enable,disable}_ip Yipeng Zou
2022-09-01 10:45   ` Yipeng Zou
2022-09-07  1:12   ` Steven Rostedt
2022-09-07  1:12     ` Steven Rostedt
2022-09-01 10:45 ` [PATCH 2/2] riscv: tracing: Improve hardirq tracing message Yipeng Zou
2022-09-01 10:45   ` Yipeng Zou
2022-09-09  9:40   ` Yipeng Zou
2022-09-09  9:40     ` Yipeng Zou
2022-09-14  7:29     ` Yipeng Zou
2022-09-15  1:34       ` Guo Ren
2022-09-15  2:42         ` Yipeng Zou

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.