From: David Marchand <david.marchand@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
Date: Tue, 12 Jan 2021 09:14:14 +0100 [thread overview]
Message-ID: <CAJFAV8w-0tSet3cAoCZcQZoZZrJgCwf0=hKrLCoDCwLq_TsCjg@mail.gmail.com> (raw)
In-Reply-To: <1610390183-22709-1-git-send-email-roretzla@linux.microsoft.com>
On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
Commitlog please.
>
> From: Tyler Retzlaff <roretzla@microsoft.com>
>
> ---
> lib/librte_eal/common/meson.build | 1 +
> lib/librte_eal/rte_eal_exports.def | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> index 39abf7a0a..9c6f18eb8 100644
> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
> @@ -34,6 +34,7 @@ if is_windows
> 'rte_malloc.c',
> 'eal_common_timer.c',
> 'rte_service.c',
> + 'rte_reciprocal.c',
> )
> subdir_done()
> endif
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 4597eb8cd..ba1443dc2 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -326,3 +326,4 @@ EXPORTS
> rte_mem_map
> rte_mem_page_size
> rte_mem_unmap
> + rte_reciprocal_value_u64
Looking at rte_reciprocal.c/.h and EAL version.map, this API exports
two symbols.
If there is no reason why the other symbol has been skipped, please add both:
rte_reciprocal_value
rte_reciprocal_value_u64
--
David Marchand
next prev parent reply other threads:[~2021-01-12 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 18:36 [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 Tyler Retzlaff
2021-01-12 8:14 ` David Marchand [this message]
2021-01-12 8:17 ` David Marchand
2021-01-12 16:08 ` Tyler Retzlaff
[not found] <20 210111183640.CE1D7106B@dpdk.org>
[not found] ` <1610391337-24080-1-git-send-email-roretzla@linux.microsoft.com>
2021-01-11 18:55 ` Tyler Retzlaff
2021-01-11 20:29 ` Dmitry Kozlyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8w-0tSet3cAoCZcQZoZZrJgCwf0=hKrLCoDCwLq_TsCjg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.