All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Selwin Sebastian <selwin.sebastian@amd.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver
Date: Mon, 6 Sep 2021 19:17:43 +0200	[thread overview]
Message-ID: <CAJFAV8wFTYcW1azcd9PubxCi4aNVvrpzzq4TwWgPXfwY-gF6Yw@mail.gmail.com> (raw)
In-Reply-To: <20210906165556.65015-1-selwin.sebastian@amd.com>

On Mon, Sep 6, 2021 at 6:56 PM Selwin Sebastian
<selwin.sebastian@amd.com> wrote:
>
> Add support for PTDMA driver

- This description is rather short.

Can this new driver be implemented as a dmadev?
See (current revision):
https://patchwork.dpdk.org/project/dpdk/list/?series=18677&state=%2A&archive=both


- In any case, quick comments on this patch:
Please update release notes.
vfio-pci should be preferred over igb_uio.
Please check indent in meson.
ABI version is incorrect in version.map.
RTE_LOG_REGISTER_DEFAULT should be preferred.
The patch is monolithic, could it be split per functionnality to ease review?

Copy relevant maintainers and/or (sub-)tree maintainers to make them
aware of this work, and get those patches reviewed.
Please submit new revisions of patchsets with increased revision
number in title + changelog that helps track what changed between
revisions.

Some of those points are described in:
https://doc.dpdk.org/guides/contributing/patches.html


Thanks.

-- 
David Marchand


  reply	other threads:[~2021-09-06 17:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 16:55 [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver Selwin Sebastian
2021-09-06 17:17 ` David Marchand [this message]
2021-10-27 14:59   ` Thomas Monjalon
2021-10-28 14:54     ` Sebastian, Selwin
2022-06-15 14:35       ` Thomas Monjalon
2022-06-16 14:27         ` Sebastian, Selwin
2023-06-28  9:08           ` Ferruh Yigit
  -- strict thread matches above, loose matches on Subject: below --
2021-09-06 15:59 Selwin Sebastian
2021-09-06 14:34 Selwin Sebastian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wFTYcW1azcd9PubxCi4aNVvrpzzq4TwWgPXfwY-gF6Yw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=selwin.sebastian@amd.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.