From: David Marchand <david.marchand@redhat.com>
To: Kiran KN <kirankn@juniper.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] eal: changes for setting control thread mask
Date: Tue, 21 Apr 2020 10:01:34 +0200 [thread overview]
Message-ID: <CAJFAV8wbRFisU=it2AJ3Vp_3rChY10N2ftzOXKXnVFDAAXRdwA@mail.gmail.com> (raw)
In-Reply-To: <1BA38E99-C6F7-4A17-B6CA-D1D06F707590@juniper.net>
On Tue, Apr 21, 2020 at 9:42 AM Kiran KN <kirankn@juniper.net> wrote:
> Define a global variable ctrl_thread_set which the application can set.
> If this is the case, use this for setting control thread affinity instead
> of deducing it from the existing core pinning of the process.
I am unconvinced on adding an EAL option for this.
It needs an explanation on why you can't rely on the dpdk process
current affinity for control threads.
And we will need a unit test.
Please rebase your patch on master too.
> signed-off-by: Kiran KN <kirankn@juniper.net>
Signed-off-by*
--
David Marchand
next prev parent reply other threads:[~2020-04-21 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 7:42 [dpdk-dev] [PATCH] eal: changes for setting control thread mask Kiran KN
2020-04-21 8:01 ` David Marchand [this message]
2021-03-25 14:51 ` David Marchand
2021-03-27 18:54 ` Kiran KN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wbRFisU=it2AJ3Vp_3rChY10N2ftzOXKXnVFDAAXRdwA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kirankn@juniper.net \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.