Re: [dpdk-dev] [PATCH v2] graph: do not use a possibly NULL Pointer

From: David Marchand <david.marchand@redhat.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	dpdk stable <stable@dpdk.org>,  Jerin Jacob <jerinj@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] graph: do not use a possibly NULL Pointer
Date: Tue, 25 May 2021 08:51:10 +0200	[thread overview]
Message-ID: <CAJFAV8wjo+c=rpmt_Xe_rXfNwKp4eRHxZz2+xpSJhx4vBcN0ag@mail.gmail.com> (raw)
In-Reply-To: <20210524093136.20525-1-thierry.herbelot@6wind.com>

On Mon, May 24, 2021 at 11:31 AM Thierry Herbelot
<thierry.herbelot@6wind.com> wrote:
>
> Use stats only after it was checked not to be NULL.
>
> Fixes: af1ae8b6a32c9 ("graph: implement stats")
> Cc: stable@dpdk.org
> Cc: Jerin Jacob <jerinj@marvell.com>
> Cc: Kiran Kumar K <kirankumark@marvell.com>
>
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: reword patch title
> ---
>  lib/graph/graph_stats.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c
> index 125e08d73290..a52994f0f61e 100644
> --- a/lib/graph/graph_stats.c
> +++ b/lib/graph/graph_stats.c
> @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster,
>         cluster_node_size = RTE_ALIGN(cluster_node_size, RTE_CACHE_LINE_SIZE);
>
>         stats = realloc(NULL, sz);
> -       memset(stats, 0, sz);
>         if (stats) {
> +               memset(stats, 0, sz);
>                 stats->fn = fn;
>                 stats->cluster_node_size = cluster_node_size;
>                 stats->max_nodes = 0;

Please update your patches status in patchwork when submitting new revisions.

Besides, the same fix had been posted by Min Hu:
http://patchwork.dpdk.org/project/dpdk/patch/1620285387-42792-3-git-send-email-humin29@huawei.com/

-- 
David Marchand